Re: [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink

Tom Tromey
2017-11-03T16:39:06Z

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Just one tiny nit: when possible, I like to replace strcmp with
Simon> std::string's operator==
Simon> if (dir == symlink_dir.get ())
Simon> but I'll leave it up to you.

Good idea, I made this change; though I think it should be != due to:

> + if (strcmp (dir.c_str (), symlink_dir.get ()) != 0)

Tom