From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123547 invoked by alias); 3 Nov 2017 01:59:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123422 invoked by uid 89); 3 Nov 2017 01:59:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=urge X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 01:59:02 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vA31wuFB031247 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 2 Nov 2017 21:59:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 131EB1E533; Thu, 2 Nov 2017 21:58:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id BE5951E4C4; Thu, 2 Nov 2017 21:58:44 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Nov 2017 01:59:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 13/13] Use std::vector in h8300-tdep.c In-Reply-To: <20171102223612.3642-14-tom@tromey.com> References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-14-tom@tromey.com> Message-ID: <7ceb86abccf9473257045f37134b4387@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Nov 2017 01:58:56 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00063.txt.bz2 On 2017-11-02 18:36, Tom Tromey wrote: > This changes h8300-tdep.c to use std::vector, allowing the removal of > a cleanup. > > gdb/ChangeLog > 2017-11-02 Tom Tromey > > * h8300-tdep.c (h8300_push_dummy_call): Use std::vector. > --- > gdb/ChangeLog | 4 ++++ > gdb/h8300-tdep.c | 16 ++++++---------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c > index 011afcaba4..b9936c0283 100644 > --- a/gdb/h8300-tdep.c > +++ b/gdb/h8300-tdep.c > @@ -662,18 +662,16 @@ h8300_push_dummy_call (struct gdbarch *gdbarch, > struct value *function, > > for (argument = 0; argument < nargs; argument++) > { > - struct cleanup *back_to; > struct type *type = value_type (args[argument]); > int len = TYPE_LENGTH (type); > char *contents = (char *) value_contents (args[argument]); > > /* Pad the argument appropriately. */ > int padded_len = align_up (len, wordsize); > - gdb_byte *padded = (gdb_byte *) xmalloc (padded_len); > - back_to = make_cleanup (xfree, padded); > + std::vector padded (padded_len); I would suggest adding a comment that std::vector is used (and not gdb::byte_vector) because we want it to be zero-ed out. Otherwise someone will feel the urge to change it to gdb::byte_vector some day :). Simon