From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6X+UDIffiGfP8hAAWB0awg (envelope-from ) for ; Thu, 16 Jan 2025 05:29:27 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=m1PG/ilZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 245AF1E100; Thu, 16 Jan 2025 05:29:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F2FC91E08E for ; Thu, 16 Jan 2025 05:29:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BC5F385087F for ; Thu, 16 Jan 2025 10:29:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BC5F385087F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=m1PG/ilZ Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::3]) by sourceware.org (Postfix) with ESMTPS id A3587385086F for ; Thu, 16 Jan 2025 10:27:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3587385086F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A3587385086F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c201::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1737023240; cv=pass; b=xECXnEr0u3D7OqWfZ7mI3NkctiT/H1Fycy2V86OihWLS12dQzHFWVz8CbbCma6pP5JN5CwlDbi7WQByVSF5gesaRvxRuWl+uIaj425cklFhs0xSb04no61l/+6Q316qG2XKwfWLk4F6DnWWUhgHhCkbtdRZW5s6NJhT3UKMln1k= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1737023240; c=relaxed/simple; bh=LcBjmv50OlpZ5HSa3+jF3AQfvg3JFyhiL/CS/DnnMJc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=kKVDwR3LIKYO2yaDcs7W3z+Ch8UYuKKZKopIApptd5VjQ5w7riaDNAVNwJ+qoYPaKfZ8Q5oiShFqU4qG1tJ1NXid9cpNCN/7hPTE3qoS8NoLc3h70dOvjhLaBTcZwMUvqyLsOjPPOLh4gW9+HB4kCQsX9Wv30ppimOvrGTs20xs= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3587385086F ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jSz8WNRTiDAIgnR5EW79r7mORTYXYkYUOSQr63ccisHBFqeHB3wSk+EW6FxaqyO+M96ji2KSZtMN1aF04G4HG19SQjhh7UgzNxB0nb9vZX4rT3X4Oco65VAwEm6jP/2TI6RyAZXimDMzhb84ZIJQc/DWiY5gIu/U/7TOCkM7BT0NdGy56evyigG7BGuCI1P1kW7P6FgeWuLG1ia+SAL4gegAHg52ZIKM+yWmKhH3kCmLJZ9q1LhViMu0CnsCYs3ILhm1xN81lzxTBJCS+nZJsP0OnJIWYsM1hCAMN888cEfehD0L9PlX3QllqNJLx4hfkQ1pakn1Nef5SZmf64K7Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gk36A0yVIkDU5Qy+dJ4QVpOCeNDSCrdjdbO0P/w+2bM=; b=yA6OHzGBI4BHoZ7jCBxSZ4st0Tu+xuo6xlmTyVTw9OwrWyAtdpcKIUG7K92ke5P3TVfgATlDtORX/RgMV3RYpXzh8YKkVjGaMxWDwEFwRU9nggzYGwuMonPfrZJEXqGhmCOzkt/izR695ZB3/A9p1jRPZWy7wFWRjDNsLklN+kNSd94Pmz7jD5IzEUt+ENJK6ZW+Prf7aXdGTCZ6voA9crhCSEAv0dCW78wj4bduA4hAaDDIpgENYpr9vlk6Ev+u0B7w+yNOd9rAzDXKGeZlILtZGUHYXObUVHlQA5ySn7Znd8L7vYGw/K5sqlUEXsSBE27Ir04nvdLTeg2QHCLkBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gk36A0yVIkDU5Qy+dJ4QVpOCeNDSCrdjdbO0P/w+2bM=; b=m1PG/ilZahEVLf0kVbcyGmmtw/1jt8ogPpz4711mmuzrZxoomZ0Dx82rJDbDWfie2qUiKl2a3VJmYc0LRozVJ6Oc/3yr0okI4JMjmwkXswHMg2ZMN9KBzIdkmKvfS29OM8xlhEFhUoIWP3De5xHdFUggaV2BOpftrm/lWDq6PS0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by FRZPR08MB10951.eurprd08.prod.outlook.com (2603:10a6:d10:136::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Thu, 16 Jan 2025 10:27:09 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%4]) with mapi id 15.20.8356.010; Thu, 16 Jan 2025 10:27:09 +0000 Message-ID: <7c240023-20f7-41b4-8afc-f105c9785a35@arm.com> Date: Thu, 16 Jan 2025 10:27:08 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails Content-Language: en-US To: "brandon.belew" , gdb-patches@sourceware.org References: From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0431.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::35) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|FRZPR08MB10951:EE_ X-MS-Office365-Filtering-Correlation-Id: d6348300-fbae-43d8-f510-08dd36185518 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eUs2czA3N1cyNis1VDhNb1lkQktVdHpyeXEzK1RNWHhrU1VEV3NsbFBKZ0lY?= =?utf-8?B?THFlQ3hMdkZkQkovK2RJajJMcnNHdWFRUmtrQUVjVE8ybHRYWnBtZEkwN05w?= =?utf-8?B?TlpWaDhSZTZVWHJGditRV0JXb2dDNUo0bGdSbVgvQmtJWDR6VHNhVFZXSkNV?= =?utf-8?B?dVFldHhLOGxEZkF3K053RU4yTk5KMmV4WGZpQmYrb1ZoRkp6N09JTkpGZ25M?= =?utf-8?B?RjcycWtCVUliTVRJS1BjUHBINC82bm1paGlkZnNVWW0ram9SL1ZyWTNuN1lO?= =?utf-8?B?VzkyYnZ3TUdYVStaVTdMbjM1QWJDSjVpY2sxVUdDSGtISFJYOGxOQ0s1VHBs?= =?utf-8?B?QTlScU1uTEc1TnplYlExcVd3cHR2U3dxSnBYNkc0VDFPRFFPczJOWkhBeG9q?= =?utf-8?B?R1BHa3Qyczc2Vmo2UVlqNUV1bzMyN3RjRzRUeDFGdkZHTzNzZTg1QjBzMTNM?= =?utf-8?B?czdoMFB0MmRLTXFoVm1vT3NsK2w4RmN0Q2FnMkNkOTNKQnhWSGJXb0lBTSta?= =?utf-8?B?dTNrNk1nZmhiNlNvV1BXUzVkY3E5dGVPM01CM2ZtZTFvUENpQ2U1NWs4RlRE?= =?utf-8?B?L1hNZkdDcStQcXY4RDVDUnJZaUdrUGhMRjZFOUJjdG1CL0owZnQ0ZVpzcGdL?= =?utf-8?B?RndRWXZmY1RhOStoMjVhaDBFTDBQa1VQUVlVU2FTbU9VNjh3dXE2bHRUTmw3?= =?utf-8?B?a3hCTzMweHhLcTJVa0RmSDBPeDZvL3h6d0hWU1ZYa2R3SHRYR0tONmVRUCtx?= =?utf-8?B?ZUlaK0piaEdWWjFnRUkwM1J6b3Q4dXhrYVIzN3I2RXhjWTF1QTl5T1BJUDVZ?= =?utf-8?B?UEREUkdrTk5ucURBTkxVZmhRbEdOVXZLRlNMeitPdUdRSVVWcHNrNG42dk5U?= =?utf-8?B?b1ZKYWVUOFdZQVk1ZDQ2aGY2cnlzbVJPbnIxUVJFYkdpQTRJVEgra3pmdGNC?= =?utf-8?B?MzRpdWRJQkpCYU81VEUvUkVRcVBCY3h4S2hQZmVPSG14MnhnRncreEtySFpX?= =?utf-8?B?eDZ1b2t3SUhmdkZacENMQTVxTFp1N3VyZmJ6dXNkVjE1MkxEckR5bTE4VW5j?= =?utf-8?B?dkUzeUJJSEVJTjdoZTlHNWZHdVdSeVdYMGhYbXM5anFtOUZFbkw1dHByUkM4?= =?utf-8?B?VFpVd2V0Rkh4dW5CM1dvSURNWUpUem1HVWJBWTNxbUNpUWtsTUdGWC9MWWNX?= =?utf-8?B?ZWRhdHhXU1RpNzlYMkgzZ0xRWUZ4YWdHdllQN2NUM2xOeGIwUmwwc0dCbVFm?= =?utf-8?B?SC9XdGdBcHNYc2kyT1U3SWZxa1g2YWRCSm1SalJuejl0SnZ4SU5SOFZ2MS9F?= =?utf-8?B?REUzZjJLTjdzTHNnWklUZy9id0VaVm1wVjl2TTNCaXdzNVhJcDNXNUhMckhW?= =?utf-8?B?clc3UDMwZWtVelZsbnpvdGYvdzBtQkxJOXliU0lDOUtFNy9NeFcyblMzeDIw?= =?utf-8?B?WklwSE5hTS82SFBoTUNKQzdYbUJXdFppamZPNjlnbSs4RGRjZjZscVV4bjcr?= =?utf-8?B?S2ZPSnpISGdpRDRZM3lGMU9EWW5sazVhK2FiQnRVZDBnL0lWanJkTUQyNlVz?= =?utf-8?B?UFltdmh6YlJmYUFwMDdIL2FSUGw1M0k1ZzFtWDJsbUMyaHN3N1JPVDhQYkNT?= =?utf-8?B?dCtTK1VacHhLcGZ0VlVmOWlGL1RhR0tzNHhUQWhxYzVRUEFQZ1NxVVhKL2do?= =?utf-8?B?Z0Z3MDMzRlJMK2toS3AvNjJSbXBMYklqd2JDYkJRLy9ka3ZhUmMzNEcrRWZw?= =?utf-8?B?UmFjSGNPY040c2IyRHNnNHpUUlJ4VjdkM2ljVWhSd1FrZmxOWTRkSU84Vy9u?= =?utf-8?B?VjllckErU1pDa2crWmQ0SEJOQ2U5RXlXL1hBWUVhWkxTZmxxa3ZPOVFJZHRN?= =?utf-8?B?ei9jRW5YVWwyS3dPU3puQ0wwOTlVb1lHci9kZ25RVFErOGc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXd6dkJRWENnaVN1SUxXNDVZaksrbnVJcXpSUkYrUFV4MUlHSDQxSUlaSmFN?= =?utf-8?B?K3JUZmttTGMxdEhXMGNYWC9DNm9IWENsb083UXNwVHBKaDZnRHdKUWN6SzBr?= =?utf-8?B?eXVhV1NZZHhQRlhUbExPWTZDYUZPVC9MbDdnZnhZQmZZSTRwT09uN20xU1g5?= =?utf-8?B?dXhUMThVYzZjRDFYMXM5UGFiVzFLMjBMQTNsNEtNcFdnbWxodjZUV1QxWkVy?= =?utf-8?B?RTFESjlGU1h4NlhXcmtxTXBoeXpYOExXNkRzT2hNUEdWREROeUJiYWxEamxE?= =?utf-8?B?MlRhS1ZVQloxamlGMVFaaXVrZXZjbVBBVmhMdTlTck5ick83aVI2NE9OY2Rq?= =?utf-8?B?L21HZFpkSDhLM0M2eVVkZGU1ZXczMzNHYzBXKzdXUmtsWmlzdkx5eVNuQTNE?= =?utf-8?B?VnRrOHdoK0R1YlhIUkhqREVsWEx3d2RIc1pKR2tWdml0a21CWVJ0Qlo0NFN6?= =?utf-8?B?K0RZQmU5cDBtTmFHa2tWM0g3b3U3QmhPeHh2MWR3K2ZibmZ4Z1doanNjdXRw?= =?utf-8?B?MnhCVnhwM1hNUkgxYjF1ZUpMcUw5UGdNME1FWGw3MWxaU2JEeDBnd0VIb2c2?= =?utf-8?B?bHY5anN5TERNYWVIVytFN0djK3J0Q2ZxT1Q1dHRJWFBVNHFyUmc2aHVSTWFs?= =?utf-8?B?MGl2bnAvWXo5MGdWMm55NzFDT3J6djdXZnBBdUlJWTJxU003b1pOcXVMT3pU?= =?utf-8?B?QTJBRUVrdmEwSnBDWEJ0UXJ4WGRuMVJUbmZiTms2V0h0eVMxeXpOaUc3aWxJ?= =?utf-8?B?cTJINXRML3lrQ3lHYzdYMFdENk5PdWM0cXRjS04vWFVLMFQ4a3RSenJiaFhF?= =?utf-8?B?b1RENEIzQm8rdHJBVXRBc0QzTzJrdDFPZVA1eDlJWnlWakVuSURNeEpnOXFG?= =?utf-8?B?U25oWWlFRmc4SU1zOHpBeUFEZFRuNGxmb2FmQ1oyblR1eE4rcjI5Um15UzFl?= =?utf-8?B?VFdZU3o4S2RrTzRIRVIrV0NzT0NTT3Fmd1hVSDFleXRiYmhzcE1BcWxuRnY5?= =?utf-8?B?V0RlWUJLTk96UTJHSE9OaGNnaUtOMmYxVTlZTWltb3Z6SU01KzIwOUE4ZHNq?= =?utf-8?B?SXBxUU5YS0xDVzNzS3lnVFIzNjE0WHhHc0JCZjE5dWtYM1ZqakF5Z0s4S2Z3?= =?utf-8?B?VzZxbjdUM0R0MDZyVURCK1FFU0gzVElQU01pZjdlOVRRckdPSEhYZ2lURndt?= =?utf-8?B?UllOaVlwQkNMVWdDYms0bmVzL3luV0duTjAwaDdnb05DYW1mNnk5TXpDM2Jy?= =?utf-8?B?LzM4MW8zSSswOGtZOWZ2WFdvN2ZFSW9zYjAxQ29PZ3hQaUpnZHJ0UTlJbFFl?= =?utf-8?B?QUxxQjJDK2ttYWp1T3ZMNVhlZGovRjZWaGtWZmtVdSsyRGlWU3BiOU1XQVNp?= =?utf-8?B?Rk9zcnlyVHA2N1ZTbGNmbTQ0STkreU9yVjJLaEJNaWMvN2JDekluSUJXeVp6?= =?utf-8?B?UXNYTTlWc1NEd3dCQVQ3ejJBbkV2VkxXUW82QVhROVk0bDVZOXNsSC9GZTJJ?= =?utf-8?B?UjFpdWhVQ2k2SHFDWUJvbGE5ZFdHV2FNVHJ6Y3JjTDg0VzgyN2l5YTdtYm4z?= =?utf-8?B?cXowZHpNWUZJcEFuLzkvS3hXUXVEUEtSR3pjWXM5UHBVTGhwenp3ZnRLakpC?= =?utf-8?B?QmpzSmxVeHE5OHhObk9XMmhvQm5EUFBVVnBDSHp2dXYvK3cycVZHZ0xpZFJB?= =?utf-8?B?K3Y0MGFBaUd2WmRGTUxlQmtGcS9LeWZCcUpranM2ZThsWEF6UXBicGJmY3ZY?= =?utf-8?B?aWI2dCtBbTZyeFMrZHhFN1psNy9CS05qcVE0bkhKVkF6ZEJ4cHE4YytXUjZk?= =?utf-8?B?TGZZRVlLWlZ1eGo4TVdXdy9mVW5tU1VXWWUvUXlLUWg2dHMvK3BZdTJieEt1?= =?utf-8?B?U21PNUlnSnprc2FKLzBCb0dRa3FCenpTVCtiUHlKOXB3cnlkdHRyeStWV01P?= =?utf-8?B?b1VhczF0ZnpQeXRDeUk2YUp5dmE5MGdta1NCMXVMb0pWREVOVGZFdis1OTli?= =?utf-8?B?NlNIeUhrWDZSbUFQWEJFbHRZaW1IcGsxMzR2MXN5aFVQbWg1eU1yQWc4OEEx?= =?utf-8?B?OWlnSlhiOFV5RHFMWnRwYzRFMG1CaU5PMHlhOHZYanlEV25tM2RBbW1GVWxK?= =?utf-8?Q?RoUFpqUqw0WeCu/PBWWRpuG2L?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6348300-fbae-43d8-f510-08dd36185518 X-MS-Exchange-CrossTenant-AuthSource: PR3PR08MB5852.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2025 10:27:09.2368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Exsn29ibKcJJ50o2zFhvyAPQYGKOM6yjq8BUr5vyPjhJdT3lHLs82NMYIpjFeOIysnlNSy2ekuEqIUr8AForHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB10951 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Brandon, Sorry for the late reply. Again, feel free to ping it if it takes over a week without a reply. On 12/20/24 22:17, brandon.belew wrote: > Check for target_fileio_read_alloc failure in linux_fill_prpsinfo > before dereferencing buffer. This fixes a segfault in the 'gcore' > command when attached to certain remote targets. > --- > This is my first contribution to GDB, and my first use of > git-send-email, so please let me know if this is formatted > incorrectly! I initially submitted the bug and a v1 patch at > https://sourceware.org/bugzilla/show_bug.cgi?id=32441 and received the > following from Thiago Bauermann: Formatting-wise, The commit message goes into the patch itself. See other examples on the list. Also, since you've opened a bug, we have hooks to refer to the bug. For instance, for commit ca263aec20adfffe6f9dab3a18f8a7b24667f99c. PR testsuite/32489 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32489 > >> Thank you for the patch. In general it looks good to me, just a couple of minor >> comments: >> >> 1. Since target_fileio_read_alloc () returns LONGEST, I think it's better if >> the buf_len variable also has that type. > > I decided to stick with ssize_t for the variable, as this matches the > usage elsewhere in linux-tdep.c in linux_info_proc (which already was > correctly checking the length). > >> 2. GDB is (very) slowly transitioning from C to C++. We currently prefer to use >> nullptr rather than NULL, so I suggest using this patch as an opportunity to >> change NULL to nullptr in lines 1876, 1877 and 1879. > > I made the requested NULL -> nullptr changes. > > Let me know if this is good or if I need to make any changes in my > workflow to adhere to GNU or gdb project conventions. > > gdb/linux-tdep.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index d3452059ce2..c10c4c76451 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -1867,17 +1867,17 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p) > /* The number of fields read by `sscanf'. */ > int n_fields = 0; > > - gdb_assert (p != NULL); > + gdb_assert (p != nullptr); > > /* Obtaining PID and filename. */ > pid = inferior_ptid.pid (); > xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid); > /* The full name of the program which generated the corefile. */ > - gdb_byte *buf = NULL; > - size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf); > + gdb_byte *buf = nullptr; > + ssize_t buf_len = target_fileio_read_alloc (nullptr, filename, &buf); > gdb::unique_xmalloc_ptr fname ((char *)buf); > > - if (buf_len < 1 || fname.get ()[0] == '\0') > + if (buf_len < 1 || fname.get () == nullptr || fname.get ()[0] == '\0') > { > /* No program name was read, so we won't be able to retrieve more > information about the process. */ > -- > 2.46.0 The change itself looks OK to me. I'd like another pair of eyes to look at it before we approve it. I think this can go in as a trivial change when it gets approved. Reviewed-By: Luis Machado