From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29564 invoked by alias); 13 Jul 2017 18:19:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28077 invoked by uid 89); 13 Jul 2017 18:19:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-lf0-f50.google.com Received: from mail-lf0-f50.google.com (HELO mail-lf0-f50.google.com) (209.85.215.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jul 2017 18:19:15 +0000 Received: by mail-lf0-f50.google.com with SMTP id h22so41366023lfk.3 for ; Thu, 13 Jul 2017 11:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YpRZ6lEhq4k4cFMmeS8yywhUs57yfoYYzfXqM6rG2Cs=; b=BgibyxS7ZQD+kZCYXJqntyIBiVjiI31OPkXAJPI1sPCeXPl4GgkWCHhnHez6c2Ebd5 hVglIZVXv4yHL3JeFM6uUVfysQhFciWXM+tSdTYWT+AMvbiP19DH80eXOIhQQ7BIQVGI 9B5DNxltZquGOPMlqAwGKCvlPQKGsyJ9xIfyeotRgoLERuGSA9X9Pf8gW2XDqAX81AJr X8ych8ZtFOrwwuFJg+lb0LDLVGQjELLeE9ps+1P22KqJvKz4FI4pIGr4mP+67zVZMX2w EFEExsBSQDbVlZw6IqwGyQ8IWV/P6bIAm2oyijphtV/zbwbNAIA30BzVvCiBUt5HHMEK YI9w== X-Gm-Message-State: AIVw112q6Fcs0bOVkwHTrTmgFQbnrs2xW233IJ3s6kDLZN92eVWVVUH+ miCcOBwQYs7+B9mwPPg= X-Received: by 10.46.75.2 with SMTP id y2mr1686017lja.78.1499969952755; Thu, 13 Jul 2017 11:19:12 -0700 (PDT) Received: from [192.168.0.204] ([91.215.122.25]) by smtp.gmail.com with ESMTPSA id 8sm1313815ljj.30.2017.07.13.11.19.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 11:19:11 -0700 (PDT) Subject: Re: [PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <83vamwgwf5.fsf@gnu.org> From: Ruslan Kabatsayev Message-ID: <7bf49b91-2af6-c99b-174d-050348e28227@gmail.com> Date: Thu, 13 Jul 2017 18:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <83vamwgwf5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00161.txt.bz2 On 13/07/17 18:59, Eli Zaretskii wrote: >> From: Ruslan Kabatsayev >> Cc: Ruslan Kabatsayev >> Date: Thu, 13 Jul 2017 09:07:50 +0300 >> >> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode: >> you have to use multi-key commands like "ni" and "si" to do single-stepping. >> This patch adds, in addition to "next" and "step" commands, corresponding >> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the >> shortcuts of "N" and "S" respectively. >> >> gdb/ChangeLog: >> >> * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list >> * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode > > This is fine with me, but please state in the ChangeLog the > functions/globals where you make the changes, and for gdb.texinfo > please state the name of the node (in parentheses). I think the > existing ChangeLog entries show how we do that. gdb/ChangeLog: * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the tui_commands list * doc/gdb.texinfo (TUI Single Key Mode): Document the new shortcuts in Single-Key mode > > Thanks. >