From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96842 invoked by alias); 29 Sep 2016 20:34:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96814 invoked by uid 89); 29 Sep 2016 20:34:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:vnet, H*m:vnet, H*MI:3968, H*MI:4317 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Sep 2016 20:34:47 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8TKWsMj070134 for ; Thu, 29 Sep 2016 16:34:45 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 25s8ssbavv-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 29 Sep 2016 16:34:45 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 29 Sep 2016 14:34:45 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 29 Sep 2016 14:34:42 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 3F0D419D801C; Thu, 29 Sep 2016 14:34:10 -0600 (MDT) Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8TKYgfF13959494; Thu, 29 Sep 2016 13:34:42 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1588B6E035; Thu, 29 Sep 2016 14:34:42 -0600 (MDT) Received: from otta.local (unknown [9.85.173.241]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 947D66E040; Thu, 29 Sep 2016 14:34:41 -0600 (MDT) Subject: Re: Disallow 3-operand cmp[l][i] for ppc64 To: Alan Modra References: <20160929060240.GD4877@bubble.grove.modra.org> Cc: binutils@sourceware.org, gdb-patches@sourceware.org From: Peter Bergner Date: Thu, 29 Sep 2016 21:21:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160929060240.GD4877@bubble.grove.modra.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092920-0012-0000-0000-000010C6BCC5 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005826; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000186; SDB=6.00762819; UDB=6.00363636; IPR=6.00537941; BA=6.00004771; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012825; XFM=3.00000011; UTC=2016-09-29 20:34:44 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092920-0013-0000-0000-000045E7F9CC Message-Id: <7b7f12a0-4317-3968-25d5-0704cfc40632@vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-29_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609280000 definitions=main-1609290356 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00418.txt.bz2 On 9/29/16 1:02 AM, Alan Modra wrote: > cmp[l][o] get an optional L field only when generating 32-bit code. > dcbf, tlbie and tlbiel keep their optional L field, ditto for R field > of tbegin. cmprb, tsr., wlcr[all] and mtsle all change to a > compulsory L field. FYI, I just committed the following as obvious to clean up the gdb testsuite fallout from this change. Peter * gdb.arch/powerpc-power.exp : Update tests to account for the compulsory L operand changes. * gdb.arch/powerpc-power.s: Likewise. diff --git a/gdb/testsuite/gdb.arch/powerpc-power.exp b/gdb/testsuite/gdb.arch/powerpc-power.exp index 3bdfc15..8594ad5 100644 --- a/gdb/testsuite/gdb.arch/powerpc-power.exp +++ b/gdb/testsuite/gdb.arch/powerpc-power.exp @@ -1117,8 +1117,8 @@ func_check +4168 "xvxsigdp vs59,vs60" func_check +4172 "xvxsigsp vs60,vs61" func_check +4176 "cmpeqb cr0,r6,r7" func_check +4180 "cmpeqb cr7,r6,r7" -func_check +4184 "cmprb cr0,r8,r9" -func_check +4188 "cmprb cr7,r8,r9" +func_check +4184 "cmprb cr0,0,r8,r9" +func_check +4188 "cmprb cr7,0,r8,r9" func_check +4192 "cmprb cr0,1,r8,r9" func_check +4196 "cmprb cr7,1,r8,r9" func_check +4200 "setb r15,cr0" diff --git a/gdb/testsuite/gdb.arch/powerpc-power.s b/gdb/testsuite/gdb.arch/powerpc-power.s index 507b61e..6fe2520 100644 --- a/gdb/testsuite/gdb.arch/powerpc-power.s +++ b/gdb/testsuite/gdb.arch/powerpc-power.s @@ -1078,8 +1078,8 @@ func: .long 0xf389ef6f /* <+4172>: xvxsigsp vs60,vs61 */ .long 0x7c0639c0 /* <+4176>: cmpeqb cr0,r6,r7 */ .long 0x7f8639c0 /* <+4180>: cmpeqb cr7,r6,r7 */ - .long 0x7c084980 /* <+4184>: cmprb cr0,r8,r9 */ - .long 0x7f884980 /* <+4188>: cmprb cr7,r8,r9 */ + .long 0x7c084980 /* <+4184>: cmprb cr0,0,r8,r9 */ + .long 0x7f884980 /* <+4188>: cmprb cr7,0,r8,r9 */ .long 0x7c284980 /* <+4192>: cmprb cr0,1,r8,r9 */ .long 0x7fa84980 /* <+4196>: cmprb cr7,1,r8,r9 */ .long 0x7de00100 /* <+4200>: setb r15,cr0 */