From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8cjqLhLNy2mJxAAAWB0awg (envelope-from ) for ; Tue, 31 Mar 2026 09:33:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X5JJzMgw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1qmq5Tjk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n3nRzvHM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=H45/g4Op; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ABB4A1E04F; Tue, 31 Mar 2026 09:33:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3E521E04F for ; Tue, 31 Mar 2026 09:33:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 633AA4BA902D for ; Tue, 31 Mar 2026 13:33:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 633AA4BA902D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X5JJzMgw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1qmq5Tjk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n3nRzvHM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=H45/g4Op Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id CC2E24BA2E17 for ; Tue, 31 Mar 2026 13:32:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC2E24BA2E17 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC2E24BA2E17 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774963957; cv=none; b=jrSbHOIcaPdPvGL70sAFwNONA/Qox53wqy6CePcPdNSXDBkLWQTNZu3n9JWmROKfpkFUIMh6OL07oJkWYa0BSr4vShMbIaK/9rUMNBAe59YHf7aDXKhVonQcKOZDddHIiZgJUmvnMlMnss6EhUTWhz4tdRqCyfrvA75rvUFcKo0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774963957; c=relaxed/simple; bh=yF46JPR+eEr/EWefPL3qStF2lYKEPlq7+LDozJomrlQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=x6om55wk/0wqAdHupTsNNezD41uUQTRTDtzpp3hTVjvEsl63Awfn5LT/NMSVIpr4JvvCDY3vK2Wzay/IGZ9u9i0s5gKYRFrdGv0CxZOkwisawEjwBiEsreS3bpLD7XJO2gRmyTEC/MRXOOw/AW+2M0dFIMUVQOwcr5kTMFVWeu4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC2E24BA2E17 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E3A654D227; Tue, 31 Mar 2026 13:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774963956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aAQEe/8FYZaybReU/McetD0IyufAkI3lsoOMt8ChHY=; b=X5JJzMgwgjo24lTYFvxFrB9ohc6VaeE20NPabbuYgFFe1N6r/bq255y++IvNPM19rvHSks wqZh2URUpJo3k/ivW0dlk2N4ijgPa5mBTJf5/oVrzroiXEHZ6YDtoQy6njwwVQ5+wXqiqo /JyfNnOGDy8Sa0xQRqqMJ7rKP5ww5+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774963956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aAQEe/8FYZaybReU/McetD0IyufAkI3lsoOMt8ChHY=; b=1qmq5TjkctpV83kEbK9gBAAp/gy79EsddpELMwsDNmH5r1g+sYne+HPWoNgoYtymSV1GFS hpx7274MKMB6aFAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774963955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aAQEe/8FYZaybReU/McetD0IyufAkI3lsoOMt8ChHY=; b=n3nRzvHMGdblw4xKyao3vLHQQa19PS0R/vclr0DkTgC+AamxIKZAtqyZAVEWr29meeXTNZ c/oOD2bH3Vk8E9X6rfYyPvC8KqnP4QToisN+h9Z2nZG00gVGZaLotJPK/KXK9zT+PKpccD 3vWZVJBdPuahamRUoWG+WXZisWV2utY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774963955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aAQEe/8FYZaybReU/McetD0IyufAkI3lsoOMt8ChHY=; b=H45/g4OpzvUduHZvrFkD8W1PFQ3v3wetfY2fGmQsNdEmmq2CXf8g+xJakH5H+kEEY7tw4f tSc/hFLEeQskBkDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C8F294A0A2; Tue, 31 Mar 2026 13:32:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jBCbL/PMy2lDXQAAD6G6ig (envelope-from ); Tue, 31 Mar 2026 13:32:35 +0000 Message-ID: <7b582e85-996f-4052-b6fe-80a85e099eff@suse.de> Date: Tue, 31 Mar 2026 15:32:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Fix missing print frame when stepping out of function To: Andrew Burgess , gdb-patches@sourceware.org References: <20260312120211.3806600-1-tdevries@suse.de> <871phh6wir.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <871phh6wir.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/18/26 3:29 PM, Andrew Burgess wrote: >> void >> set_step_info (thread_info *tp, const frame_info_ptr &frame, >> - struct symtab_and_line sal) >> + struct symtab_and_line sal, bool refresh_p) >> { >> /* This can be removed once this function no longer implicitly relies on the >> inferior_ptid value. */ >> gdb_assert (inferior_ptid == tp->ptid); >> >> + if (refresh_p >> + && tp->control.step_frame_id != null_frame_id > Unfortunately, this doesn't work. Comparing frame_ids ends up in > frame_id::operator== in frame.c, which always returns false if either > frame-id is null_frame_id. As a result, the != above always returns > true. > I see, thanks for pointing that out. > I think this is why you ended up having to add the refresh_p argument > maybe? To follow up on this (even though we're exploring a different direction atm), AFAIR I didn't need either of the two things you mention here (frame comparison and refresh_p) to make the patch work, but I added them with the intention of making the change more robust. Thanks, - Tom