From: Simon Marchi <simark@simark.ca>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Make target_read_alloc & al return vectors
Date: Sat, 07 Jul 2018 17:58:00 -0000 [thread overview]
Message-ID: <7b3379693d002e788af87bb89a1078e3@simark.ca> (raw)
In-Reply-To: <87efgfyn76.fsf@igel.home>
On 2018-07-07 13:23, Andreas Schwab wrote:
> This is the next error:
>
> ../../gdb/ia64-linux-nat.c:73:8: error: conflicting return type
> specified for ‘virtual bool
> ia64_linux_nat_target::have_steppable_watchpoint()’
> bool have_steppable_watchpoint () { return 1; }
> ^
> In file included from ../../gdb/inferior.h:41:0,
> from ../../gdb/ia64-linux-nat.c:22:
> ../../gdb/target.h:554:17: error: overriding ‘virtual int
> target_ops::have_steppable_watchpoint()’
> virtual int have_steppable_watchpoint ()
> ^
The fix for this is probably obvious (change int for bool). Can you
take care of it? I'm not on my gdb-development-capable computer, and
probably don't have an ia64 cross-compiler handy. Does the patch for
target_read_alloc look good to you?
Simon
next prev parent reply other threads:[~2018-07-07 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 4:03 Simon Marchi
2018-04-07 17:21 ` Simon Marchi
2018-04-16 20:04 ` Pedro Alves
2018-04-16 20:51 ` [pushed] linux_spu_make_corefile_notes: return note_data instead of nullptr (was: [PATCH] Make target_read_alloc & al return vectors) Simon Marchi
2018-07-07 8:54 ` [PATCH] Make target_read_alloc & al return vectors Andreas Schwab
2018-07-07 15:10 ` Simon Marchi
2018-07-07 15:17 ` Simon Marchi
2018-07-07 19:32 ` Andreas Schwab
2018-07-07 17:23 ` Andreas Schwab
2018-07-07 17:58 ` Simon Marchi [this message]
2018-07-07 18:24 ` Andreas Schwab
2018-07-16 18:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3379693d002e788af87bb89a1078e3@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=schwab@linux-m68k.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox