From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54723 invoked by alias); 14 Dec 2016 17:39:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54707 invoked by uid 89); 14 Dec 2016 17:39:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:gdb, UD:main.c, UD:selttest.exp, gdb.gdb X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Dec 2016 17:39:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60A8D61988; Wed, 14 Dec 2016 17:39:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBEHdIIb031695; Wed, 14 Dec 2016 12:39:18 -0500 Subject: Re: [PATCH] Clean up gdb.gdb/selftest.exp To: Yao Qi , gdb-patches@sourceware.org References: <1481725157-14018-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <7affe31e-b41c-0aa8-2ae1-fd19f3eed16a@redhat.com> Date: Wed, 14 Dec 2016 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1481725157-14018-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00300.txt.bz2 On 12/14/2016 02:19 PM, Yao Qi wrote: > I recently see the test fails like this, > > (gdb) PASS: gdb.gdb/selftest.exp: step over argv initialization > list^M > 487 std::vector cmdarg_vec;^M > (gdb) FAIL: gdb.gdb/selftest.exp: unknown source line (after step over argv initialization) > > step^M > std::vector >::vector (this=0x7fffffffdc10) at ../../binutils-gdb/gdb/main.c:487^M > 487 std::vector cmdarg_vec;^M > (gdb) FAIL: gdb.gdb/selftest.exp: step into xmalloc call > > These fails are caused by using std::vector in commit > f60ee22ea1d62f7004511ec65a3ad76890032d88. selttest.exp should match > the source code of GDB. This patch adds some new regexp to match > code using std::vector, and also removes some out of date regexp. > > proc "do_steps_and_nexts left us ready to execute an xmalloc call", > however, there is no xmalloc called, so I also remove these bits. > > I am also wondering the value of do_steps_and_nexts, can we just > remove it completely? Yeah, I don't see much value either. It's a constant source of update pain. I've found the bits of selftest.exp that interact with SIGINT useful in the past, as that interacts with readline's SIGINT handler. IIUC, that caught a bug in some local version of my console work earlier in the year. So I'd prefer to keep those bits. But I wouldn't miss do_steps_and_nexts for sure. Thanks, Pedro Alves