From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mdRPNPl1qmr2GhIAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 06:56:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D07251E06B; Wed, 16 Sep 2026 06:56:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F2F01E01F for ; Wed, 16 Sep 2026 06:56:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A4E04BA7997 for ; Wed, 16 Sep 2026 10:56:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A4E04BA7997 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011011.outbound.protection.outlook.com [52.101.70.11]) by sourceware.org (Postfix) with ESMTPS id 362404BA2E0A for ; Wed, 16 Sep 2026 10:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 362404BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 362404BA2E0A Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.70.11 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1789556187; cv=pass; b=b5DpLz6wlcVyqNkqTIqEtXkI+Yg7Z11Uq4AQgZ0N3YRnyMReKd86fULrx/yg2O8mXhTkpOGUWMT2OjGpHaeHI7AgQ6WuKpG6vs88QUepjlO8RtcthTccFkm3zDdO5gbcNHNvFGZiWeH72ubtUQ/5vTkv+IvE+Z6rVGUde5D/RLQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1789556187; c=relaxed/simple; bh=3w9SCYZQFOWyfi3IIK8cr/nDvzkMN6leqLqYqY+a9OA=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=gbPZ5l6c/vui46qVTUp8aIa8rH0NsXH4HNkrM7Zq/bVTReaLma61IgsEkhZ2zCzIY7IHvNNAfL+/BijrIHF3PGnxQEUjz51oIC/8Hck2zb6hHd9QjgB7UNNGlP4Nwqw9f8a0e2xrmteShrt/cBUNlKKvGpM4v16+dboT/b/f/Co= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Mg+koRga DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 362404BA2E0A ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=TnYbceqKuyGp6vlgG5lCjoJkfEugYJLwjs2NnVanrMlGnrzKKq4ofh3E3aHP1BdKDKIdJcMYt0DpNzGvLAdxBQLkagTd6/tECTAFTVmDhWIDm42W5qzwcFZyiBvR6W+NROSjV8nzH/8K5JDj+YIfvzgUq5e6eOcO7Enzj0xMwj+WO3f2TGRL90YDG1KffYLF9+kGjDis4vbautnPVMwSh9EecAlEHqCyVEl9/UxCWV6fsdtdUKnu5WQ6zSbYxExmJjTjvasNFM+RMIW8gHFGbwukWOYJlleMv2eKJCnZpYwSkXETd/+v+untj1/8fA8kAuO42OkAdv8cW1wI1VfpSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PE6m5I6ffVJSI8qW9CYJ+f42XoXKh/dPIRctGdTMIa4=; b=gqvnkAmQqUBcpFArswQspyqkJ8GmsdR9ppL8RFiXM2odkR4NZqZfHeLNGJ6QK9W4l6w7T+spyFizZ3qeRZev7UMC9tTjXI8dsQ1/ft5uVq/FjBPjNXGt1/cERyLUAzlZQ9VCZYuX+LOXA4eD22kOKEd3IDEuI2h375rXhyA9cZgmfLJbSa55pUajEATHdzf0VudErIdHRP3ayCSXomvqzJAk09sZ2zIS5rBnzdM3h8rQiWwZkhzHeJfGqkdiznqHve9HM7Mc0GeT6v8jQ6d/npy38kFl/SnsiZTUsOBKo7kUTWtG/0QnjR1TrKBWDqZXMJqNDizpX75M14i2w8opow== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=redhat.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PE6m5I6ffVJSI8qW9CYJ+f42XoXKh/dPIRctGdTMIa4=; b=Mg+koRgaWHoQ5GoIc/tz5yoz57A3NihANX+GWOeIVqdpp/L+y9G/HTiR7OxFd+gB1cCM16iL52MMu9OM4B1l+AVpWhY6JyWOv8EpXxUBTbXbOpZVCEjyOVZSH8clFKiamXH1B0OojLxcvSQrNDM2tw2x0WJFuZf9TA7QBbVP29k= Received: from PR1P264CA0113.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cd::14) by GVXPR08MB11184.eurprd08.prod.outlook.com (2603:10a6:150:1fe::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.11; Wed, 16 Sep 2026 10:56:19 +0000 Received: from MI3PEPF00008486.eurprd02.prod.outlook.com (2603:10a6:102:2cd:cafe::29) by PR1P264CA0113.outlook.office365.com (2603:10a6:102:2cd::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 10:56:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by MI3PEPF00008486.mail.protection.outlook.com (10.167.240.133) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 10:56:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xeiffH7le9gcxjaTf7ggS5mzZwtzs2YHmvmuf79XRNlmlQDc+44Fp3c3HtLDqTP7TehJCBJcsTaukOCI1oaFm4nl2apTg8s87GUMhAojuLhrvnahf7HNkMIdKvthH5+uFhwNMZ4CSCF7u4WF9e0+9rxI+bpYuuRh9EkQNdACKNQlTmLKjzcxVtlOC9BaKPhx/eoETlWL26IUd8v02mIMS1eBfmKx/i/sjXavmKvdWC4zmKghYUhuW0RUR6ZtfiLwnCOo+TeyiQTql2s2WAGxGoA6ufwaDlcy7hajpazlAFFb+j0NnrtnxP71sNRQ1LJbgImOL9u9tLN7PFP30LmDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PE6m5I6ffVJSI8qW9CYJ+f42XoXKh/dPIRctGdTMIa4=; b=R4OeZMvJPuBFyom8g2xSEfLY27/eP0XLCVirCiFAZ5fdzxUVHEwDPQ0oqjwUbCgKxLWNUzCnwovGfQ8eDk+F2vjYLORZozmXOj555UDfRj6Cx4CBeNHY437vsvg4MYcV1zhhRUGMUjjV1/T+rGqwgiOXxve1C3ZOZdgO8Ic6mN8m5mIm4x2DaXZUAgh5ea6wTHhPXlVXpNAAKM4LX/9I5EaSVeSdgXWr2G05v+1ppJkl7SHLNyrB6tQrgIA6gVg0RnCVx96fkZ7kQ9QpyfCYiSv9rJ4MUW4Haa+E9w+1KRo5ZOUOxrd4eYplq3WNamz9+lXlSi+VDfyu5EOgodRBbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PE6m5I6ffVJSI8qW9CYJ+f42XoXKh/dPIRctGdTMIa4=; b=Mg+koRgaWHoQ5GoIc/tz5yoz57A3NihANX+GWOeIVqdpp/L+y9G/HTiR7OxFd+gB1cCM16iL52MMu9OM4B1l+AVpWhY6JyWOv8EpXxUBTbXbOpZVCEjyOVZSH8clFKiamXH1B0OojLxcvSQrNDM2tw2x0WJFuZf9TA7QBbVP29k= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by GV1PR08MB8426.eurprd08.prod.outlook.com (2603:10a6:150:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Wed, 16 Sep 2026 10:55:41 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0428.008; Wed, 16 Sep 2026 10:55:41 +0000 Message-ID: <7af00644-5059-44af-a414-9aa673f2c27e@arm.com> Date: Wed, 16 Sep 2026 11:55:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] gdb/linux-tdep: remove legacy parse_smaps_data overload To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi , Thiago Jung Bauermann , Luis Machado , Luis Machado , Christina Joos , Kevin Buettner References: <20260825100912.514232-1-matthieu.longo@arm.com> <20260825100912.514232-7-matthieu.longo@arm.com> <8733vgdvsx.fsf@redhat.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <8733vgdvsx.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0386.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::13) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|GV1PR08MB8426:EE_|MI3PEPF00008486:EE_|GVXPR08MB11184:EE_ X-MS-Office365-Filtering-Correlation-Id: 30936c04-8934-4fca-ff59-08df13e122a7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|23010399003|1800799024|376014|366016|22082099003|10067099003|18002099003|56012099006|4143699003|11063799006; X-Microsoft-Antispam-Message-Info-Original: ThMYAQJB2lY4To49L6F4I18VvIifZEYzCIJ+sjq67IoozQjUgAWlAHaPtHvE4oz5/G62G3wZI2aQLxBBJG9Vi23oG6DvqNqUr/25oG1eAVpxqUC4jxOHyuBKhtMIIn1ys3t55OjYHDUa77gBCNHm6EOCSHTr7v7riaQwB55G5cLf3NaYRYbs7h3ekdATkSsrG1l11PAj5qUbLRd4nNgMApYOvHjdVmJqB1hNte4Exi28xFN8mocXcxi7rHS4eifAzs1yWlVjUViVc/epAc+jGXLwKBo1caJs8Qs9pnoqTakQaOIhLmTaTJo7S0Lhxp55rHdtd717P+ntxgxgzhy7Gc5u9cuSkuT3FVChhTzrbvsRkvyEFNBLkssRzIEV4zKHV4n6isa884BwC15ZwTFTWx+Mul5jy14gvAGJC+GA+OlACRFcZs8HfhOZMMHG7P4u/UK993pvQUUwli3eJVJJ2Yd1IHk/lJFwOan3cONRX0YqbT1ljPeBc3hd2T/eQasju+z+e1GnLRH2LCHUaN/HWd3EfsJITvNgBs1IQ/GKi6hggbP0dNu1q6ix7eAFBf0293pyqQfnUCHcRQNi1FdGH5gNrCx8SXh7Z8P/dismD031g2Ugy0yqfPx8IXB3f9vfSyAag1RftD9rcU3yCTOKMbHOTEIRT6nc6USTgh+joKo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(376014)(366016)(22082099003)(10067099003)(18002099003)(56012099006)(4143699003)(11063799006); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: Coo1sc5ErvPpAN2lRzo39xN0vKgne+EiRvJ3rlKhB5g1S3GNQybgRw28nqN/+h3nNLfsIB9tIPodQ3skPxdvHqVwVchYah43XXiKnCeWqRQsLcmGIUpyDbcPpdkSJnIhqplXK0dc6ZrfXYwVTdoWG0Ry+tH3KFRmtkpSLE8u88fYvZkxtqRXi7/+MGXtA64LR0vk1TaISRToHITq/HjPOMPj3/83DHYdStBM7wY0q3FgTsSPz52VZIyEcV73Cyb+l78EbAACYcD4IJDOkKk8VMz8ksdh3rsiqmZr58JVvrd4Y+MLO1GHp6YwQLhRE2KJmuJ/2yjSwBemWlR3IkJOwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8426 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: MI3PEPF00008486.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a1aaa334-d360-4df8-dbfa-08df13e10c82 X-Microsoft-Antispam: BCL:0; ARA:13230040|35042699022|376014|82310400026|36860700016|14060799003|23010399003|1800799024|10067099003|4143699003|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: dHGuF0l1xQy8erNvfQpp0pp1f6VLHwT1At4LB84gS1EgXAemTZ23HpcgdwkW4Pml0sRkEVE1WNQ2I7ixzejPNYMw6QPefkd/j1xyD0rG1pZ9NhAxUvPidxzSIzxMhdAFWFbcenszo8upI5HbmvIAzK2dnNjwyxDjBofzjmIzWMdEa0VKXtzkWWB5+HNX/LOw1jI26S0LmlptOp2kZLSGcoTR/5jibVYCaQ7AYIX0LbMhCuACwW2szHRptdPSCzICx58XwsnT6krleG6Un2oi1At2LawVf+ad/qqID2kMj5LlFYTLNEZwyer117Jc1KOkAIXcMQIltj420av8+NDfrotVAMUzJUR959JM54mi5NRb+BhT/Yt9pQSs1iWSEHUmvzqclMZvtkSEUOZr/Xhwve+sebHpZS3bU7QYHEDtRdjNepPSLqHoyelurQmVTRWt86oW9XA6va6ECoUnXRFx241fEaB2PVs1lsGjQZTyNhAMVBmh+WC3e+wifWwE1SMyjSlmEDLv2W8NPKH4tgCBPoN0LMLWPlJr6bvFLCGEPiDFJfO8vH/TmNLQCFETkFNqPFz33N+eWUgvksyr/iC9Dzp86J0caboBK5yV4r70+IVGQUjhsU48d5tGTjUX/s+Bw/B40mkGmONt534tN/KKk95rG612W4Sxk2uolZ8OGi3ky144kkXlaGdbi+udso/Id+3Qp+Ca/U8L4XeNnOMuHQ== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(35042699022)(376014)(82310400026)(36860700016)(14060799003)(23010399003)(1800799024)(10067099003)(4143699003)(22082099003)(18002099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LrlrSAek0LbRcY+6wxPAfLrjEy/M/TwPu1b6htc5hzLAaPQ68dv/Qolw5LjS95PsiK/P1sQZAsAZGYhoQDIQNa2/e/0xq4rCB1xwG7Jn6Ve1tca/IhOqY1y/feTSKLKwpCZgqrREqX5kJwPuqT7WQaulcZfN6tla9mwR+mPKxnb10NFrH9XaLxFPgUqsZLrtj5wmL4hglhKYb6EkM/fRP7DQAE4THpr58nMh3qMdqI7lok7F28e6Ex0AAaGlOkx+VBgihyQWEPqr4Jjl6/R5fiQF+DUzuRjXJKCewt4QspPWZIvfWUKVO8k5Jq+Y2n7+BuU1WiNcsfRi+ga1zXH8REAJ4WcEkqXbj/B1fZLdcr5Dc9K1ZQlmsZB0MhsUT521LSRgaWbEJ+634F+AVIjFeF7fLIvqx05SXYi8f5o7dA6M/TeeHIPMFljLCvnT23oH X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 10:56:17.7834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30936c04-8934-4fca-ff59-08df13e122a7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008486.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11184 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/09/2026 09:41, Andrew Burgess wrote: > Matthieu Longo writes: > >> Now that all callers use the file_reader_t overload of parse_smaps_data, >> the legacy interface taking a raw buffer and filename separately is no >> longer needed. >> >> Fold its implementation into the file_reader_t version and remove the >> obsolete wrapper. This also simplifies the implementation by using the >> file_reader_t accessors directly. >> >> Reviewed-By: Thiago Jung Bauermann >> Reviewed-By: Luis Machado >> --- >> gdb/linux-tdep.c | 30 ++++++++++++------------------ >> 1 file changed, 12 insertions(+), 18 deletions(-) >> >> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c >> index 2833d8a4bb6..4cdb02b9c09 100644 >> --- a/gdb/linux-tdep.c >> +++ b/gdb/linux-tdep.c >> @@ -1581,18 +1581,17 @@ parse_smaps_key_value (const char *keyword, const char *line, >> /* Helper function to parse the contents of /proc//smaps into a data >> structure, for easy access. >> >> - DATA is the contents of the smaps file. The parsed contents are stored >> - into the SMAPS vector. */ >> + FREADER is a wrapper around the contents of the smaps file. >> + The parsed contents are stored into the SMAPS vector. */ > > As you are editing this comment anyway, could you fix it too please. > The parsed contents are not "stored into the SMAPS vector", but are > returned as a vector. > Fixed in the next revision. >> >> static std::vector >> -parse_smaps_data (const char *data, >> - const std::string &maps_filename) >> +parse_smaps_data (const file_reader_t &freader) >> { >> char *line, *t; >> >> - gdb_assert (data != nullptr); >> + gdb_assert (freader); >> >> - line = strtok_r ((char *) data, "\n", &t); >> + line = strtok_r (freader.data (), "\n", &t); >> >> std::vector smaps; >> >> @@ -1648,8 +1647,8 @@ parse_smaps_data (const char *data, >> >> if (sscanf (line, "%64s", keyword) != 1) >> { >> - warning (_("Error parsing {s,}maps file '%s'"), >> - maps_filename.c_str ()); >> + warning (_("Error parsing keyword in {s,}maps file '%s'"), >> + freader.c_filepath ()); > > Also, while you're passing, warning message should start with a lower > case letter (as they are printed "warning: ..."), could you fix this > please. And could you add filename styling too: > > warning (_("error parsing keyword in {s,}maps file '%ps'"), > styled_string (file_name_style.style (), > freader.c_filepath ())); > > There's another place that would benefit from this cleanup below. > > Thanks, > Andrew > Fixed here... >> break; >> } >> >> @@ -1663,12 +1662,12 @@ parse_smaps_data (const char *data, >> decode_vmflags (line, &v); >> >> if (parse_smaps_key_value (keyword, line, "Rss:", >> - maps_filename, >> + freader.filepath (), >> &rss)) >> continue; >> >> if (parse_smaps_key_value (keyword, line, "Swap:", >> - maps_filename, >> + freader.filepath (), >> &swap)) >> continue; >> >> @@ -1679,8 +1678,9 @@ parse_smaps_data (const char *data, >> >> if (sscanf (line, "%*s%lu", &number) != 1) >> { >> - warning (_("Error parsing {s,}maps file '%s' number"), >> - maps_filename.c_str ()); >> + warning (_("Error parsing numeric value associated with " >> + "key '%s' in {s,}maps file '%s'"), >> + keyword, freader.c_filepath ()); and here in the next revision. >> break; >> } >> if (number > 0) >> @@ -1730,12 +1730,6 @@ parse_smaps_data (const char *data, >> return smaps; >> } >> >> -static std::vector >> -parse_smaps_data (const file_reader_t &freader) >> -{ >> - return parse_smaps_data (freader.data (), freader.filepath ()); >> -} >> - >> /* Helper that checks if an address is in a memory tag page for a live >> process. */ >> >> -- >> 2.55.0 > Matthieu