From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qCHVAcbhdmTEehkAWB0awg (envelope-from ) for ; Wed, 31 May 2023 01:57:26 -0400 Received: by simark.ca (Postfix, from userid 112) id 0576B1E11E; Wed, 31 May 2023 01:57:26 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=SpyPNSJQ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5788E1E111 for ; Wed, 31 May 2023 01:57:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB23B3858436 for ; Wed, 31 May 2023 05:57:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB23B3858436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685512643; bh=fhDJ3ttR3oOhgHYDH9N6ki0E3kBQcNEElTqs8ZJFMgc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=SpyPNSJQdWxn0gT4I91245l7aMUSrXIznaLieIesFxHLhk3ZSM5Ew4ar8DcyVPo0o wOpGkyJ8psWVJQEmD/4epaEW10JE8Jmx40zFBId3Dvl9N4CS3gDHIcXY8UP+ma7Rra K/VOqQTjOfc7nFGPDx0V2f9J8E97PNq0lmTvkWOM= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 5E3D23858D20 for ; Wed, 31 May 2023 05:57:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E3D23858D20 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1A75C218E6; Wed, 31 May 2023 05:57:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0397913488; Wed, 31 May 2023 05:57:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W3ZUO67hdmSeEQAAMHmgww (envelope-from ); Wed, 31 May 2023 05:57:02 +0000 Message-ID: <7aeccce1-54b2-94cb-c2cc-5ced3767acf7@suse.de> Date: Wed, 31 May 2023 07:57:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230530093344.12517-1-tdevries@suse.de> <92070c95-9c75-a89b-70ae-695c3a1de219@suse.de> <65e6cebc-11f2-f531-00c1-8112f6d02704@polymtl.ca> In-Reply-To: <65e6cebc-11f2-f531-00c1-8112f6d02704@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/30/23 17:43, Simon Marchi wrote: > On 5/30/23 11:41, Tom de Vries wrote: >> On 5/30/23 15:36, Simon Marchi wrote: >>> On 5/30/23 05:33, Tom de Vries wrote: >>>> Simon reported that the new test-case gdb.tui/pr30056.exp fails with system >>>> readline. >>>> >>>> This is because the test-case requires a fix in readline that's present in our >>>> in-repo copy of readline, but most likely not in any system readline yet. >>>> >>>> Fix this by: >>>> - mentioning --with-system-readline or --without-system-readline in the >>>> configuration string. >>>> - adding a new proc with_system_readline that makes this information available >>>> in the testsuite. >>>> - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for >>>> --with-system-readline. >>>> >>>> Tested on x86_64-linux. >>>> >>>> Reported-By: Simon Marchi >>> >>> I confirm this makes the test skipped on my machine. >>> >>> Once the fix is merged and in a readline release, could we make the skip >>> conditional on the readline version? We could have a maintenance >>> command or something like that that outputs RL_READLINE_VERSION, and >>> skip only for old readline versions. >> >> We could do that, that sounds useful. >> >> I also considered printing the readline version string after --with/without-system-readline, but it looked a bit too different to all the other lines. >> >> Do you want have this implemented before, or are ok with the fix as is? > > I'm fine with the fix as is: > > Approved-By: Simon Marchi > > We just need to remember to do this when the next readline comes out :) Indeed, filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=30500 ) about it. Thanks, - Tom