From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hmMSBzFEOWQ6kysAWB0awg (envelope-from ) for ; Fri, 14 Apr 2023 08:16:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 105C31E221; Fri, 14 Apr 2023 08:16:49 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CCLDKsNX; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7E781E110 for ; Fri, 14 Apr 2023 08:16:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2B6D3858C54 for ; Fri, 14 Apr 2023 12:16:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2B6D3858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681474607; bh=7MwDlub4NJ27unAT/v0H5obJdCXUdEHfNL0Rd9p8Aqk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CCLDKsNX+0uRaR6vMYIcNuGiZ1rPJ+Y0TNBYXjaWRCOmzOqyH4Ymp9edPPKuymv3O RLJVTwxRAypY0kQUep72rKwJxrf3AJkRIJj7rsYat5BbmSI1dV7vC7KIIT/uZMDZW+ 6WVNNBaeyFbWSUH9OkqFLVdNVTuV1eE2Gs3VLTSc= Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2044.outbound.protection.outlook.com [40.107.8.44]) by sourceware.org (Postfix) with ESMTPS id AC6563858D20 for ; Fri, 14 Apr 2023 12:16:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC6563858D20 Received: from DB6PR07CA0104.eurprd07.prod.outlook.com (2603:10a6:6:2c::18) by AM8PR08MB6497.eurprd08.prod.outlook.com (2603:10a6:20b:316::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 12:16:20 +0000 Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::77) by DB6PR07CA0104.outlook.office365.com (2603:10a6:6:2c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.6 via Frontend Transport; Fri, 14 Apr 2023 12:16:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.10 via Frontend Transport; Fri, 14 Apr 2023 12:16:20 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Fri, 14 Apr 2023 12:16:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ef786d83d753ea90 X-CR-MTA-TID: 64aa7808 Received: from 7a5ac8ddff87.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 417F3F8F-25DD-4196-A9B8-CD2349A78C44.1; Fri, 14 Apr 2023 12:16:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7a5ac8ddff87.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Apr 2023 12:16:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h2KcdKBQI+s79c3smXv9m6CgNARyObxxgv2xUmK6VaxeuLxtticj1QNPSKGBgpSIa+HRn1lW/9cKuWiASncvctdHko2FBqRJi8ePJnateDh1yRJ+vjiV3E9GzaQE/0/pJt6+n6RQNmT4wF/mqnJ0muUhoykf5uAPmkZo6mC6dNnKsBZBm2b7V0PUu7tYNi/NiORlg/KFv3NAmgvpO8fbEDwgS03b43MSK8q7N/YJ2rMDGCvBboVYLZLJmU8zPvb1GjJM/PIq1Pk2jLndlC3i6s7qejzaEGNP5nNRgtXFnzVbb9jq1tPsJ202sDY2JbkGu2nbi1zRoJnbgihGRV2Y3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7MwDlub4NJ27unAT/v0H5obJdCXUdEHfNL0Rd9p8Aqk=; b=YYZheQW9EmFqtjx37IIIfJczS47adZZDksCdFIGBgjFbTrLKMAjmLXZ9qj11UuVSNsTdkJ5XPVENU6S/5im95i/ZqRjifxa6KobF5/AOq2JVFPfkqathnfsdWcj4U8S/htIB3o+2Fi0UGdERMtUlI6gUoYpnshwnaOQ6FAP0bsyeaDAtG7ulODFGrQcpY593AbIxNCn/J/IBG3sP7Hw6Y0/KcDn+3NgHJXuPoYtDC7BZCnnIUxWrXl1ANUcK7NUuArk7lE+pe85e12YJom2EPRuDg2I93PojpLOrqW4tDI5huLypMvjVu3lwUlBwID3gVipWCjn5RJkejbgZn/75Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB9929.eurprd08.prod.outlook.com (2603:10a6:20b:564::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Fri, 14 Apr 2023 12:16:10 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::ff70:5431:70fa:34bf]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::ff70:5431:70fa:34bf%5]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 12:16:10 +0000 Message-ID: <7ad64299-eb76-82f2-7d60-7aff742369a0@arm.com> Date: Fri, 14 Apr 2023 13:16:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] [gdb/aarch64] debug registers: Add missing debug version entry for FEAT_Debugv8p8 To: gdb-patches@sourceware.org References: <20230414102028.23617-1-luis.machado@arm.com> Content-Language: en-US In-Reply-To: <20230414102028.23617-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0019.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::31) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB9929:EE_|DBAEUR03FT006:EE_|AM8PR08MB6497:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e2cda43-2a6a-44ed-02b4-08db3ce20ea2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MumVjdSIbZ/BTuuR9m5XHjnp9JeVDyvztN7kJeOM2xM9ZrlQYfGQG93LePherTP/nkWtMTKFIfAcX5KcQhukrFvJ+Z7TB8HZUwyenegI+MimeoSENFteg7lhxbDwC2F8rRyqdKK16KIYVkikC5orgFWQIoHBNrzI+8baasMxYAa0tvqO4ND4lg6AdTf2MojpwNaz78F1RZ2uoETX4rP2vkOxsFL3Bt3HNhy8Mfr7+GY+O/VxIwPPEzUYT3z2jXMsCy493Tu2HTwZgVRlHRLFuzaGfiA3AuxtMBhleOKiQCwF6MS/WomjDw1axSyk0ElK/0nNx3SSmCE0ZmIjdVS8SXdcWbX7QySXOHq1M3yARYAz/gRq3mdGvv+TV64aAzFMoBiyzLHrYvwkKNNT+UdDdI7SVEBB2ljymG/LjuYx3LzNSLpD1Y563Cgp20eYasCRkzOE2SfVMF+jUiX/Evcg3ofIwoYuIxlDTTK8LOzE9jjmlXV9bNN+5+dfHltN5Tmcz8bs579yE9wwtSKZVP0pUmFMnEBCpon8ozpbGxfodsBGmq7A3C1O+09uxhpszXOfPpvQFR4X2vNzyWRRiwOWBn6x55aJNQNad3OfUMIAG+CUS0baG9fxXQ3IG8o2OTdRnSWWTyAFvmMoh+c5Qj0lFA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(451199021)(2616005)(478600001)(31686004)(6506007)(6512007)(26005)(53546011)(66946007)(66556008)(6916009)(66476007)(316002)(6486002)(186003)(5660300002)(44832011)(8676002)(38100700002)(8936002)(2906002)(41300700001)(86362001)(31696002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9929 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c8565fa6-11a2-4df0-6ae4-08db3ce2082c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MXU7PmeMu81y8OHXh3Nd6cpUKAlkkCm59SrWueQUExy2J3UeRCZC0QuItYfOfZfpyPfm8weQxv6lZUSPLyrZfIsEDx9ygpYpnClL06mf0eqB1PAZwE1fvaTe+wZuKoytZNhPbiRbjVI0ueWL6Ta/HPXRX0a96LoGR0XXdwq1e8boFcbGRobMY8MIFgqZWPWi4hs6YNJdu07uXJixsgvk/vTyd8WD5BF6y9S5U7gQGetuLM9TYucjGiG5kA4T4x714z7owhNSwoMSyRxKi04A7enN2JmEMeIIK8sKUVON8RFaQxhxnerwvvYqaGKiLMcFKqdmkMtCo0AsMc6Zc5WjbO4oRgjMat/ueeUva1fF74+jbm5eulbW9Z+8N6Gki7AnM/L9oiSmLtqQ9HxbKEnFfN/WXHRnczaH8GYlQ+ywSaJSjsAaqmOuo+jghEs+UYM2vyfwS0abBZRHZPDV2mrUO3/QJ3/qCgpufBnKp9TeWoYUgD2NVX+yCwr1A+lFraE7Fc6tTzunnk/JgF/5o/6bKWly6o7VUMpX5T1FrbYYtDHWgNcDqBOlCOe7VjghRY4jx99QsZRoPVWdoyt4sMFpNuXbVRJquYTb4u0mzlFQvzUsPyJIX5ASqqPwI9twUCmp3tnR5huUUXXWzLwtbcniY+JD/jZrhXhRvtu5q9nr9DaXGkoUTPxn9Q2AddAibeAe/O6zaZKj1ipGtj2nErff3Xwlho18+5QLTeuhv/1OmDA= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(31686004)(41300700001)(82740400003)(40460700003)(36756003)(5660300002)(2906002)(31696002)(8676002)(40480700001)(86362001)(356005)(6916009)(8936002)(44832011)(82310400005)(70206006)(81166007)(70586007)(2616005)(336012)(47076005)(6506007)(6512007)(26005)(478600001)(53546011)(186003)(6486002)(316002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 12:16:20.8831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2cda43-2a6a-44ed-02b4-08db3ce20ea2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6497 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 4/14/23 11:20, Luis Machado via Gdb-patches wrote: > The Arm Architecture Reference Manual defines debug version 0b1010 for > FEAT_Debugv8p8. This is used to identify valid hardware debug registers. > > gdb currently only knows about versions up to FEAT_Debugv8p4. This patch > teaches gdb about this new version. > > No visible changes should happen as consequence of this patch, but in the > future gdb will be able to identify debug registers in newer hardware. > > Regression-tested on aarch64-linux Ubuntu 20.04/22.04. > --- > gdb/nat/aarch64-hw-point.h | 1 + > gdb/nat/aarch64-linux-hw-point.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h > index 13ec0c5fe9d..f4662f7c782 100644 > --- a/gdb/nat/aarch64-hw-point.h > +++ b/gdb/nat/aarch64-hw-point.h > @@ -58,6 +58,7 @@ > #define AARCH64_DEBUG_ARCH_V8_1 0x7 > #define AARCH64_DEBUG_ARCH_V8_2 0x8 > #define AARCH64_DEBUG_ARCH_V8_4 0x9 > +#define AARCH64_DEBUG_ARCH_V8_8 0x10 > > /* ptrace expects control registers to be formatted as follows: > > diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c > index 096c34fe9c8..ccb47cd5aa2 100644 > --- a/gdb/nat/aarch64-linux-hw-point.c > +++ b/gdb/nat/aarch64-linux-hw-point.c > @@ -232,6 +232,8 @@ compatible_debug_arch (unsigned int debug_arch) > return true; > if (debug_arch == AARCH64_DEBUG_ARCH_V8_4) > return true; > + if (debug_arch == AARCH64_DEBUG_ARCH_V8_8) > + return true; > > return false; > } Pushed now.