Re: [PATCH] Use strtok_r instead of strsep in rust_get_disr_info

Pedro Alves
2016-06-29T10:44:46Z

On 06/29/2016 11:38 AM, Manish Goregaokar wrote:
> strsep moves the pointer to the end of the string. We want to ensure
> the early break happens, since we need token to contain the name of
> the variant at this stage.
>
> strtok doesn't do this. However, strtok does make it NULL, which we
> don't want either. I added a check for it in my most recent email,
> tests still pass.

Right, that one is OK. Please push.

Thanks,
Pedro Alves