From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-132358-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17472 invoked by alias); 29 Jun 2016 10:36:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16778 invoked by uid 89); 29 Jun 2016 10:36:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 10:36:42 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8A77BC049D5A;	Wed, 29 Jun 2016 10:36:41 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5TAaeeU026809;	Wed, 29 Jun 2016 06:36:40 -0400
Subject: Re: [PATCH] Use strtok_r instead of strsep in rust_get_disr_info
To: Manish Goregaokar <manish@mozilla.com>
References: <CAFOnWkmN-uBB8iDjMaLpe=0SxWecFXxvvgfG2-FJn3j2XbBZJA@mail.gmail.com> <e349e31f-74b5-a2fa-b82b-5cbb6d548f16@redhat.com> <CAFOnWk=a2g-XEtsFjXp85DhTSmT4fVNSkWLuAa0WoS9JY_XM=w@mail.gmail.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <7ab96fcb-ffcd-c1ec-187d-f8ec05e43923@redhat.com>
Date: Wed, 29 Jun 2016 10:36:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <CAFOnWk=a2g-XEtsFjXp85DhTSmT4fVNSkWLuAa0WoS9JY_XM=w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-06/txt/msg00502.txt.bz2

On 06/29/2016 11:31 AM, Manish Goregaokar wrote:
> @@ -161,8 +163,6 @@ rust_get_disr_info (struct type *type, const
> gdb_byte *valaddr,
>            member_type = TYPE_FIELD_TYPE (member_type, fieldno);
>          }
> 
> -      if (token >= name + strlen (TYPE_FIELD_NAME (type, 0)))
> -    error (_("Invalid form for %s"), RUST_ENUM_PREFIX);
>        value = unpack_long (member_type, valaddr + embedded_offset);
> 
>        if (value == 0)

Why was this bit removed?

Thanks,
Pedro Alves