From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43282 invoked by alias); 25 Nov 2016 17:35:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43240 invoked by uid 89); 25 Nov 2016 17:35:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=whitespace, 1477, rebase-apply, 1325 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 17:35:24 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cAKPD-0006kp-09 from Luis_Gustavo@mentor.com ; Fri, 25 Nov 2016 09:35:23 -0800 Received: from [172.30.6.103] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 25 Nov 2016 09:35:20 -0800 Reply-To: Luis Machado Subject: Re: [PATCH 0/8] Fix gdb's testsuite test names References: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> <01dc0b4ef0735c891cb9be0e52151ab9@polymtl.ca> To: Simon Marchi CC: From: Luis Machado Message-ID: <7aace623-f875-fdb9-07b0-8662f5a1e862@codesourcery.com> Date: Fri, 25 Nov 2016 17:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <01dc0b4ef0735c891cb9be0e52151ab9@polymtl.ca> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00824.txt.bz2 On 11/25/2016 11:31 AM, Simon Marchi wrote: > On 2016-11-25 12:08, Luis Machado wrote: >> I was going to go with a single patch for this, but i kept hitting other >> cases where i needed to adjust the regular expressions and >> substitution rules. >> >> I then decided to have a series with each individual piece that should >> make it >> easier to review as well. The changes are all pretty mechanical, but >> it would >> be nice to have another pair of eyes looking at these to make sure >> nothing >> incorrect got through. >> >> The first patch handles the "testfile as test name" problem. The rest >> of the >> series handles test names starting with uppercase. >> >> Luis Machado (8): >> Fixup testcases outputting own name as a test name >> Fix test names starting with uppercase output by basic functions >> Fix test names starting with uppercase using gdb_test on a single >> line. >> Fix test names starting with uppercase using gdb_test_no_output >> Fix test names starting with uppercase using gdb_test_multiple >> Fix test names starting with uppercase using multi-line >> gdb_test/mi_gdb_test >> Fix test names starting with uppercase using multi-line >> gdb_test_no_output >> Fix test names starting with uppercase using multi-line >> gdb_test_multiple > > Hi Luis, > > I'll take a quick look at those. While applying, git gave me these > warnings. It's probably extraneous spaces that were there before, but > if you feel like it you can remove them. > > > Applying: Fix test names starting with uppercase output by basic functions > .git/rebase-apply/patch:3302: trailing whitespace. > pass "thread command" > warning: 1 line adds whitespace errors. > > Applying: Fix test names starting with uppercase using gdb_test on a > single line. > .git/rebase-apply/patch:1325: trailing whitespace. > gdb_test "print r" " = -1" "test cos(pi) is equal to -1" > .git/rebase-apply/patch:1477: trailing whitespace. > gdb_test "set print test-enum-param three" "Undefined item: \"three\".*" > "set invalid enum parameter" > warning: 2 lines add whitespace errors. > > Simon Thanks. Sure, i'll patch those up.