From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7737 invoked by alias); 16 Mar 2018 20:01:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7660 invoked by uid 89); 16 Mar 2018 20:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=H*r:207 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Mar 2018 20:00:53 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 6C.32.21824.9622CAA5; Fri, 16 Mar 2018 21:00:41 +0100 (CET) Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSHC007.ericsson.se (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 16 Mar 2018 21:00:41 +0100 Received: from ESESSMB505.ericsson.se (153.88.183.166) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Fri, 16 Mar 2018 21:00:41 +0100 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Fri, 16 Mar 2018 21:00:40 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.117] (192.75.88.130) by BL0PR1501MB2004.namprd15.prod.outlook.com (2603:10b6:207:32::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Fri, 16 Mar 2018 20:00:38 +0000 Subject: Re: [RFA] Remove make_cleanup_free_section_addr_info To: Tom Tromey , Simon Marchi CC: References: <20180313165529.23237-1-tom@tromey.com> <87605wspqx.fsf@tromey.com> <4fe276e4-d179-a515-be12-a9e6899bbca2@polymtl.ca> <87woybrgf3.fsf@tromey.com> From: Simon Marchi Message-ID: <7a9d83f8-f043-3375-7f36-0ef5ad937c14@ericsson.com> Date: Fri, 16 Mar 2018 20:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87woybrgf3.fsf@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR11CA0042.namprd11.prod.outlook.com (2603:10b6:404:4b::28) To BL0PR1501MB2004.namprd15.prod.outlook.com (2603:10b6:207:32::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f64c3626-6b1a-465a-90f0-08d58b7896bd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BL0PR1501MB2004; X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2004;3:f5fiFuNaSBdFFDGqYUivkqoeiodcbOtJtuyu43ss8nSvR06OYe/cImdDHfS5k2N9+/KObgMhw5zCxwD0DHXqB3VD5a55V+LAJikdIgwsmOjohgDmjx7BjAVqeVSRStMHu1gBAEjnuHo5SyHsLkyjysLtw/uAJSTH6kW7ZD43V3d6CWKT1Kz0Tz4Y3c3ukP8faFyczEqD6KHx7XtMFMfuwzvhIu+Fvc0jYR3aDKJT30yq+SRyRGStY3tlhHf7Ozo3;25:zxV/HGmfBc7KGnAodhUOgvmSOiUebrHkWOnBP2MavcEAKyQ54XiXC/0UoGObl15GOSdjHaqvIJsppRW9ZGiIhAVxlASTfVSgEm93iRwGZO1aEjWgyx8ccYRA1R8ln2utNaCb8DpnFKcUBrzyrjpeQ5Dsk2GBqV8qKb2H7BkbNQThPb7JPTVpDRhSiS6yw0fDKFkehIpZdwNYEGEOg8I1mHIi8/jaqmzy9cNdwd9z1cSI58s9bquvo1vu+nMB3NR72UNmS+NRKQBHz9fYS8K26O/AZ4pd5yyYk19tNiACiZss83348iOVkpYD566389EC9hFjt9hYQk8SrMHsBWwwoQ==;31:rkPOzTqOODCAlQxjFHFg9/KnH7Vgx1N+oY+edBeFd7VMcYaYR8QN0y7TbsrSa0bcurvzAfD227OTCSszcNPAooXBeoM8BHeM9cj722rpFQkGiyBcm3H6ZCHdYT4pWktzpfIrl+jP4+zhFwV8NVtTmmjLBI1pE2t/vbOhchj23JLUYUFWQ/n7AVeCP1xppb+IuLbuALcvtGbKWrWmboDrtCEVd5I0rvJUQJbyYDxpOBM= X-MS-TrafficTypeDiagnostic: BL0PR1501MB2004: X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2004;20:HlG1L2iTyD68SrqaVLaudXdtCEeQ9Wr91yZcyeIeynq7PR63Z54JASlFjLWaw7Z6CpazYQeFE0fQCaqxbV5IFwKz97n4cByjaMz/2JMkOSkXMuI9MadwdUm3ATaVdQKMW1WREQzkm4BlzHbKQMokiRcPvpX4UunSqF2d+oPxlaE9P8apL6+gVVFC/aaDHTx2Ya+UEZOXyWtaxpOI/oLDkANzoRnanUKYMsAaIFr/b7X1QsqO+lKQhP/kv7c3og05on7qOMHdDIP6XpLWR///T136Qr+K9TFb2cPMBxB7N29sKLSr2kdHCKz4ASmIpCxHXimT0TlwBQR5OPYaMTi0tOrdYVSLILQlrz6n9bbUcoStDEIMO/zdoyjltAoj4NDKCJ0UYNYEWiM5M+n+tDXyMZ+Gw3ExrQTDQ/X+oOUMnSTRQUxhLXf20b/ZmO7UMzZO/go+iEFHdDbK4PoR0IXb5GN0AATdOuTNDkrVMkEAtuBLyE+hJrmr+pBkTzeFmL3k;4:MKwWlNGHvynNAUZ7pevyV7rVkaGarxre6iE5DIimQyDOoPpAsmJqXx/vTD6t3sEOrPNOoZehnCmrtI8Ga/buZlfrVYI88REAPzpcrVVPT1yZVaRP+DB8GubXwDqvRe9CmqjIxFoO/jEh30cpPLoTeiAHVh7fBF+CjFMokIlVnuzZR+WGyyVzMp2AprRXop0b3g+U/BnccIqCDFmkfRedEs/WQR9yVw7dnI42wR1YoksE9fJgolUkXGBq8/AhU7Zk3d/czbAwPDnkj6GzgEBNYQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231221)(944501244)(52105095)(93006095)(93001095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011);SRVR:BL0PR1501MB2004;BCL:0;PCL:0;RULEID:;SRVR:BL0PR1501MB2004; X-Forefront-PRVS: 0613912E23 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(396003)(39860400002)(39380400002)(376002)(346002)(377424004)(199004)(189003)(478600001)(36756003)(7736002)(6246003)(229853002)(2906002)(2950100002)(25786009)(3846002)(4326008)(6666003)(31686004)(65826007)(5660300001)(305945005)(6486002)(53936002)(6116002)(97736004)(106356001)(16576012)(230700001)(76176011)(316002)(2486003)(52146003)(52116002)(23676004)(8676002)(81166006)(8936002)(105586002)(64126003)(58126008)(50466002)(16526019)(53546011)(186003)(47776003)(110136005)(26005)(81156014)(49976009)(86362001)(386003)(68736007)(66066001)(93886005)(31696002)(65956001)(65806001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR1501MB2004;H:[142.133.61.117];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDBQUjE1MDFNQjIwMDQ7MjM6Rm56cTVxL3NmeDFkajBGNHpTc2gvUkVv?= =?utf-8?B?UENUbFRQeEZOdEVwaXFoU2duWC9hQVpSM001Y2ZDRVFUNGRhWVlKZUV3am1i?= =?utf-8?B?LzRBMFNuU1BIK2NTYysrVGl3NnJaZmNTaHV2c2JZa3hWSi9ROEozWTRyYVdE?= =?utf-8?B?Vkg5b2IxZUp0WkJuanNDZ3k2UE1pUFdQSWtXTUZCeWRjcjBpUm9MTUhEQ3da?= =?utf-8?B?N1RzZG9CbDFnaWk2bHB6bkJYdTAzZzZ0djYrYWtNZGYzd2N0N2h1RDRNTmxM?= =?utf-8?B?VVhINE1ZT2xiTjd4L3VKTzNYTXZVTUJPZmdicWxsNXlqR1NzdDl1SFhWdlpS?= =?utf-8?B?RVFsampZa244cnJuM1BWZGxTUWc0UGZpY3V3aGh3ekVQVlZVeUp3L1BuK2tC?= =?utf-8?B?aHRkWmNJZkp5ZFJHZ05sd2JCL3Z5cTdDNFFrNVd4Nm5hbGM5NWtOWGRXL2hR?= =?utf-8?B?VEF5c2ZMcHBDbkpER1dRZXdDM2p0YUZsbjQ3WFR3c3htMFFvK3lVQkFvNXcx?= =?utf-8?B?QzdsSXJVUjhtbFBjeklNaDIwUzJnbkNpbVRVSElyaitjRnM5SUkyRWM0UW0y?= =?utf-8?B?dDJiWXZHbkpjbTJCR3lHaFF2MDQ0dHBQSWcxbWxkcEhBNUx3OGl2RHJZTDBj?= =?utf-8?B?ZUlxVnE2VFpDVHZWTE1xeVNQMXhiOFpXWDZ6d3laSE1DY0hWM2thS0p6THBX?= =?utf-8?B?d2ZkOWgybGE2OGJoeExFa2ZBSTQyMWFYdTMyNFkyS3hrUlZqQzNSKzNZWXRk?= =?utf-8?B?Y2lvN3ZOVDZXbFdRZlBQUTQwbFBNVnBIOU8yQm8yeHh6Y2UrcTZxQk9DdUEy?= =?utf-8?B?SjdVTEZ6NUQ0M25JbENaM0lNVjZaamdTMC9MMDY4bmQ3cHFJVEtkR0tzeUtG?= =?utf-8?B?Qit6cnNzY3o0cXFiOFlmUmFzbHZLSkUwUlIwR25DanNNM29RcXRYalBrQ2Nz?= =?utf-8?B?VlgrT2NwMTdkdGZmekxqS2dhQlJFT2luVTBUYWdoT0xrangrcGQ2cUFIcUZI?= =?utf-8?B?a0E0TnZhdTVHMHUwZWZpVTc2aThsVitpM09iNUV1TkFqTHNZS0pHMlhiUyt3?= =?utf-8?B?Z1hQeVM4MGJLYXVCa3laeUxGY3JzNHphNjM2cjRnaTdwSmFLcnNmQjNoVm5u?= =?utf-8?B?VEtEYUM3blZseDU1eUtVVHRPZXdXTmV6QXZObkRuYW9BdnhVdCs1UlJmTGp0?= =?utf-8?B?Mmp5THJId1BVano1cStkaTJKQkdmMGlmVk5zSW1tVklsdnU1ait6SklXMnpM?= =?utf-8?B?c1VmVDBOcldhaUZsYmlHZDBXOFNXTk1raGtDRndia2F3OUJkQ3Q5TENvb3Iv?= =?utf-8?B?T1hhcC95Wlc0U3JPMExvai9iUEhYamlLVEhlU1JsMTY4Wk0za0wvOGhxL3JF?= =?utf-8?B?cm1xWVA0aUNwUEx1YkpoaXJkQmFkQW82eVlCMWY1QkFZMGJQN1hUOG9paE0r?= =?utf-8?B?bmxSOTZ2V3VPUmxTRWpzUi9yd1pRZXZrbEZmMUs2RkgrdkRiRkVCY1ZUYnoy?= =?utf-8?B?TUpPMWUzL0E2K21pRmtjMGMwaXhmWTloT0M4Vlh5TlY3ZThIRFVXTzJMaUhT?= =?utf-8?B?emVabzdma2tTbGM2ZDVFVWJYV2FNL0xPcGlKWXMrRGJ6MGpGZXFLZWF0RmpW?= =?utf-8?B?ZTR2WWxpcGFidEZYQmUrSW9OVzh0eFpBZzJpdTE2UmtzaVNHcTFaTG9OZ1JB?= =?utf-8?B?T2NqcjU0S0JYdTl6UDlBcFFFcHovR0t6ZWs4WmNvREIxU1A0VmI1ZTBwQ0RE?= =?utf-8?B?akJOKzRCNTBwVUpxR2dMalRiRE83WGZydWhxWTdQTHRMUkRqa2E1dkt4bVBw?= =?utf-8?B?QjhGd0lNNEYyTzVVb2lad2tuTFlHYjRQWHBPSUZsRUgxbFBjNXBGL084SFZ0?= =?utf-8?Q?rhH4QQFYIgt5P2yQGWxlIqQSMyaF24cxn4?= X-Microsoft-Antispam-Message-Info: ZHKAiETFWYZjztM18Gx7N5ygt82no2jSToEf0cqaTyJZiUWdhnjw/8ON/jGzZtJwawYa75WBd1eztMcCmLGlQ7wrRvdlpi7/kzzpf8QtjV+vucZb86JJ0fjrEhY9JW/0XiYmCoGcIDyROpkq90f+RHnDYsGeST2SV/Uh5na4RF1IfuuJRzNLHYRTbfzGbolQ X-Microsoft-Exchange-Diagnostics: 1;BL0PR1501MB2004;6:/1TY7Xi3HQxRJTXkfTjR3qtS563coKX9CkpHA4Lgq0wDZBWlfihsQO1e255xXrD/GUPpx7NWkB2c6UNkFiI5snK8ZoE3hnV4p8iiD6JgT6Xx+sPys9nphQmr2LFPky+pNBS9j4qxi/hAPmxiH8Cppiv2S0zqq8Wvgwx3PeyU9GD9c9ja6LjtJm6iXLZ2G8ivqhsCkelbH3IsAk0Hsrr5bUh4LDxybuA++ovfOYvwX/HxKXNM4KDxBIvlNU073tyabgy0fYrpmxlWkb2Qa2AwbFk5RRPohYsDsWBe/t9LrMuHOAMLChfSKiKvm1xvx+NVYgguuGqJdMr+Bv8ZBNvITkinyOvMXNJEkzQWMt6WEV0=;5:cbHh06to+7JKbxwUYGcnOKJ5RS5RO4nlwd65/sB2deodmmbUT00ZYtfh14iEDhbkubX0jGiO40QZDM8J/d7raM1BJ8sMRvPuDZcasyk/XKwDFHwYAbJ5o5P5tbmNyi74L2m6mceJY6BnhLBPmc+G81TOJqP52bBpNUtT9U9iGUU=;24:JOkV8COFeJEyPV1QktjyKvZr/Os+OLkvk3E8quQV6isnxlY6f36BeQaoxgMkTXY7lUOz7B0tOVWIXqLqbEMasW1V7CaTseJgzvJy0HB+Mh4=;7:wZ0Gvpx+ooB3uy6koPpV7CjFP3PJWI0SXJbt6YjBpJh8frD8o60muLMeIlPv+Q+mr7oxpC0ncn7Xgegj9/+4ymaTC6DHJRVRS0Hv3GUTFmBGGq10b4Z1RWYjMk1LIW8aoBXn0kx0kKOxmM1ctYbSjxaulHfxsm6VC2M21R4BapXSvZ9B7n90fwfA2NTmhYyIrT26oAt6BXaDzwe1jHQEhENsfwTEX9HqacXNviXcGJo4YXETTgcuNDHewVRy1mdr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2018 20:00:38.2572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f64c3626-6b1a-465a-90f0-08d58b7896bd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB2004 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00327.txt.bz2 On 2018-03-16 03:04 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I took a quick look, it LGTM, but indeed having a constructor in > Simon> other_sections would make it nicer IMO. > > Yeah, it's a lot better. > > Tom Thanks for doing this, LGTM. Simon