From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97609 invoked by alias); 8 Feb 2020 15:48:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97541 invoked by uid 89); 8 Feb 2020 15:48:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2020 15:48:23 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 173FD1E08E; Sat, 8 Feb 2020 10:48:11 -0500 (EST) Subject: Re: [PATCH][gdb] Mention CU offset for if verbose To: Tom de Vries , Christian Biesinger Cc: gdb-patches References: <20200207113429.GA6532@delia> From: Simon Marchi Message-ID: <7a8ea599-5254-46be-95b3-fa2af134656d@simark.ca> Date: Sat, 08 Feb 2020 15:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00231.txt.bz2 On 2020-02-08 4:16 a.m., Tom de Vries wrote: > On 07-02-2020 15:45, Christian Biesinger wrote: >> On Fri, Feb 7, 2020 at 6:34 AM Tom de Vries wrote: >> >> >>> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >>> index dafe01d94a..28ade424fd 100644 >>> --- a/gdb/dwarf2read.c >>> +++ b/gdb/dwarf2read.c >>> @@ -8020,6 +8020,20 @@ create_partial_symtab (struct dwarf2_per_cu_data *per_cu, const char *name) >>> struct objfile *objfile = per_cu->dwarf2_per_objfile->objfile; >>> dwarf2_psymtab *pst; >>> >>> + const char *artificial = ""; >> >> This may not matter but I'd use static const char artificial[] = "..." >> > > Done. > >>> + if (strcmp (name, artificial) == 0) >>> + { >>> + sect_offset cu_offset = per_cu->sect_off; >>> + const char *cu_offset_str = sect_offset_str (cu_offset); >>> + const char *sep = "@"; >>> + char *new_name = (char *) xmalloc (strlen (artificial) + strlen (sep) >>> + + strlen (cu_offset_str) + 1); >>> + strcpy (new_name, artificial); >>> + strcat (new_name, sep); >>> + strcat (new_name, cu_offset_str); >> >> Use concat() instead of malloc/strcpy/strcat? >> > > Done. > > Updated patch re-tested and attached. Should the string allocated with concat be freed? Simon