From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 5F27C3870851 for ; Wed, 26 Aug 2020 23:14:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F27C3870851 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E50FB673; Wed, 26 Aug 2020 23:15:13 +0000 (UTC) Subject: Re: [committed][gdb/testsuite] Add gdb.base/eh_return.exp From: Tom de Vries To: Luis Machado , gdb-patches@sourceware.org References: <20200816113123.GA29297@delia> <3583b056-388d-86b4-c213-e7b09e30ab89@suse.de> Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <7a8cc2a5-ea23-31c9-51d5-e81b6d0a2069@suse.de> Date: Thu, 27 Aug 2020 01:14:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3583b056-388d-86b4-c213-e7b09e30ab89@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 23:14:44 -0000 On 8/26/20 8:02 PM, Tom de Vries wrote: > On 8/26/20 7:20 PM, Luis Machado wrote: >> On 8/16/20 8:31 AM, Tom de Vries wrote: >>> Hi, >>> >>> In PR25350, an internal error was reported: >>> ... >>> (gdb) break *eh2+0x7e >>> Breakpoint 1 at 0x13e2: file small.c, line 38. >>> (gdb) run >>> Starting program: a.out >>> [Thread debugging using libthread_db enabled] >>> Using host libthread_db library "/usr/lib/libthread_db.so.1". >>> >>> Breakpoint 1, 0x00005555555553e2 in eh2 ( >>> frame.c:558: internal-error: frame_id get_frame_id(frame_info*): \ >>>    Assertion `stashed' failed. >>> A problem internal to GDB has been detected, >>> further debugging may prove unreliable. >>> ... >>> >>> The internal error does not reproduce after recent commit 547ce8f00b >>> "[gdb/backtrace] Fix printing of fortran string args". >>> >>> Add the corresponding test-case as regression test, given that the >>> code is >>> rather atypical. >>> >>> Tested on x86_64-linux. >> >> This doesn't work so well on aarch64-linux because the breakpoint >> location from before running the program doesn't exists after running >> it. Things get relocated. >> > > Right, I don't think that's architecture-related. > > I'm running into the same issue on x86_64-linux with target board > unix/-fPIE/-pie. > >> -- >> >> (gdb) break *0x000000000000099c^M >> Breakpoint 1 at 0x99c: file >> /home/luis.machado/work/tcwg/build/binutils-gdb-master/gdb/testsuite/../../../../repos/binutils-gdb/gdb/testsuite/gdb.base/eh_return.c, >> line 54.^M >> (gdb) PASS: gdb.base/eh_return.exp: setting breakpoint at >> *0x000000000000099c >> run ^M >> Starting program: >> /home/luis.machado/work/tcwg/build/binutils-gdb-master/gdb/testsuite/outputs/gdb.base/eh_return/eh_return >> ^M >> Warning:^M >> Cannot insert breakpoint 1.^M >> Cannot access memory at address 0x99c^M >> ^M >> (gdb) FAIL: gdb.base/eh_return.exp: hit breakpoint >> >> -- >> >> Shouldn't we insert a breakpoint after the relocation has happened? > > As I mentioned in the test-case: > ... > # The assert did not reproduce when running to main, and continuing to > # the breakpoint, so instead, run to the breakpoint. > ... > So I'm afraid that's not going to work. > >> Or >> add the breakpoint to a symbolic reference? > > Yeah, that might work. If not, we'll have to restrict this to no-pie. So, I tried this using: ... $ git diff diff --git a/gdb/testsuite/gdb.base/eh_return.c b/gdb/testsuite/gdb.base/eh_ret urn.c index 80eea9c783..ba8c1c51aa 100644 --- a/gdb/testsuite/gdb.base/eh_return.c +++ b/gdb/testsuite/gdb.base/eh_return.c @@ -51,6 +51,8 @@ eh2 (void *p) { eh2a (val, val, val, val, val, val, val, val, p); __builtin_eh_return (0, p); + here: + (void)0; } diff --git a/gdb/testsuite/gdb.base/eh_return.exp b/gdb/testsuite/gdb.base/eh_r eturn.exp index e38398ed37..182b2ed86d 100644 --- a/gdb/testsuite/gdb.base/eh_return.exp +++ b/gdb/testsuite/gdb.base/eh_return.exp @@ -22,23 +22,9 @@ if {[prepare_for_testing "failed to prepare" clean_restart ${binfile} -gdb_breakpoint "*$address" message +gdb_breakpoint "eh2:here" message # The assert did not reproduce when running to main, and continuing to the # breakpoint, so instead, run to the breakpoint. ... But then we run into another internal-error while setting the breakpoint, see PR25067: ... src/gdb/linespec.c:3233: internal-error: void decode_line_full(const event_location*, int, program_space*, symtab*, int, linespec_result*, const char*, const char*): Assertion `result.size () == 1 || canonical->pre_expanded' failed.^M A problem internal to GDB has been detected,^M further debugging may prove unreliable.^M ... Thanks, - Tom