From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138487-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 115260 invoked by alias); 19 Apr 2017 16:30:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 114350 invoked by uid 89); 19 Apr 2017 16:30:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Apr 2017 16:29:59 +0000
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 2D61B3B72D;	Wed, 19 Apr 2017 16:30:00 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2D61B3B72D
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2D61B3B72D
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 7F5C45C546;	Wed, 19 Apr 2017 16:29:57 +0000 (UTC)
Subject: Re: [PATCH v3] C++ify gdb/common/environ.c
To: Simon Marchi <simon.marchi@polymtl.ca>, Sergio Durigan Junior <sergiodj@redhat.com>
References: <20170413040455.23996-1-sergiodj@redhat.com> <20170418030319.12637-1-sergiodj@redhat.com> <843eaee444605d981d452a1801a24ebf@polymtl.ca>
Cc: GDB Patches <gdb-patches@sourceware.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <7a800cad-bc12-9d20-8ddb-11fd90aa7073@redhat.com>
Date: Wed, 19 Apr 2017 16:30:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <843eaee444605d981d452a1801a24ebf@polymtl.ca>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-04/txt/msg00571.txt.bz2

On 04/19/2017 05:56 AM, Simon Marchi wrote:
>>
>> +      return (char *) this->m_environ_map.at (var).c_str ();
> 
> You can remove the cast here.

And while at it, please write "m_environ_map" without the leading 
"this->".

(Likewise other similar cases, I haven't looked at the patch in
any detail.)

Thanks,
Pedro Alves