From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pfx3Itlv+mg71AQAWB0awg (envelope-from ) for ; Thu, 23 Oct 2025 14:11:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1761243097; bh=/b06pACNXLFzpLgNMDLYEsmGvzI3VCP+xFdkkd+kEUI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w94R/h/aMfxUQ0BCiV7pqxvuuaFG9EaGC8aRxUVrVbrED4L5J3gJAgjB7J6a3RH1I BgUT4EG55SZhRZfMHT9buPcYH+THOrUoXgyIGijn6naVFHhCPNtoaozWlndX9oPsCQ tguDcTVbwoJnKViP+6ROEnTIvDUJIx575m1j8+1E= Received: by simark.ca (Postfix, from userid 112) id 7AE1B1E0BC; Thu, 23 Oct 2025 14:11:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GAjh2Q93; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C0BD1E04C for ; Thu, 23 Oct 2025 14:11:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29C75385801B for ; Thu, 23 Oct 2025 18:11:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29C75385801B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GAjh2Q93 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D2F0E3858419 for ; Thu, 23 Oct 2025 18:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2F0E3858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2F0E3858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761243065; cv=none; b=cQUuVMCPyvha288wdMurSpzqxJj4CqTNwrHQvSZ07Ofrt/xqMniMEuMnfsoR0gMDdayYUZOq5JBssTNyJiNw+EeizKyYQRMFSWz0RywOwefZVulB92Y65Yw9R6UWPvKfZt9PLvbTe7pCJwP7VPxNotstwiFkWzBatgB774w6dDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761243065; c=relaxed/simple; bh=/b06pACNXLFzpLgNMDLYEsmGvzI3VCP+xFdkkd+kEUI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EjLYKogwwag1/U5kTjXx84O+XqpASiviHyNWf+A3bR68jYeNitf1nYh0lpb4RnkUW3QFvIADUlRKEpbBbdvp1PLFsU/urCk1/bUq1XX9YWiH8w3CUs9087R1wQ4gUNCkdwqrygcMzMF4YTcq7L39Z0cA3E4Y99f77UQzNuebr9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2F0E3858419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1761243065; bh=/b06pACNXLFzpLgNMDLYEsmGvzI3VCP+xFdkkd+kEUI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=GAjh2Q937kjmFJuTa8fSvryLIFu3CuV3LSPBiaolPAVw91l3cJRARukPl+EsGBXOr EYr+4YbRFLNw17buZygUWoeiZ5c84Z2HpMV/im0alFvTFMU2gc8ldhkbLbG0Ft6m20 Dc5Iehl/WRDkdzX41qCRn1oTq8cSN4J9+uoO0d20= Received: by simark.ca (Postfix) id 595FD1E04C; Thu, 23 Oct 2025 14:11:05 -0400 (EDT) Message-ID: <7a66a649-7bfa-4c9c-9289-7e513dc19077@simark.ca> Date: Thu, 23 Oct 2025 14:11:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/8] Remove stabs support from GDB To: Guinevere Larsen , gdb-patches@sourceware.org References: <20251020152853.28195-1-guinevere@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20251020152853.28195-1-guinevere@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/20/25 11:28 AM, Guinevere Larsen wrote: > Now that GDB 17 has branched, I think we're ready to remov stabs from > GDB entirely, and the sooner this is merged, the earlier we'll spot any > problems and the more time will be there to fix them. > > This series does just that. Hello, I got another build failure that is likely related to this series. It's a -Werror=nonnull error, when building with UBSan, but I think it's not a false positive. CXX xcoffread.o /home/smarchi/src/binutils-gdb/gdb/xcoffread.c: In function ‘void enter_line_range(subfile*, unsigned int, unsigned int, CORE_ADDR, CORE_ADDR, unsigned int*)’: /home/smarchi/src/binutils-gdb/gdb/xcoffread.c:573:44: error: ‘this’ pointer is null [-Werror=nonnull] 573 | addr += objfile->text_section_offset (); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ In file included from /home/smarchi/src/binutils-gdb/gdb/xcoffread.c:43: /home/smarchi/src/binutils-gdb/gdb/objfiles.h:512:13: note: in a call to non-static member function ‘CORE_ADDR objfile::text_section_offset() const’ 512 | CORE_ADDR text_section_offset () const | ^~~~~~~~~~~~~~~~~~~ /home/smarchi/src/binutils-gdb/gdb/xcoffread.c:579:63: error: ‘this’ pointer is null [-Werror=nonnull] 579 | - objfile->text_section_offset ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ /home/smarchi/src/binutils-gdb/gdb/objfiles.h:512:13: note: in a call to non-static member function ‘CORE_ADDR objfile::text_section_offset() const’ 512 | CORE_ADDR text_section_offset () const | ^~~~~~~~~~~~~~~~~~~ The full configure line is: $ ~/src/binutils-gdb/configure --prefix=/build --disable-binutils --disable-ld --disable-gold --disable-gas --disable-sim --disable-gprof --disable-gprofng --with-system-readline --with-system-zlib --enable-targets=all --with-expat=yes --with-python=python3 --with-guile --enable-libctf --enable-build-warnings --enable-gdb-building-warnings --enable-unit-tests --enable-ubsan 'CC=ccache gcc' 'CFLAGS=-O2 -g -fsanitize=address ' 'LDFLAGS= -fsanitize=address' 'CXX=ccache g++' 'CXXFLAGS=-O2 -g -fsanitize=address -D_GLIBCXX_DEBUG=1 -Wno-error=array-bounds ' GCC version 15.2.1. I think it's correctly complaining, because this_symtab_objfile is never ever set anymore. And neither is this_symtab_psymtab. I realized this when trying to refactor the code to remove these globals, trying to pass them as parameters instead. Simon