From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20349 invoked by alias); 17 Jul 2017 11:14:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20319 invoked by uid 89); 17 Jul 2017 11:14:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=factors X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 11:14:44 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA4747F404 for ; Mon, 17 Jul 2017 11:14:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EA4747F404 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EA4747F404 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FD264DA3F; Mon, 17 Jul 2017 11:14:41 +0000 (UTC) Subject: Re: [PATCH 10/40] Clean up "completer_handle_brkchars" callback handling To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-11-git-send-email-palves@redhat.com> <5967E145.4070503@redhat.com> From: Pedro Alves Message-ID: <7a448a70-737b-dd61-2ca5-e46b43b1e6d2@redhat.com> Date: Mon, 17 Jul 2017 11:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5967E145.4070503@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00223.txt.bz2 On 07/13/2017 10:08 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: >> This patch cleans up "completer_handle_brkchars" callback handling: >> >> - Renames the function typedef to better match its intent: >> completer_ftype_void -> completer_handle_brkchars_ftype >> >> - Factors out common code in complete_line_internal handling the >> "handle_brkchars" callback to a separate function. >> >> - Centralizes all the "completer method" to "handle_brkchars method" >> mapping in a single function. >> > > I don't see any issues. Thanks much Keith. I pushed it in. -- Pedro Alves