From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26400 invoked by alias); 2 Sep 2013 09:28:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26388 invoked by uid 89); 2 Sep 2013 09:28:38 -0000 Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 02 Sep 2013 09:28:38 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 38246266083B; Mon, 2 Sep 2013 11:28:35 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KLwvL0cJEJAP; Mon, 2 Sep 2013 11:28:35 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 22040265F597; Mon, 2 Sep 2013 11:28:35 +0200 (CEST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [PATCH v3] Windows x64 SEH unwinder From: Tristan Gingold In-Reply-To: <521CE5C1.2030700@redhat.com> Date: Mon, 02 Sep 2013 09:28:00 -0000 Cc: "gdb-patches@sourceware.org ml" , Joel Brobecker , Roland Schwingel Content-Transfer-Encoding: 7bit Message-Id: <7FC85284-19D6-4D91-8CD1-842617D2DE80@adacore.com> References: <1357728781-15073-1-git-send-email-brobecker@adacore.com> <1357728781-15073-3-git-send-email-brobecker@adacore.com> <50ED9221.1050504@redhat.com> <9E84DF2D-7AF8-4AA1-A5DF-171EF189A6E7@adacore.com> <50EDA48E.2030406@redhat.com> <66611BA9-4536-42B2-A65C-4EA5DA219E22@adacore.com> <50EEEB3C.9050202@redhat.com> <5BE11EDB-7832-4489-8CB1-6382F5D1D34E@adacore.com> <51F29440.3030808@redhat.com> <6F12353E-D32C-40F0-87BF-AA77FC15BE03@adacore.com> <52162DA9.5060108@redhat.com> <848C81AC-2171-412B-A6F2-101352933F3E@adacore.com> <52163929.1090008@redhat.com> <9FD66EEA-C685-4F32-8F91-F9E0FF6AAAEE@adacore.com> <521CE5C1.2030700@redhat.com> To: Pedro Alves X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00006.txt.bz2 On Aug 27, 2013, at 7:45 PM, Pedro Alves wrote: >> >>> And, this version is then a compromise. Right? >> >> The only compromise is when there are no unwind infos. Previously >> a default unwinder based on heuristic was used (doesn't work well, >> particularly for MS dll). With the patch, they are considered as >> leaf functions by the SEH unwinder. > > Okay. > > FAOD, the patch is fine with me. Now committed. Thanks, Tristan.