From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: [PATCH v2 0/8] Remove XML files from gdbserver
Date: Wed, 24 Jan 2018 09:26:00 -0000 [thread overview]
Message-ID: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> (raw)
Following review comments from Yao, this patch series is mostly a
reordering of the code from the previous patch series.
This set of patches removes the need for gdbserver to ship the xml files
in the binary for those targets that use new style target descriptions.
In exisiting code, gdbserver uses C code auto generated from xml files to
create target descriptions. When sending an xml description to GDB, it
creates an xml containing just the name of the original xml file.
Upon receipt, GDB reads and parses a local copy of xml file.
With this new patch, we add common code that allows gdbserver and gdb
to turn a C target description structure into xml. To do this we must
first ensure that when gdbserver parses a target description it retains
enough information to turn it back into xml.
The second patch commonises tdesc_reg, the third patch commonises
tdesc_feature and the fifth patch commonises the tdesc type structures.
This enables gdbserver to store all required information about a target
description.
The sixth patch adds the xml printer.
The other patches are clean up patches.
Patches have been tested on a make check on x86 targets=all build with
target board unix native-gdbserver. Also tested aarch64. Built for power
(becuase it does not use new target descriptions), but am unable to test.
In addition, patch four adds new test cases to unit test.
Alan.
gdb/Makefile.in | 1 -
gdb/arch/tdesc.c | 425 ------------------------
gdb/arch/tdesc.h | 307 +-----------------
gdb/features/aarch64-core.c | 2 +-
gdb/features/aarch64-fpu.c | 2 +-
gdb/features/i386/32bit-avx.c | 2 +-
gdb/features/i386/32bit-avx512.c | 2 +-
gdb/features/i386/32bit-core.c | 2 +-
gdb/features/i386/32bit-linux.c | 2 +-
gdb/features/i386/32bit-mpx.c | 2 +-
gdb/features/i386/32bit-pkeys.c | 2 +-
gdb/features/i386/32bit-sse.c | 2 +-
gdb/features/i386/64bit-avx.c | 2 +-
gdb/features/i386/64bit-avx512.c | 2 +-
gdb/features/i386/64bit-core.c | 2 +-
gdb/features/i386/64bit-linux.c | 2 +-
gdb/features/i386/64bit-mpx.c | 2 +-
gdb/features/i386/64bit-pkeys.c | 2 +-
gdb/features/i386/64bit-segments.c | 2 +-
gdb/features/i386/64bit-sse.c | 2 +-
gdb/features/i386/x32-core.c | 2 +-
gdb/features/tic6x-c6xp.c | 2 +-
gdb/features/tic6x-core.c | 2 +-
gdb/features/tic6x-gp.c | 2 +-
gdb/gdbserver/Makefile.in | 3 -
gdb/gdbserver/configure.srv | 36 +++
gdb/gdbserver/tdesc.c | 229 +++++++------
gdb/gdbserver/tdesc.h | 58 +++-
gdb/regformats/regdat.sh | 5 +-
gdb/target-descriptions.c | 924 +++++++++++++++++++++++++++++++++++++++--------------
gdb/xml-tdesc.c | 9 -
gdb/xml-tdesc.h | 5 -
32 files changed, 920 insertions(+), 1124 deletions(-)
next reply other threads:[~2018-01-24 9:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 9:26 Alan Hayward [this message]
2018-01-24 9:26 ` [PATCH v2 1/8] Move tdesc header funcs to c file Alan Hayward
2018-01-24 9:27 ` [PATCH v2 2/8] Use tdesc_reg in gxdbserver tdesc Alan Hayward
2018-01-25 13:12 ` Philipp Rudo
2018-01-24 9:28 ` [PATCH v2 3/8] Use tdesc_feature in gdbserver tdesc Alan Hayward
2018-01-25 13:12 ` Philipp Rudo
2018-01-24 9:28 ` [PATCH v2 4/8] Move make_gdb_type functions within file Alan Hayward
2018-01-24 9:29 ` [PATCH v2 5/8] Use tdesc types in gdbserver tdesc Alan Hayward
2018-01-25 13:13 ` Philipp Rudo
2018-01-29 7:28 ` Omair Javaid
2018-01-29 11:01 ` Alan Hayward
[not found] ` <20180129123042.4a1674d6@ThinkPad>
2018-01-29 15:52 ` Alan Hayward
2018-01-24 9:30 ` [PATCH v2 6/8] Create xml from target descriptions Alan Hayward
2018-01-25 13:14 ` Philipp Rudo
2018-01-25 15:45 ` Yao Qi
2018-01-25 16:13 ` Alan Hayward
2018-01-25 16:56 ` Philipp Rudo
2018-01-24 9:31 ` [PATCH v2 7/8]: Remove xml file references " Alan Hayward
2018-01-24 9:32 ` [PATCH v2 8/8] Remove xml files from gdbserver Alan Hayward
2018-01-24 10:57 ` [PATCH v2 0/8] Remove XML " Omair Javaid
2018-01-24 12:29 ` Alan Hayward
[not found] ` <CANW4E-30Q5zRPrA0Vqe648f4psPqPMUCmSADYRjTK292kZy_Ng@mail.gmail.com>
2018-01-24 18:53 ` Alan Hayward
2018-01-25 13:11 ` Philipp Rudo
2018-01-26 22:31 ` Omair Javaid
2018-01-29 16:28 ` Yao Qi
2018-01-29 17:13 ` Alan Hayward
2018-01-31 11:28 ` Alan Hayward
2018-01-29 18:18 ` Pedro Alves
2018-01-30 12:16 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C97CC6A-92CB-4702-820D-206022F07102@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox