From: Tristan Gingold <gingold@adacore.com>
To: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] windows: do not crash if inferior
Date: Tue, 26 Jan 2010 15:59:00 -0000 [thread overview]
Message-ID: <7C5E774B-D5A8-4020-B491-CF8B34117882@adacore.com> (raw)
In-Reply-To: <20100121175659.GA1625@ednor.casa.cgf.cx>
On Jan 21, 2010, at 6:56 PM, Christopher Faylor wrote:
> On Wed, Jan 20, 2010 at 07:12:12PM +0000, Pedro Alves wrote:
>> On Wednesday 20 January 2010 17:37:46, Christopher Faylor wrote:
>>
>>> Actually, how about something like this instead? I used the same wording as fork-child.c
>>> after seeing Pedro's note.
>>
>>> + if (!windows_initialization_done)
>>> + error (_("During startup program exited with code 0x%x."), (unsigned int) current_event.u.ExitProcess.dwExitCode);
>>
>> I think you should call target_mourn_inferior before
>> throwing, to unpush the target_ops, clear inferior_ptid
>> and delete any thread the OS had already reported, and
>> maybe other things. You'll also want to call
>> target_terminal_ours.
>
> Yes, that should have been obvious to me since I was trying to duplicate
> fork-child.c and it does exactly what you suggested. So the new patch
> is below.
>
> I don't have an easy way to test this. Can the OP confirm/deny that this
> works as intended?
Yes, this works as intended.
Tristan.
next prev parent reply other threads:[~2010-01-26 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 9:25 Tristan Gingold
2010-01-19 9:22 ` Joel Brobecker
2010-01-20 16:16 ` Christopher Faylor
2010-01-20 16:35 ` Pedro Alves
2010-01-20 17:38 ` Christopher Faylor
2010-01-20 18:57 ` Christopher Faylor
2010-01-20 19:12 ` Pedro Alves
2010-01-21 17:57 ` Christopher Faylor
2010-01-26 15:59 ` Tristan Gingold [this message]
2010-01-28 14:55 ` Christopher Faylor
2010-01-20 16:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C5E774B-D5A8-4020-B491-CF8B34117882@adacore.com \
--to=gingold@adacore.com \
--cc=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox