From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by sourceware.org (Postfix) with ESMTPS id 3BA4D385783C for ; Mon, 7 Sep 2020 05:27:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BA4D385783C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=saagarjha.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=saagarjha28@gmail.com Received: by mail-pg1-f193.google.com with SMTP id m8so2200856pgi.3 for ; Sun, 06 Sep 2020 22:27:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TfmpbOnmSU4lUECac6mwJjl2J8WzpBjoThP0kaDgiOY=; b=DU8mB1EPRdEEkJNK8WHGWdap0XG11LiQ9ivH/8XczCBacDr+P/Swr3Od61KFWNOBzH G9EeTBfPCUsaSzY245iJ9nO/pRniH9fy5FeO2YhGX6ByfnBJlxKNnvvSWZgbbklnSAby ogwAtpPsI7T376oy2qqpMEvq/5nF2JMTTJkXE6bZ7YJ6M1gFLY65DphEm/iAxSUV9Vlo O5G+hiR20AOwkX4vroOVOrUTJfQgM+Cc9sseDXZH47BniO5O6C5YnfgUH0xolioEDJEb c5JhPc65snk8a07N4Rntcvc95Thx+CtEJrgVvU/ylXOwFM7LEeV2X6rntaAl6nVxXa66 qG+w== X-Gm-Message-State: AOAM533DblOgNsq5WHxO/kkF3k+1Qa6ER77+rTFf9+7dmYaqoPMyL0jx nGkj0xptiXM3W5o8gaAwAVE= X-Google-Smtp-Source: ABdhPJzjQnZF0L0slrj3ZfZCmggQEjb+CSqd54+zHBx/QAWza1CDWPf9gxbnJSOjqgiGZKueD6qFkA== X-Received: by 2002:a62:1483:: with SMTP id 125mr19147098pfu.186.1599456451287; Sun, 06 Sep 2020 22:27:31 -0700 (PDT) Received: from localhost.localdomain (c-73-92-124-25.hsd1.ca.comcast.net. [73.92.124.25]) by smtp.gmail.com with ESMTPSA id s198sm11079571pgc.4.2020.09.06.22.27.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Sep 2020 22:27:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.0.3.2.26\)) Subject: Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c} From: Saagar Jha In-Reply-To: <20200906195321.598e166c@f32-m1.lan> Date: Sun, 6 Sep 2020 22:27:29 -0700 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <7B84453A-73B3-4A9D-AD61-04EAF635F566@saagarjha.com> References: <20200906195321.598e166c@f32-m1.lan> To: Kevin Buettner X-Mailer: Apple Mail (2.3654.0.3.2.26) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 05:27:33 -0000 Ok, so I was tinkering around with Travis some more (trying to fix other = thing, which happened to be spurious) and got an email that the build = passed; it turns out that Apple shipped that header for just a couple = weeks until LLVM realized that this would break things: = https://github.com/llvm/llvm-project/commit/19bc9ea480b60b607a3e303f20c7a3= a2ea553369. Since they=E2=80=99ve rolled that out for now and Apple has = pulled that into Xcode the build is green again on macOS, so there=E2=80=99= s no need for this patch anymore. Travis should email me if the build = breaks again, so hopefully the build gets fixed quicker now that it=E2=80=99= s checked more often than me me taking a weekend looking at getting GDB = working again, making some progress, then putting it down again :P For completeness=E2=80=99s sake, here=E2=80=99s a sample error from the = build: In file included from common-debug.cc:20: In file included from ./common-defs.h:123: In file included from ./ptid.h:35: In file included from = /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xc= toolchain/usr/bin/../include/c++/v1/functional:512: In file included from ./../gdb/Block.h:23: In file included from ./../gdb/dictionary.h:26: In file included from ./../gdb/symfile.h:24: In file included from ./../gdb/symtab.h:23: In file included from = /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xc= toolchain/usr/bin/../include/c++/v1/array:111: = /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xc= toolchain/usr/bin/../include/c++/v1/algorithm:1503:81: error: expected = '(' for function-style cast or type construction return _VSTD::__search::type> = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ = /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xc= toolchain/usr/bin/../include/c++/v1/algorithm:1503:19: error: no member = named '__search' in namespace 'std::__1' return _VSTD::__search::type> ~~~~~~~^ You can see it go off the rails when includes GDB=E2=80=99s = block.h instead of the system=E2=80=99s Block.h. > On Sep 6, 2020, at 19:53, Kevin Buettner wrote: >=20 > On Sun, 6 Sep 2020 18:47:33 -0700 > Saagar Jha wrote: >=20 >> macOS, by default, uses a case-insensitive filesystem and ships with = a >> header in its SDK (as part of Xcode) at /usr/include/Block.h. >> from Xcode 12's SDK for macOS 11 includes this file but >> due to GDB's compilation flags ends up including gdb/block.h. The >> simplest solution to fix the resulting build errors is to just rename = it >> to something that doesn't conflict. >=20 > As you may have gathered in my reply to Simon, I'm not (yet) in favor > of your renaming changes, but I would like to understand it better.=20 > Could you provide additional details about where things go wrong? > I.e. please show the error messages and code snippets from the > relevant header files... >=20 > Thanks, >=20 > Kevin >=20