Re: [patch] Set calling convention of methods

Tom Tromey
2009-09-30T16:47:28Z

>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:

>> diff --git a/include/elf/dwarf2.h b/include/elf/dwarf2.h
>>> index a7448dc..efa786e 100644
>>> --- a/include/elf/dwarf2.h
>>> +++ b/include/elf/dwarf2.h
>>> @@ -662,7 +662,8 @@ enum dwarf_calling_convention
>>> DW_CC_normal = 0x1,
>>> DW_CC_program = 0x2,
>>> DW_CC_nocall = 0x3,
>>> - DW_CC_GNU_renesas_sh = 0x40
>>> + DW_CC_GNU_renesas_sh = 0x40,
>>> + DW_CC_GNU_borland_fastcall_i386 = 0x41

I am on a mission to ensure that all GNU extensions to DWARF are nicely
documented. So, at the very least, this needs a comment explaining the
meaning of this flag; maybe mentioning the `fastcall' attribute in GCC
(if indeed this is the same thing).

Jonas> Later on, Tom clarified that he thought that the gdb and gcc versions
Jonas> of dwarf2.h should actually be merged into a single copy, but that I
Jonas> shouldn't worry about this since the divergence started before my
Jonas> patch: http://sourceware.org/ml/gdb-patches/2009-04/msg00099.html

I've merged these now.

I think the usual approach for such merged files is that GCC is the
master copy.

Tom