From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15137 invoked by alias); 20 Apr 2009 08:40:05 -0000 Received: (qmail 15120 invoked by uid 22791); 20 Apr 2009 08:40:03 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from ugmailsa.ugent.be (HELO ugmailsa.ugent.be) (157.193.49.116) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 08:39:57 +0000 Received: from localhost (localhost [127.0.0.1]) by ugmailsa.ugent.be (Postfix) with ESMTP id B57CF306A79 for ; Mon, 20 Apr 2009 10:39:53 +0200 (CEST) Received: from ugmailsa.ugent.be ([127.0.0.1]) by localhost (ugmailsa.ugent.be [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vjpRB+-It5am for ; Mon, 20 Apr 2009 10:39:53 +0200 (CEST) Received: from cedar.ugent.be (cedar.ugent.be [157.193.49.14]) by ugmailsa.ugent.be (Postfix) with ESMTP id 132FD3068AD for ; Mon, 20 Apr 2009 10:39:52 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAPvR60mdwc4w/2dsb2JhbADNc4N9Bg Received: from mail.elis.ugent.be ([157.193.206.48]) by relays9.ugent.be with ESMTP; 20 Apr 2009 10:39:29 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.elis.UGent.be (Postfix) with ESMTP id DB6282BAD99; Mon, 20 Apr 2009 10:39:22 +0200 (CEST) Received: from bigmac.elis.UGent.be (bigmac.elis.UGent.be [157.193.206.33]) by mail.elis.UGent.be (Postfix) with ESMTP id CE57C2BAD2A; Mon, 20 Apr 2009 10:39:22 +0200 (CEST) Cc: gdb-patches ml Message-Id: <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> From: Jonas Maebe To: Tom Tromey In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [patch] Set calling convention of methods Date: Mon, 20 Apr 2009 08:40:00 -0000 References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00507.txt.bz2 Sorry for the late reply, I was on holidays. On 10 Apr 2009, at 19:32, Tom Tromey wrote: >>>>>> "Jonas" == Jonas Maebe writes: > > Jonas> In attachment is my patch to set the calling convention for > methods. > > Do you have a copyright assignment on file? Not yet. I'm in the final stage of getting the waiver from my employer to send it to FSF though. > Jonas> Since the calling convention cannot be defined using stabs, > I've > Jonas> hardcoded "0" there (which means that nothing changes > compared to the > Jonas> past). Maybe that should rather be some constant? If so, > where should > Jonas> it be defined? > > Yeah, this is a bit gross. AFAICT the calling convention field only > takes values from dwarf. So, I suppose the question is how you plan > to use this information in later patches. If you check the calling > convention in general code then I suppose we will need some generic > set of values here. It is already used in general code (well, in non-DWARF-specific code), see the use of DW_CC_GNU_renesas_sh in sh-tdep.c > Other than this issue, this looks reasonable to me. Thanks. Jonas