Re: Change "set history size" back to signed (Re: [committed]: [PATCH 1/3] var_integer -> var_uinteger)

Yao Qi
2013-03-27T02:14:49Z

On 03/27/2013 12:16 AM, Pedro Alves wrote:
> Anyway, I care more about the exported user interface than
> the implementation. If we're staying with unsigned,
> then let's rename the variable to at least make it more
> obvious that this variable is not one of GNU history's
> public variables.
>

Indeed.

@@ -1381,19 +1384,9 @@ show_commands (char *args, int from_tty)

/* The first command in the history which doesn't exist (i.e. one more
than the number of the last command). Relative to history_base. */
- unsigned int hist_len;
+ int hist_len = history_length;

Probably, we can replace local variable 'hist_len' with 'history_length'
in function show_commands. Anyway, the patch looks pretty good.

--
Yao (é½å°§)