From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KP1QOW3CK2Zj5TwAWB0awg (envelope-from ) for ; Fri, 26 Apr 2024 11:04:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d1cNhxDV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E52FC1E0D2; Fri, 26 Apr 2024 11:04:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C89181E0C0 for ; Fri, 26 Apr 2024 11:04:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44BBC384AB79 for ; Fri, 26 Apr 2024 15:04:11 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 356203858416 for ; Fri, 26 Apr 2024 15:02:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 356203858416 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 356203858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714143749; cv=none; b=ay9Yt9nNnEw3tk6rCgiJeeJSoPj3xXroofDRuTtu6RxiEOP06AviVxsUM0h2j2cZz8hAG8aIE5sGfwF5v2riH37n2jhMQu4zx0fkeTsBuKAwLyV0T3qOILWMJNhZASpYzob94ZPL6NsMxraKIoDjRah1Dc3l3EV8kaWJBlrxNS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714143749; c=relaxed/simple; bh=LVChTPs2mlXJ+9DSy2NHZ3IofYVJl3nKW6RWqyXy5sU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=mlk/74Zoqq+DMBfBksFmQbZmobHTcQyM75O3ac0GwWKUeifdbjo/vmAytQi3JK7sKCyBlNjMqim9PE1jz5cdaBkAXIczDpTidLvEi7dFnjo0mT1G6ehIXDb6hgxEu24K4elGrje9CaEzCWjfjnPKexFUzgbvozdfey/1ui2Kvbk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714143745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGXK8MNHbksShJw2aRkkwQP1sNkoss8ecPxgHYoGUOk=; b=d1cNhxDVFR6XobY8KAO5QmHcg6xEHs+byb+H07irlcr/CAV7d2BnNGizwsAmd1qWlUkJ4h tEgRd/I/tiRdvaEvsG7JohXlcnAHlf3XYKMZ16+b5x3+KhrIEzXrhtgTmMRWA0SHJiUID9 P5A/DA7jJa1Spvsv6j8ZRz0SK3DNBHE= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-M6L4Ib5lPdKveppe_WOZgg-1; Fri, 26 Apr 2024 11:02:24 -0400 X-MC-Unique: M6L4Ib5lPdKveppe_WOZgg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d855c0362bso18139181fa.3 for ; Fri, 26 Apr 2024 08:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714143742; x=1714748542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGXK8MNHbksShJw2aRkkwQP1sNkoss8ecPxgHYoGUOk=; b=rz6fduIUga8rHS4jg+I7SSs/ams+1Mo/L2pOkzAsuCyMf2gbn1YlZ9E0t8Pfd5SXet 8/qM4tp472U9xlXpgzmkcroUgur73RGgOuvCsdvIXNqho+4uzVE4dZPsG7zlEaGKbexj FboWsjVWMiYBFFRlueCFwxNS7oPToICZAB/o6WBSpBIVpyFKcUVl12k2MXRJ+v/OjY0B kMk/nc3cvNzfhyQTwsAzFxaz2TJiC8azakF8Orfyk9lxl9OcIktfvQKIlGA7Om8eRBXa Y6Tak5SZaDBFHM8wKAa40oPyUUWZlcDFbBewYlUwVAlWexgpv/0Z4ej3U6UjwUh0xoNN QO7w== X-Gm-Message-State: AOJu0YxnMELcBm4+HkHZeWFZunXeRAc2JE7lfWTWnWUoVA3saxGOdq7w sHeSEFTTG6I6T1cmEAi7Ufyn+legChP5MS/93/hvSXv/TUS3uXNpphsiIuc4NkFxlxs8iILuy5G tedLu/cnHDH0OWVqSBxgfGYgOZA8Yf9qtp9rSST4XrvukNvRcRV5a8y9GP+g6R1TWwtL70Rh6vS IbDiPzRpbrTwZHpu5wfnPhbE9IsDuOYXe+JDpW4g/s4bo= X-Received: by 2002:a2e:a99e:0:b0:2db:817d:2f1f with SMTP id x30-20020a2ea99e000000b002db817d2f1fmr2199874ljq.1.1714143742406; Fri, 26 Apr 2024 08:02:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHF71y7X720rwUM35jKergoV865y1tztH47EnGcOjFnWU3YnBRzf+Af/vdcbt5HFikbo2Ly0A== X-Received: by 2002:a2e:a99e:0:b0:2db:817d:2f1f with SMTP id x30-20020a2ea99e000000b002db817d2f1fmr2199828ljq.1.1714143741556; Fri, 26 Apr 2024 08:02:21 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c468600b0041563096e15sm35369689wmo.5.2024.04.26.08.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 08:02:20 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , felix.willgerodt@intel.com, John Baldwin Subject: [PATCHv5 08/11] gdb/arch: assert that X86_XSTATE_MPX is not set for x32 Date: Fri, 26 Apr 2024 16:01:52 +0100 Message-Id: <79e267edd3cdd68d87fef81d2a5fdf73b22b25be.1714143669.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org While rebasing this series past this commit: commit 4bb20a6244b7091a9a7a2ae35dfbd7e8db27550a Date: Wed Mar 20 04:13:18 2024 -0700 gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 I worried that there could be other paths that might result in an xcr0 value which has X86_XSTATE_MPX set in x32 mode. As everyone eventually calls amd64_create_target_description to build their target description, I figured we could assert in here that if X86_XSTATE_MPX is set then we should not be an x32 target, this will uncover any other bugs in this area. I'm not currently able to build/run any x32 binaries, so I have no way to test this, but the author of commit 4bb20a6244b7091 did test this series with that assert in place and didn't see any problems. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31511 --- gdb/arch/amd64.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c index cb9683c6931..94d55d72a4e 100644 --- a/gdb/arch/amd64.c +++ b/gdb/arch/amd64.c @@ -65,8 +65,12 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, if (xcr0 & X86_XSTATE_AVX) regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum); - if ((xcr0 & X86_XSTATE_MPX) && !is_x32) - regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum); + if (xcr0 & X86_XSTATE_MPX) + { + /* MPX is not available on x32. */ + gdb_assert (!is_x32); + regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum); + } if (xcr0 & X86_XSTATE_AVX512) regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum); -- 2.25.4