Re: [PATCH] Match demangled name in "skip"

[Simon Marchi <simark@simark.ca>]

On 2020-09-16 2:10 p.m., Tom Tromey wrote:
> PR gdb/26598 notes that, before commit bcfe6157ca28 ("Use the linkage
> name if it exists"), the "skip" command would match the demangled name
> of a symbol, but now only matches the linkage name.
>
> This patch fixes this regression.  I looked at all calls to
> function_name_is_marked_for_skip, and only one used the linkage name.
>
> gdb/ChangeLog
> 2020-09-16  Tom Tromey  <tromey@adacore.com>
>
> 	PR gdb/26598:
> 	* infrun.c (fill_in_stop_func): Use find_pc_partial_function_sym.
>
> gdb/testsuite/ChangeLog
> 2020-09-16  Tom Tromey  <tromey@adacore.com>
>
> 	PR gdb/26598:
> 	* gdb.base/skipcxx.exp: New file.
> 	* gdb.base/skipcxx.cc: New file.

Thanks, that LGTM.

Since this changes stop_func_name from the mangled name to the demangled
name (like it was before your change?), I checked what else
stop_func_name was used for.  It is passed to
gdbarch_in_solib_return_trampoline.  Implementations use that name to
compare against hard-coded symbol names.  However, I would guess that
these symbol names are not prone to being mangled.  Otherwise, we'd need
to save both the demangled and linkage name.

Simon