From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3631 invoked by alias); 25 May 2018 16:07:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3621 invoked by uid 89); 25 May 2018 16:07:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 16:07:39 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C82C402290A; Fri, 25 May 2018 16:07:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5375215672D; Fri, 25 May 2018 16:07:37 +0000 (UTC) Subject: Re: [RFA] Use TRY/CATCH in remove_prev_frame To: Tom Tromey References: <20180525033628.25677-1-tom@tromey.com> <12d1f3f6-3d5b-6b0c-8cbc-7d3af668934e@redhat.com> <87d0xj234i.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <79a20552-8638-ea54-d046-072fc79bc45a@redhat.com> Date: Fri, 25 May 2018 16:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87d0xj234i.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00671.txt.bz2 On 05/25/2018 03:58 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> + CATCH (ex, RETURN_MASK_ERROR) > > Pedro> Use RETURN_MASK_ALL. > > I made this change but someone may want to audit the other uses of > TRY/CATCH in frame.c. They all use RETURN_MASK_ERROR. Or I could just > convert them all. The other uses are all correct. They want to handle specific types of exceptions, like: CATCH (ex, RETURN_MASK_ERROR) { if (ex.error == MEMORY_ERROR) CATCH (ex, RETURN_MASK_ERROR) { if (ex.error == NOT_AVAILABLE_ERROR) All other types of exception are rethrown. So it would be useless to use RETURN_MASK_ALL for those, because it would mean we would catch Ctrl-C just to rethrow it again immediately. Thanks, Pedro Alves