From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SYqcAtW3gGDXRwAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 19:40:05 -0400 Received: by simark.ca (Postfix, from userid 112) id 0238C1F104; Wed, 21 Apr 2021 19:40:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0DA021E783 for ; Wed, 21 Apr 2021 19:40:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5A343987C3B; Wed, 21 Apr 2021 23:40:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5A343987C3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619048403; bh=LwgENxFr6/KlerA6w3NSz2e/9Lbfr+w4Ufs0H24yGQc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WWaw6KoOUiloXVU3C7Ub4mwW0YvYHZW+z71Z/lHlan20gdcijJ1VwhQnTBoTzHlx/ diW6SBUQ6+KaY2y7PVyqY/KQMwNl6SlLCeisrYlse0vj2QoJJnj23yVAGaIpx1BvXe Aa9T13mRrwejLkyMHRXviSfMDObusKePWN94IgQQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 73DDB3857C74 for ; Wed, 21 Apr 2021 23:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 73DDB3857C74 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13LNds2x019709 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 21 Apr 2021 19:39:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13LNds2x019709 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EBF601E783 for ; Wed, 21 Apr 2021 19:39:53 -0400 (EDT) Subject: Re: [PATCH] sim: use -Werror when probing for supported warning flags To: gdb-patches@sourceware.org References: <20210421185110.2788705-1-simon.marchi@polymtl.ca> Message-ID: <79a06b96-8797-15b6-6626-b85efef07a6b@polymtl.ca> Date: Wed, 21 Apr 2021 19:39:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Apr 2021 23:39:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-21 6:38 p.m., Mike Frysinger wrote:> On 21 Apr 2021 17:04, Simon Marchi via Gdb-patches wrote: >> On 2021-04-21 4:44 p.m., Mike Frysinger wrote: >>> On 21 Apr 2021 14:51, Simon Marchi via Gdb-patches wrote: >>>> When building with clang, we get: >>>> >>>> error: unknown warning option '-Wmissing-parameter-type' [-Werror,-Wunknown-warning-option] >>>> >>>> This is because clang only warns by default when encountering an unknown >>>> warning option, and the probe for supported warning flags is done >>>> without -Werror. All flags are therefore accepted by configure, but >>>> then it breaks when actually compiling a source file with -Werror. >>>> >>>> This is equivalent to this commit in gdb: >>>> >>>> 3e019bdc20eb81b91ab5bc774386201b874c0bac >>>> gdb: Use -Werror when checking for (un)supported warning flags >>>> >>>> We then see some other compilation errors when building with clang and >>>> -Werror, they can be dealt with later. >>>> >>>> sim/ChangeLog: >>>> >>>> * m4/sim_ac_option_warnings.m4 (SIM_AC_OPTION_WARNINGS): >>>> Use -Werror when probing for supported warning flags. >>> >>> so this one file/line looks fine >>> >>> but the regen looks a little out of whack. when i apply your patch and >>> regenerate everything, i don't have any aclocal.m4 changes. why do you ? >>> are you running the tools manually and with a diff -I order ? >> >> I run `autoreconf -vf` inside sim/, using binaries compiled from >> upstream (not my distro's versions). > > if i use that, a ton more gets thrashed & imported from the OS :/ Ok, and all your tools (well, just autoconf in this case) are also compiled from source, using the upstream releases? You are running it from sim/ and not from the top-level directory? > do we have guidelines for how devs are supposed to do this ? i've been > running the individual tools, but i want to make sure we aren't constantly > stepping on each other. Yes, if we can document it or even have a script that does the right thing it would be nice. This is one of those things that were never explained to me, how to re-generate those files, that's why I converged towards using autoreconf. So far it worked well for the other projects in the tree (I don't get a different result than what is checked in). Simon