From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39278 invoked by alias); 12 Oct 2017 15:37:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39245 invoked by uid 89); 12 Oct 2017 15:37:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=figuring, wonders, HX-AuditID:sk:c1b4fb2 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 15:37:11 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id AB.2A.09869.42C8FD95; Thu, 12 Oct 2017 17:37:08 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 12 Oct 2017 17:37:08 +0200 Received: from [142.133.61.67] (192.75.88.130) by AMSPR07MB309.eurprd07.prod.outlook.com (2a01:111:e400:802f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 12 Oct 2017 15:37:05 +0000 Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c To: Simon Marchi , Tom Tromey CC: References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> From: Simon Marchi Message-ID: <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> Date: Thu, 12 Oct 2017 15:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR18CA0013.namprd18.prod.outlook.com (2603:10b6:404:121::23) To AMSPR07MB309.eurprd07.prod.outlook.com (2a01:111:e400:802f::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 657fc413-9865-41e9-a67a-08d5118717a9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AMSPR07MB309; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB309;3:CAQFZ+UJky+lORFz+bAxhsUvDdYWhB8xbfjQWTWH51H/TcENY0oz9nOZk6WSPDmGDAVL/a1Qs6kyw3oNfbyC1dTCmSPgR6K2B7yGrUnXKC/SYKNNSEoE+t0JXflCQgFeF38bm41LokjM4fFqcG98I7/utshTJDvCRNRJOQkc3oldi5QJDzD6vTqM2nSbKocNMmce3xQZU+pbGCJpVwOBSPf5bzZ590t7p++KoxsyAcT/GnS7pENsNH+6OzzMtCAe;25:oxdlR8rsKaIotFhYN4Xhkvqk68pnbT7YrcqNtI1AgVWP+BRJNWm80klx4MiRw/AN5kqaWhNdH1LlW1p3afZ0y9TegY8UtHi8AS1jtCEZOzEO06sZN5g6HUcMqbJrKfS8LE+Y4m74axppz2EY6QXlDmgR4LqGxWBwrG+yM6vMeoTpEBF8Hh3NRt0XMaMLdXZx8X95jVaGkbflEYnnFNwHxwfh25nod6ccwpMyNDpOxfhz6L6eZRzdQWAejJoilcvkmItLvyVPm2/IgMjWAi5qwDSJomSuzdIhhsdOT1GRbereCzpvryAhzu5/YRWnvOME8psTeLpJuZ5pR64XmtVua5Jmp4zb7r9qEIrfiVkI2uA=;31:mHumbbIyY9tmJEHdGTv7zhXCCbigRYZt4a70oZnPfTi6Hie5DaA/EtvZCTVbzD5HuyUj52lBaVKSLKWn1mH/EbVYqoiTWOmE6OTkbhbrzxIACmDXBTE9eMTdOBFkwHUmzCcSD+yZmo4LYAMLiKf2Vc6xVjKAszqAVgs69Wi+pbXxcXcrolODZcTZqB9J/sCbTrMgMe1PbM2iFU9/XmLRbyf4lU1YwDKdmDlZPE/+Bsc= X-MS-TrafficTypeDiagnostic: AMSPR07MB309: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB309;20:dIyW+qiJ+/F9z2XwD0OUK4lED7ckuWptoY3VsVRKGXmU08dHy0tIiPcq4qWlE0plGoCqOeIAW0fWTSLXCg3DB0b+y3Rh2Bb3WpV5oHuOcNS6xPJvLQzbcMyT8BsaYiOXxJ0+USTT4YMotit/Eg1md52xUgUkfu1XSZPLayTq7DyeHThFDSlMpW8mmwbnEf9/F/zX41o56R9wSa0nosWxFKYGOHrO8Fot97AWB45oAZorauR4mmBb2IYx9Q2hbWzqDJMpn+j0Bfh6oTHCu8+dOdHrGEOKFaWSypJXL4SLjMMoF3b1EMdi9QJOmKtMstjirvD+Nu2HeFGL7Ge6QXsCQrkUUIvOYVXGwJDXBE7PBLpwrh97FtTaWqrxiy17WqFNy9oLupM+prCzdnZcrW5pW6R7zsJG2uY/XYfwmcBTm/eR5a4OieEz9a0y0W+ACGQvT82w3OSTM8ZfoILr6FJ2ce697X9gxQOp24iec/HCRIghEru7K/WPNwkj8uDWfLUK;4:23a6Oh5O/YppkECE9juJhaOy2gPtaFoxaBAeWggTd5KhBX4pQpxkcEG3Nllbmu9pz9HrCXc3RPiuRVhBwk8grn7jJe/ldscxygUIA1YyC75luISZzsA/joFFdwMhTL9HYmCkyMquxMl0Lc1ViEf/wwFcmXzceqgQR2vbPSG+0CpNpAjIgns4x4ZtQCPJGfcauf86L+OZo3OLIp6UUydqFWCk04ck47c9WHlNx6ZvCmhYeRXTKco1TAHMtE3VyS6G X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB309;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB309; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(376002)(346002)(377454003)(377424004)(52314003)(24454002)(189002)(199003)(16576012)(229853002)(7736002)(65826007)(5660300001)(2870700001)(2906002)(36756003)(305945005)(189998001)(25786009)(86362001)(31696002)(97736004)(68736007)(31686004)(6486002)(316002)(50986999)(54356999)(76176999)(81166006)(47776003)(65956001)(66066001)(65806001)(106356001)(101416001)(83506001)(478600001)(49976008)(23676002)(33646002)(6666003)(58126008)(4326008)(53936002)(50466002)(64126003)(6116002)(3846002)(16526018)(110136005)(2950100002)(81156014)(8676002)(105586002)(53546010)(6246003)(8936002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB309;H:[142.133.61.67];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMDk7MjM6VXVreENWMFczQUZJMm1rTkU2c1l4TStMLzF1?= =?utf-8?B?a3djL3lCVzhhcVh1ZURubXNMLzdYK2tMZHN3SXR2cWVpTGZPeGpsZFBoRDNF?= =?utf-8?B?aTdNTDRyQlp5Y0pUSjd1a2NiQXJVWmZIUFgwVjIweHF2ZWlWNVBWZjBZWEZE?= =?utf-8?B?amUyZU0yOHp4ZmZGdGVsdXdqQmhRN3RXTjJFSU1GZU5CS3RZazBiTEVLcm9v?= =?utf-8?B?S3h1a3dyVnNSTVdONkI0QTZIUkIxTFlwRzZobCtyQVFYOGNRVlNpNG4vQlBu?= =?utf-8?B?WmttUzNtWE1iR2FGUG9zZjQ4dE9sclBzRElWWmFWSHJRRE1od3ZYVnA1cWY3?= =?utf-8?B?Q09iMFZ3TXpVMWxJNjI3eFBQYkM0TWk4V0w2RUJuYnl5Rko4ME9FczdoaXlE?= =?utf-8?B?dzhKTHpWY2ZSeDUwUVkvMFEvRk1VRmtST0JzcDhJT3RqOHFqNWhncWRHSWpO?= =?utf-8?B?emFObFVqbHVkMXJCYTgxQ2Y1RXlkVGI3Mi91NS96NHoyRndHSzR5elMrelpK?= =?utf-8?B?T0xzcDFCTk1NSUs3engzWURkbzhlMk93VlRtck80VGc0Y1JQa1ZuRDR3Titr?= =?utf-8?B?M0RSMnNYaGl2QnA4UnhxdHdOV2diYkJzTC9WV29FWVcvZnRBdUY3Y1U2OUNK?= =?utf-8?B?dXYwcFVsbXhpQllldTAyeVZkZjUrQkc1R3lzeHVzVFcxTk1ldm1RNUNrYmhB?= =?utf-8?B?SVJtcEtvaGdBbGJoWVI5L3gxUVl3QVpLN09PNXlBQnpoQlRBa3ZmMU4yUkhi?= =?utf-8?B?Q0lYa0tmTFRPaGJyMDBRdndObUQ4bS83NXMxNm1IYnZERWJVTlNpTmV6d2ky?= =?utf-8?B?S01zRmxWKzJTUy9YV0pRbjM5d2JIbXBmYTJ2by8yeXRPVzJTRUFLdHV4di9J?= =?utf-8?B?bVFmUDVua0dESTA4WGU3MEtabGNROVlxT0Y2dFFwTmFnb2JXWE5USS83OUVR?= =?utf-8?B?U2NkaUFDZDVGNklObXo4VHp0cGxRUURidW5ZaERHMTV2aVl4ZkwvTDhsbElj?= =?utf-8?B?cU14TjRiQ1BjeWRWWTdTdVcxaFp1NjhrTXNwcjdJZmJGMWdmOS9DNW9CM2Vv?= =?utf-8?B?Nk1MSjJEVWNSbUx2OVdoQWs4TTZQNUozdFNjR2NwM1VyRTRTVkFqOTY4ZkZu?= =?utf-8?B?NjF2TWh1S2lZMHg3UGszUjV1aGRJWHl5QVNUeGtYN0c3WjlMZ0NJRUdyNzR1?= =?utf-8?B?cDFNSGNGN1BwU2xqSjJqQzRLcFN2UHhFVVdZdGVlS2tUVlZrZ3lCVlhMNllE?= =?utf-8?B?cHhxa0ZGWUFMQXVYUXZ2NStJL0hGSW9mOGRlRGlwUFNDZld6SWZFSklWdVAz?= =?utf-8?B?ck43cDhIdVdNeDl5WlVOYjFpRUNvQUtHdmRaVDg0M3h1NFhlSnl6Wmt1ak10?= =?utf-8?B?OVcwOEN1VGt5eUlva3FNT1h0dWhrZHhvZnZUOWMvYUZSSHN3aFJRa2ZzZHVq?= =?utf-8?B?TFBrUWlocjhRSURKeTlxdHRCd0tLN25jcm9jSExrVDA0VGkwRzRzL3FCcWVX?= =?utf-8?B?RVFxQXhobmgwZ3gwYkVJbnU4QmdLaTVNR0lIREo4Wmh1U1M5QVRkUjlCR3VW?= =?utf-8?B?Z1BhUTlZa0MvZ3g0WkpzY2NtRzlXampxazVyYVRzdXhta2J4LzU0K1JGbXFu?= =?utf-8?B?SUpwWDNOR21WV1lsR2pnc0t0Y29LN0xPMkhldExnRFFDSjhPWTl0b0xMcm80?= =?utf-8?B?WHZ2QWhza2NwemI3eFVMRDlCSVN6SjFqRGhYRmlkRUYrdEtxQ0RVZTNwUEM5?= =?utf-8?B?RzZHOGRGNCtoWTZ3cVY3Tk1lUzVMQmdXTWY1cDBKQ3lGby9IaXQ1aHpXd0Rn?= =?utf-8?B?Zjk3REEzUDFGWFJXbSthTld0Tm9WdGpIbHB1VHpHTWtyT3FyeXFtSFVncGtr?= =?utf-8?B?aHZIVUlraUc4T1lUV2FUVHdkK21RdjJFRUQwbmR4UHRlM0YrY0VEM09vajVl?= =?utf-8?Q?QeCCTVwRm8f7wth8WMsvJm713sEGQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB309;6:u1VndNyuX2IrJhFhEb0np2m9l4G+AVIYgdykZYddcPXzNGFZY0M2e8SpA8FO6DDlMgsXe8BfKmXRnGeV2HaimBGSsbiJ8pzmeBO7eUZvgl5XYRAR6lFphUInB+juiU5gj7a3SfIjShLF7SS5kFapnlX9cEWq0IUrDG08NLz/pDij4itgzLqUoiVR00E/IMSln7nOL7nDRnB2sozTcD34fOiITFgMwJtYDCo1ZAMGvQ7IhlTp+EQeS8/DgnqTF4KlmMyNbJUnxBfjsfGXb5xfjEMQ4Z/xZbjImD5XRC+9EG8nsjlrGQzrfVbomOCfCGHIliR6zrC8JJ7NgXtGLECTWg==;5:iGaHnYUk+NxEjxuCgRNppHPTdACzFA2dAX2ppRnBU8NVievH2p4PRL5Co2PDl33ewaVA9ajpO0F6bbYV6n4dJxWnvWxiLAhK58P/OLcsIOdQ+Xct4ugvovyscijcxLUfdu6pKiwA2zyJhnvL3TmJ0xhA5XWS+Td8mlE7u22BbF8=;24:7R0RK/qfs0XkAcwRiWVs7GcRXYXD+9YDpj7szj4fcoXws+OQBw5b7UCh945gHqICzHilSDNPaM0w8NJzqCZStxByZtm4kcZi6+AKKNGGtPA=;7:TpPv2EkWfnD5EzCIGXDIBIVcAePaGJw07MjoI5AI8glorK+s/h4mwK8uDlfbpMiORQoRZp+hQZwRTuD2ggZdkFurwAv8gohngWP5QaHVd8/d3YIgW7hJi/DCFSGRiVBUDzfFTYebcbiyN3/mRdFH+2bbvOGG9rpI9tZNeBZCGiw0AKJWprvfZy9zioQK3m/N0YGqynTpp7wrL742DJhI5YzzSfm73CB/VH/BKvPZbGo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 15:37:05.2263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB309 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00311.txt.bz2 On 2017-09-09 02:35 PM, Simon Marchi wrote: > On 2017-09-09 17:35, Tom Tromey wrote: >> This changes one spot in disasm.c to use ui_out_emit_tuple.  This >> patch required a large reindentation, so I've separated it out. > > "git show -w" does wonders!  The hard part is figuring out if there's something else in this big function using cleanups (and therefore if the cleanup variable should be kept). > > Anyway, this LGTM. > > Simon > I found a regression, bisect pointed to this patch (which makes sense). 1. Run "disassemble /s" on a small enough terminal so that pagination kicks in. 2. Type q to quit pagination. I get: ---Type to continue, or q to quit---q /home/emaisin/src/binutils-gdb/gdb/ui-out.c:344: internal-error: void ui_out::pop_level(ui_out_type): Assertion `current_level ()->type () == type' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) Simon