From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1TMwLTPgmGcOOB0AWB0awg (envelope-from ) for ; Tue, 28 Jan 2025 08:48:35 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SZbP7pco; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A841D1E105; Tue, 28 Jan 2025 08:48:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0E24B1E08E for ; Tue, 28 Jan 2025 08:48:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D235385801B for ; Tue, 28 Jan 2025 13:48:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D235385801B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SZbP7pco Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 48621385828B for ; Tue, 28 Jan 2025 13:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48621385828B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48621385828B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738071930; cv=none; b=gT8PYL+ephZGVrNWZr7jOwlgZ1YjVlsTRkHTBU1FSQXEpLgtL54W1D57yl5iO2RFiTlLSeiOtlpioIDca7KtEXqmD1c48SXx7B2DNLWF6BqcBCVfMXaN7Wa7Z2BzKJYcQLLR9gotOXWC+4Ijk5V1eGvdxF+IrqZzCGdZt2RcwHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738071930; c=relaxed/simple; bh=zk4LGHOgNWVCJmiHAxQFw3WnVqmPGF3twdPjuNhw7Fs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JY1aBLvrlRkQAEc1ithfSMXpqQvqfXlaZHyTpwl7NCNUeB5KizKRTMsJw2KwKjyKNY+nsIQsRZTXMVP/vGWVnkx/3SLaqUi6bszTms/gcfoQSNPvZRhRBMzzKI44A6ufLPfYRatMsxPhrdM30km9pxAj5DCXLW737EXpqQa5QvM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48621385828B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738071928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CIhS6TJviW5OMV0wYzmBgPKs+YL6NB2/V3YMcjfHr74=; b=SZbP7pcocpDg5DopBWlhXiz9AFrOTUgpaGQv6s2h9XgGkLwDXd61EDhGtjX6wA3drhcW/p 5uVeLiACCLT4uhwBeb/Db7qgdKOja5sJ45WQjIcJh5hRECTQgv8MjgZuqYqEijRWpL0EoG hwtdig9w6NC7uR7IfDP+wqy8hYeRink= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-DQlm8Br0OMqLHlI0gyLJ3Q-1; Tue, 28 Jan 2025 08:45:27 -0500 X-MC-Unique: DQlm8Br0OMqLHlI0gyLJ3Q-1 X-Mimecast-MFC-AGG-ID: DQlm8Br0OMqLHlI0gyLJ3Q Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2f780a3d6e5so11469289a91.0 for ; Tue, 28 Jan 2025 05:45:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738071925; x=1738676725; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CIhS6TJviW5OMV0wYzmBgPKs+YL6NB2/V3YMcjfHr74=; b=QgXgHkxbb98+mL3xEUpKfGdB6uP18B2NB9CR0DHyz7u4YrEeq+z3cNrvR1xLxpw1Kb 6SykmUOXUE0uE9KtD8+kTc7khzYqg9VDKYGabgmNkSyX72OdiXX6hL/4yALN0Qi+cZmT BZzdjPcClIC2RY+7gW5+L9/1ANqmq3O9U8Sq9xTuzZmOCGmzKH4VmXg0hgpzlXrhyvXY eg+5uQWcJqATym4A32zTScf7vxY9ozVpdw2Bt4pSa5JXZrgF7+6XnlLKCGzqyQ7iBexT r6bX56FPdMU/57GHbUcHOu6YsJBYFHvywdf7/OrLAKzsKP8IEqXZ8bytMupFQ4tq6Z0o 2wLg== X-Forwarded-Encrypted: i=1; AJvYcCWF3MMmT3CSYq1zEXaryh2HzOjABkm5XcuC/fiALKhfD1TBlrBCWjXi89qlicBh2stN2YlqVCTOkXp9Yw==@sourceware.org X-Gm-Message-State: AOJu0YwaG1Zy3mn14yK/iSviHf1IXw5/mCDF3HjonsDVj3iR1cDJvcUp mKjnjEM5YV1Xj73XojdCW3oJE/RDxjxh/GvZCMEJWZoj5XxdOdX0SuUCsH1Mq/eoX7f8p7vmykp 1jk4Jp3q34kB2wC6SeIxK6XLWkI+6v8UnHm/Ps61Qr1HB4N0s+M+wEy5jBKuRd8YXRNU= X-Gm-Gg: ASbGncv+8nIQxGWxlSx7Zzzto1z6lrdS0knFBm8SicwP33k0a9JID5AV7BBJkf1bHwb VbXS/acw6eKVmSo3Q9Uu3DpxGiprZfaz54hiD5NAyIFJhki7by688ZYUciJOapTCaPy3p4W4XpB T7I4hpR/90hdrdMmpFvZUgYzAKUfKgtcxWHEgfGilkxhKk6+AzsUUKqOt/iW4+VkbuAvsRJz7ds Hn+XWkS1gag04CC09mliEeO9Anwnypu/jRA3g2XAFCPxRvJrmlcCfw8dZwz3iB/FAU1WkqnJgQP PMKZX5uACaoaTwl1 X-Received: by 2002:a05:6a20:3d82:b0:1e8:a374:ced7 with SMTP id adf61e73a8af0-1eb214ea4d9mr65175760637.23.1738071925632; Tue, 28 Jan 2025 05:45:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5pEm3hn/PtgKFHIqzeCFkb1nYtJM9LNupwHWaYkLMU2mzoD3suMnXes01Lv7bJlfUIJOFhA== X-Received: by 2002:a05:6a20:3d82:b0:1e8:a374:ced7 with SMTP id adf61e73a8af0-1eb214ea4d9mr65175733637.23.1738071925310; Tue, 28 Jan 2025 05:45:25 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a5784bcsm9239899b3a.0.2025.01.28.05.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 05:45:24 -0800 (PST) Message-ID: <798ec44e-0dc5-4dff-a26f-c8b331b981f6@redhat.com> Date: Tue, 28 Jan 2025 10:45:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] gdb, testsuite: Rename set_sanitizer_default to append_environment. To: "Schimpe, Christina" , gdb-patches@sourceware.org References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-2-christina.schimpe@intel.com> From: Guinevere Larsen In-Reply-To: <20241220200501.324191-2-christina.schimpe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: siYXoG70nNWbGXI7Muh9ty_MY65Aretvgl_RBX8_cX0_1738071926 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/20/24 5:04 PM, Schimpe, Christina wrote: > The procedure set_sanitizer_default has been used for the configuration > of ASAN specific environment variables. However, it is actually a > generic function. Rename it to append_environment so that its purpose > is more clear. I think this is a good change, but in that case we should also rename set_sanitizer_1 and set_sanitizer. I think the conversion should be: set_sanitizer -> append_environment set_sanitizer_1 -> append_environment_1 set_sanitizer_default -> append_environment_default Also, I can see that patch 12 (and maybe others) use the append_environment call. If the user had already set GLIBC_TUNABLES, the test wouldn't update the value if I understand the TCL code correctly. Is that the expected outcome? If not, I would suggest the alternative of renaming set_sanitizer_1 to append_environment, so that set_sanitizer* can continue to work as is, and you can manually set the environment variables in a more obvious way. -- Cheers, Guinevere Larsen She/Her/Hers > --- > gdb/testsuite/gdb.base/libsegfault.exp | 2 +- > gdb/testsuite/gdb.threads/attach-slow-waitpid.exp | 2 +- > gdb/testsuite/lib/gdb.exp | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/libsegfault.exp b/gdb/testsuite/gdb.base/libsegfault.exp > index 2c16fe8932a..fb62bdb8746 100644 > --- a/gdb/testsuite/gdb.base/libsegfault.exp > +++ b/gdb/testsuite/gdb.base/libsegfault.exp > @@ -42,7 +42,7 @@ proc gdb_spawn_with_ld_preload {lib cmdline_opts} { > # ASan runtime does not come first in initial library list; you should > # either link runtime to your application or manually preload it with > # LD_PRELOAD. > - set_sanitizer_default ASAN_OPTIONS verify_asan_link_order 0 > + append_environment ASAN_OPTIONS verify_asan_link_order 0 > > gdb_spawn_with_cmdline_opts $cmdline_opts > } > diff --git a/gdb/testsuite/gdb.threads/attach-slow-waitpid.exp b/gdb/testsuite/gdb.threads/attach-slow-waitpid.exp > index 28d70daad8c..abe8d434558 100644 > --- a/gdb/testsuite/gdb.threads/attach-slow-waitpid.exp > +++ b/gdb/testsuite/gdb.threads/attach-slow-waitpid.exp > @@ -83,7 +83,7 @@ proc gdb_spawn_with_ld_preload {lib} { > # ASan runtime does not come first in initial library list; you should > # either link runtime to your application or manually preload it with > # LD_PRELOAD. > - set_sanitizer_default ASAN_OPTIONS verify_asan_link_order 0 > + append_environment ASAN_OPTIONS verify_asan_link_order 0 > > gdb_start > } > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 7ee2043f0f8..a86f534528c 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -76,11 +76,11 @@ proc set_sanitizer { env_var var_id val } { > > # Add VAR_ID=VAL to ENV_VAR, unless ENV_VAR already contains a VAR_ID setting. > > -proc set_sanitizer_default { env_var var_id val } { > +proc append_environment { env_var var_id val } { > set_sanitizer_1 $env_var $var_id $val 1 > } > > -set_sanitizer_default TSAN_OPTIONS suppressions \ > +append_environment TSAN_OPTIONS suppressions \ > $srcdir/../tsan-suppressions.txt > > # When using ThreadSanitizer we may run into the case that a race is detected, > @@ -89,14 +89,14 @@ set_sanitizer_default TSAN_OPTIONS suppressions \ > # Try to prevent this by setting history_size to the maximum (7) by default. > # See also the ThreadSanitizer docs ( > # https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags ). > -set_sanitizer_default TSAN_OPTIONS history_size 7 > +append_environment TSAN_OPTIONS history_size 7 > > # If GDB is built with ASAN (and because there are leaks), it will output a > # leak report when exiting as well as exit with a non-zero (failure) status. > # This can affect tests that are sensitive to what GDB prints on stderr or its > # exit status. Add `detect_leaks=0` to the ASAN_OPTIONS environment variable > # (which will affect any spawned sub-process) to avoid this. > -set_sanitizer_default ASAN_OPTIONS detect_leaks 0 > +append_environment ASAN_OPTIONS detect_leaks 0 > > # List of procs to run in gdb_finish. > set gdb_finish_hooks [list]