Re: [PATCH][gdb] Fix warning in foreach_arch selftests

Simon Marchi via Gdb-patches
2022-06-02T17:44:35Z

On 6/2/22 11:44, Tom de Vries via Gdb-patches wrote:
> On 6/1/22 21:08, Simon Marchi wrote:
>> Hi Tom,
>>
>> This introduces some failures for me:
>>
>> Running selftest print_one_insn::A6.^M
>> Self test failed: Cannot access memory at address 0x0^M
>
> Hi Simon,
>
> sorry for not catching this, I forgot to test with --enable-targets=all, I'll try to fix the default in my build scripts.
>
> I've done a new version of the existing patch (so it applies once the old one is reverted).
>
> Mainly because I realized that there's an easier way to handle the osabi none setting:
> ...
> @@ -68,6 +68,7 @@ foreach_arch_test_generator (const std::string &name,
>            {
>              struct gdbarch_info info;
>              info.bfd_arch_info = bfd_scan_arch (arch);
> +            info.osabi = GDB_OSABI_NONE;
>              struct gdbarch *gdbarch = gdbarch_find_by_info (info);
>              SELF_CHECK (gdbarch != NULL);
>              function (gdbarch);
> ...
>
> Currently regression testing, but at least fixes the ARC regression.

It fixes the gdb.gdb/unittest.exp failure, but introduces:

FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x86-64: print sizeof (void*)
FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x86-64: print sizeof (long double)
FAIL: gdb.arch/amd64-osabi.exp: arch=i386:x64-32: print sizeof (long double)

Simon