From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CZ7oIV+FeWG7GAAAWB0awg (envelope-from ) for ; Wed, 27 Oct 2021 12:59:11 -0400 Received: by simark.ca (Postfix, from userid 112) id 7EA691F0C1; Wed, 27 Oct 2021 12:59:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9CEC61ECEB for ; Wed, 27 Oct 2021 12:59:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 129753858404 for ; Wed, 27 Oct 2021 16:59:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 129753858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635353949; bh=LLuX1jwXKP6XJ5Rclhri6TPt2aEJxEJYnftL6LMxGOk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HWp19OrsK6MniSwhtS7AVsJmHUqVlx9Ahg5s86WnceLqEBUVypmppzjz0zekzh7Gs okKlPRyVQTNYQmQ5pECoaZz1FlgcWeevZ6hA7uaYhUH4MZzCW+kSnerFi/RnJGqHZF H2d5odaL/bkXDVN6h0zr8tCwlxMQFlbF4cfI/WaU= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 205DF3858003 for ; Wed, 27 Oct 2021 16:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 205DF3858003 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5613A212C9; Wed, 27 Oct 2021 16:58:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3ADB614068; Wed, 27 Oct 2021 16:58:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d9gqDSuFeWEkDwAAMHmgww (envelope-from ); Wed, 27 Oct 2021 16:58:19 +0000 Subject: Re: [PATCH][gdb/testsuite] Fix port detection in gdb.debuginfod/fetch_src_and_symbols.exp To: Keith Seitz , gdb-patches@sourceware.org References: <20211027102405.GA6737@delia.home> <2730eb91-ede7-ea88-e9c9-709a69961e8e@redhat.com> Message-ID: <793515a0-25d4-2106-d94b-48a016385fb1@suse.de> Date: Wed, 27 Oct 2021 18:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <2730eb91-ede7-ea88-e9c9-709a69961e8e@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/27/21 5:35 PM, Keith Seitz wrote: > On 10/27/21 03:24, Tom de Vries wrote: >> Hi, >> >> On OBS I ran into this failure with test-case >> gdb.debuginfod/fetch_src_and_symbols.exp: >> ... >> Failed to listen for connections: Address already in use^M >> [Thu Oct 21 11:48:49 2021] (559/559): started http server on IPv6 >> port=8000^M >>    ... >> FAIL: gdb.debuginfod/fetch_src_and_symbols.exp: local_url: find port >> timeout >> ... >> >> The test-case is trying to start debuginfod on a port to see if it's >> available, and it handles either this message: >>    "started http server on IPv4 IPv6 port=$port" >> meaning success, or: >>    "failed to bind to port" >> meaning failure, in which case the debuginfod instance is killed, and >> we try >> the next port. >> >> The test-case only uses the v4 address 127.0.0.1, so fix this by: >> - accepting "started http server on IPv4 port=$port" >> - rejecting "started http server on IPv6 port=$port" >> >> Tested on x86_64-linux. >> >> Any comments? > > When IPv6 is detected, the test case could set a variable to > use ::1 instead of 127.0.0.1, Ack. > but that would merely test the > debuginfod client more than GDB itself, so I'd say this LGTM. > Agreed. > Thank you for addressing this! > Keith > Thanks for the review, committed. - Tom