From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E+neOX28Zml6+gEAWB0awg (envelope-from ) for ; Tue, 13 Jan 2026 16:43:25 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=NOJM3tKP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DC5F41E08D; Tue, 13 Jan 2026 16:43:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 00EE81E08D for ; Tue, 13 Jan 2026 16:43:24 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5983E4BA2E1C for ; Tue, 13 Jan 2026 21:43:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5983E4BA2E1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=NOJM3tKP Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id B12C74BA540B for ; Tue, 13 Jan 2026 21:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B12C74BA540B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B12C74BA540B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768340575; cv=none; b=saoL1ssnvnoN+l/SOX8ltLRDO0s98l9E6FcIXJDIlwGKVRDCT9xLBzltC83okjyxXyzxa2ivnsihsr39VTJvWJKTVFZs0kyl3xKArnMQx+nIdHRIe8Vp8Lv/iYkUj63HOxGOX+RlsxhBLTPkwG9C/byZ9nB4ufcClbUjDv1AC5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768340575; c=relaxed/simple; bh=W3PiEAaL91d/I8Ygq/F4afSCBSgoZpL3CY6/B08IigU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rtZ/takRcQmj8R962TZ2nAtn0dwRruhmMXsLdeOOxbN6YiF1wVOHZfjG4rOQvrzyBXswO5Ymp8uUylAYwe/jjf5m9GcA9iSbvk532jD9oQLUvI2b2p+XMTcN8nTB53AopCAydM3hVTOJqg/wS5Jax1muyRbg5E/kFLHAqLgfd+E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B12C74BA540B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1768340575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W3PiEAaL91d/I8Ygq/F4afSCBSgoZpL3CY6/B08IigU=; b=NOJM3tKPgjQTpYWxo7DtUux1DzGa3WLoreYTc+iEZAi4nrlhDvkfgAMjhuExUiAVwz8E00 5foQbaU4xPW2M9p3NdQX7/v9oAxnYBbbzvVxQhylOFH5wvte8/FVZ/70i2yQSvyc2RpfS0 s4GqrD28eBYNoSMfkx2Q2QrmevOzwMY= Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11020108.outbound.protection.outlook.com [52.101.85.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-ei_EbD78OZepn9_CSxgmhg-1; Tue, 13 Jan 2026 16:42:54 -0500 X-MC-Unique: ei_EbD78OZepn9_CSxgmhg-1 X-Mimecast-MFC-AGG-ID: ei_EbD78OZepn9_CSxgmhg_1768340572 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by IA0PR17MB6590.namprd17.prod.outlook.com (2603:10b6:208:404::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.5; Tue, 13 Jan 2026 21:42:51 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9520.003; Tue, 13 Jan 2026 21:42:51 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] gdb/jit: add function symbols to global block Thread-Topic: [PATCH v2] gdb/jit: add function symbols to global block Thread-Index: AQHcfzh8niUO4cBR/kGNjS69KMh1ibVQUr0UgABZ8YA= Date: Tue, 13 Jan 2026 21:42:51 +0000 Message-ID: <79227e4c024aad95b42c70022093c917ace6f6dd.camel@labware.com> References: <20260106181539.154125-1-jan.vrany@labware.com> <87a4yhjxgj.fsf@tromey.com> In-Reply-To: <87a4yhjxgj.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR17MB5365:EE_|IA0PR17MB6590:EE_ x-ms-office365-filtering-correlation-id: 7450445f-1d72-4999-4d0d-08de52ecb39d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?mwtk+LwCkooN91xy/neQpBnv2XXTc7AEBX1PBPp5UVPMx06rO0rpHUs5q?= =?iso-8859-15?Q?Crc2M16uevRvRzycsKRRmcRKRWXszBXhv9QlYHqfBVTxDPDi+rJvvkKqK?= =?iso-8859-15?Q?9T5ApqKm2VbTq2paJvCaw0rgMhtg04czpguZIpTij5eZ4cDpv69klbqZJ?= =?iso-8859-15?Q?Y53uJv/u+l2vEe61xgG/kAYw/ZEgp9r3bj3AUfu/P4vBNcAEo+FxngVDK?= =?iso-8859-15?Q?s3MRKRvqDRoF1X+CpS/qibB/uLjLdM6AlDqCFJqyJHclDAc9J0yE87atC?= =?iso-8859-15?Q?aavpCc2mRP4IsKn21jYipxlyClFDbYhOQUswdWrmb5PGC187TeXy6L3GN?= =?iso-8859-15?Q?EagTk6U90/GEALtJWBufMoIAOR25J+kBds1M/Z02Rzwt/Nf2SupOOj0GW?= =?iso-8859-15?Q?skA2MuY1HMQYb8Y4mqmVlvWDekgKXDTEDbowVsw3nfuBotqLB7EzyEG9b?= =?iso-8859-15?Q?2eqfdCrtQ4onFYN29p+ZsqJDMSzZshRUzvUsD5fp1N9Z9CQkJyGJRHTNO?= =?iso-8859-15?Q?HNKRcm7t0jXrrsm+jfNFnKT3gMqujqv9BT0+F2nuDVNT5FpHYnbn/X/m7?= =?iso-8859-15?Q?dQyfUDXu8I5xIW1Wzuq79d+c7SpaVgj/cuLAZG4CQiSikhsvd6apLRqcQ?= =?iso-8859-15?Q?uFwWUhxGQMaFqeGJy3hS4Rp+WjJ56z/q70dptaawiwVr2UI0LFYeAX+wk?= =?iso-8859-15?Q?DhncSEgQKBzPcJGAlx28i6JJxVBSeV7aFMOf5MXO+DhHAzJU5MWckF78t?= =?iso-8859-15?Q?U3574NLnbOvPtW03d6GmMOceXxe41WLA3rYC2YP+S+S68UAnId3VLdjQN?= =?iso-8859-15?Q?9kTEGlNuG1oqUxoGLcnil5FEqrzlrlvwSoR3uZUDrQsyg4wDbuR3h2TSa?= =?iso-8859-15?Q?tAk4kK1heq0VGjX9dVSB3DbPE3Piik7AtYZLJlWSMZiGbFSlfukHaM2LP?= =?iso-8859-15?Q?tY5n0GI2aCqbNgCZhsKXy41rxxZK+UrrfkIPsTfmkzJdjZnZi2qQGM4Ig?= =?iso-8859-15?Q?JrosJ67JaUMB54Wd2lx2d5uKoeeAFYZm76hVgA+ktkSbQf9iOPN6fo6pb?= =?iso-8859-15?Q?GAO4ciy9C1fHKDaD4SC0sOk6Pcuc7lmsKBGa734GgyRd286aBeSSbuSnC?= =?iso-8859-15?Q?CT+BP6AmZ7mDh5iVNFT7gjx1mZdcbTswDGzb9ZfjZDT1ylzl3boWCQI4d?= =?iso-8859-15?Q?396C4/FsxqZehirm23wd6z6192zXKXpKX1eBMmpTMgl0CzE2Jh1Ox3kxL?= =?iso-8859-15?Q?tkxlrlV7XuolbBFiMoI/NdU8sqqWZHOuRmRJn/EwFwXVD0ar4XEmJq//0?= =?iso-8859-15?Q?EM6GtC3mbGz6ahSSqYGnZ7zsh7fZZKJ8nKCA9vHLtZoJfyzAfIVO2dlUi?= =?iso-8859-15?Q?0x8b49K0RBlkhqCmzgQrTZHDs5GEdW21N8hMewisopmHgEqrP0JfJGxRT?= =?iso-8859-15?Q?aIJiXP7LWJvSg08rACXP41WYlTenAmGFt7q0W6gG4Mk5fIRkx3Cs41ud5?= =?iso-8859-15?Q?mjN87ocbFU8CvTbw4TUroHUUbZ2VJ7WfPecyDR5DCMu0IevSY/jv/7cZA?= =?iso-8859-15?Q?HXp2InVGIrRUtHbRZ9GTTad5C6b8waVSbIQLawYr08wbHBX09LPaW/?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?1C67oumqsk/G2yGCtxDOHZxOobpGxP47IlleJ0vEB8eDz6B8SHkTab6TX?= =?iso-8859-15?Q?Yd3EQBjp1mLr0ZG2U5bueIAn9/mUBCeLZvtU2TBIZcPiX9bhK9Is3sS0J?= =?iso-8859-15?Q?sJhzFzNzlztDRLHU7Q2MQd6THNwB9p4392by5InGg+NDlje62y18beLgV?= =?iso-8859-15?Q?lh+fEiBjHE2Ji8GGnwjVXOUGeKQxUhOxbsJ9XXFi8l6qR0D0Jldg1q385?= =?iso-8859-15?Q?bVTvmpJT8qPcjxkMikyzGQbQum6a+LdzK6hy59oXmqS/EvqLOeC5Q2lVS?= =?iso-8859-15?Q?Lh4B/tjPACzZwP/T+aSw3sXmzf5NkNrXmA0xp5IMJYmwLyNfCpxBp9XWC?= =?iso-8859-15?Q?Hz4Ku1mHRNYnWhUQAQjunPxcr9ykDqFpt1Bp9Gk5b68j66X+xGp3ui0Bp?= =?iso-8859-15?Q?4oJ4Q0ZAumzIQ4k6WtJFTZzHqcNVpPEVt3RPinaoKv1nFIZgIEDHw4PjW?= =?iso-8859-15?Q?0bP2IEjbHXRecy/Yjt3+aqw11Tkva+oI21n6yMGxmckhHDj9ydhW5PfwE?= =?iso-8859-15?Q?cN4PNsbXeQKoPe/AAZrw+wwZ3nYsc1kZ/vhcqQVLmEh+ZBQFceboaeqtv?= =?iso-8859-15?Q?g0hZYCkORWZjCxW9tVWOiHq9TngD5lGyWo/uW82tDHiQbK2HzJJY3uQO9?= =?iso-8859-15?Q?X8w4ZHzo5Oc6Sxqq9+dRPhuk+MeuBI//wvx3g/X6RTsbU5ayh1MyhgQPK?= =?iso-8859-15?Q?5aZgHe0NA1tYwJ1JhAYWcXQg5CxA0Eyt8PIMkpEDKjJOFYMN6+4f9jxsY?= =?iso-8859-15?Q?6wTDlyaXN/31PtKKSsMjF1/SSh9x2w2vysmdhzoucvmw2Zb6sA/uHdW9d?= =?iso-8859-15?Q?uY4XuVsb7JvgYQ7gHnwmXqGpBEjUhLxTWMvpjtL6DIz7ci6GrT6i8WKHv?= =?iso-8859-15?Q?fxdMvjMuDQQWUD8GHV4iA0ejMl5gKSk+IPjxKNfAyiis94RbxvRg/q/95?= =?iso-8859-15?Q?08Rxoa8EvdheJQet9SgRnnYKJYXWCH/Z4T2T6BCGlLU6nWgQKvfGxa+4/?= =?iso-8859-15?Q?MK2A0P+VrnH6iNJ3+Bg/e9P9kFhJoVezj2WBpswwGjYFO9w5MGBK47pCh?= =?iso-8859-15?Q?tvtEB4Ed0aGnuCwMnzCIJGuzHiq1CYkQ76FQZVzE1COv9o0FV+AxCEMiI?= =?iso-8859-15?Q?4Ck/YY4+jT0opoRXOdsD75k+iZ0pO+i9sQEXg+P47/KRQikIBI9NoziM6?= =?iso-8859-15?Q?/7uUXDFJus+qx7i0onKAE5fimMoborg779o/AhkyYGm/1PC7GHwQLiicM?= =?iso-8859-15?Q?BH3rfdaXtxY0D38XSnTIrdX0fQrriAXUFjgtopf4HBQbdBgIk34GUF1wU?= =?iso-8859-15?Q?iZdCscXRqX8hNG60yCWqjxBKFxentI1trwXOTyXWfeyf2Jea+1iSMPUa+?= =?iso-8859-15?Q?eVEq46IZ16jGecFED5X6cpD4bcVP5U9iy0NjhNtJUOTTwYmsluuC+qoI6?= =?iso-8859-15?Q?qImeciaqOU2wgwZdfgkvZKdI57D0naT9/23bp6Bc46FULEe1gd7pQm7w/?= =?iso-8859-15?Q?CumsyDMsHThNOUNr1ZpNjxLJ5TPK97JDKcVLKZLo2ZZ27KYh9/DNZkHUR?= =?iso-8859-15?Q?rti8DS7cS3EKrW1U9wGfveYRfC77j4FzGoRcuOZkfZxW40KpZbiNGkIsO?= =?iso-8859-15?Q?aTkaOpJ1r3UPnh0x3o/nmL6LPL79zNBJr3MEZrQuEISh4Zm/np5f1TSyQ?= =?iso-8859-15?Q?5FPwq9b2JnWMjEjGnOuujQIlBKCZoEYhJ8qmYxKKk1/i+RJQHNpaDyMU2?= =?iso-8859-15?Q?AeyfDOExq1LMk3DUhA5e77LOaIBbePFwvP25HunwddPDoJTNHwf4jt7FL?= =?iso-8859-15?Q?agGF2/6FN0kuDajiTTZ8CaWx+Asgaprq5O6Gir8g=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7450445f-1d72-4999-4d0d-08de52ecb39d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2026 21:42:51.2364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3QidqP93n0/gCgPHLYOAyi9dbYD+REGmB51b6Kte/9lhM0061njvzam6cn6qBFhjH/qpIbqECNprtZWwFTxyLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR17MB6590 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xuz9xYOe3Ij2seQMMlGvT4adqCF7y2B1Wklr6ur8Plk_1768340572 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 2026-01-13 at 09:20 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vrany writes: >=20 > Jan> +=09{ > Jan> +=09=A0 new_block =3D new (&objfile->objfile_obstack) global_block; > Jan> +=09=A0 new_block->set_multidict ( > Jan> +=09=A0=A0=A0 mdict_create_linear (&objfile->objfile_obstack, global= _symbols)); > Jan> +=09} > Jan>=A0=A0=A0=A0=A0=A0=A0 else > Jan> -=09new_block =3D new (&objfile->objfile_obstack) block; > Jan> +=09{ > Jan> +=09=A0 new_block =3D new (&objfile->objfile_obstack) block; > Jan> +=09=A0 new_block->set_multidict ( > Jan> +=09=A0=A0=A0 mdict_create_linear (&objfile->objfile_obstack, {})); > Jan> +=09} >=20 > Does anything ever get added to the static block? No (at the moment).=20 > If not then making a dictionary doesn't seem necessary? As the code stands now, I think it has to - the rest of code expects it is always there. For example, blockvector::~blockvector() just unconditionally frees the dictionary. Or blpy_repr() that calls mdict_size(). >=20 > Also the formatting is wonky here, that "(" should not be at the end of > the line.=A0 (Two instances of this.) Sorry, will fix that. Jan >=20 > Kind of weird that this code doesn't use buildsym, but OTOH buildsym is > horrible. >=20 > Tom