From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71780 invoked by alias); 12 Jun 2019 09:01:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71772 invoked by uid 89); 12 Jun 2019 09:01:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_50,GIT_PATCH_2,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=outstanding, september, psp, PSP X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70042.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jun 2019 09:01:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DTzHjIjYA55U2ebYp4Z0bvjQhZS2M2gpwl+/pvzEZgg=; b=+LpmzwG6FAeS78hkLAsY2Zp4p3I9j2TlIleve1CN0pOxfo7AV2k+KTNzN+iDu1d7tyR3UWQ+AMLHnOYpXoGwoCnQ1NyXAcfWoW++wVPzHYVeN0MpoJyupduUOLderXT5/+o/0vxvF6k7RW32jaWHkbBvbjl8cHl2Uu3lgdION5M= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2566.eurprd08.prod.outlook.com (10.172.252.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.15; Wed, 12 Jun 2019 09:01:25 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1965.017; Wed, 12 Jun 2019 09:01:25 +0000 From: Alan Hayward To: James-Adam Renquinha Henri , Fredrik Hederstierna CC: Yao Qi , "gdb-patches\\@sourceware.org" , nd Subject: Re: [PATCH] Fix exception unwinding for ARM Cortex-M Date: Wed, 12 Jun 2019 09:01:00 -0000 Message-ID: <790E863F-88F4-47D7-A70A-FA22779ACC2A@arm.com> References: In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <5AF13F56A51D2F49AD1FD45171D96449@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Alan.Hayward@arm.com X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00223.txt.bz2 Tm90IG11Y2ggZGV2ZWxvcG1lbnQgaGFwcGVucyBvbiB0aGUgQXJtIHBvcnQg b2YgR0RCIHRoZXNlIGRheXMsIHNvIGdldHRpbmcgdW53aW5kaW5nIHN1cHBv cnQgaW4gd291bGQgYmUgdXNlZnVsIGFuZCBtdWNoIGFwcHJlY2lhdGVkLiAg SSBoYXZlIG9uIG15IGJhY2tsb2cgYSBwbGFuIHRvIHN3aXRjaCB0aGUgQXJt IHBvcnQgdG8gdGhlIG5ld2VyIHdheSBvZiBkb2luZyB0YXJnZXQgZGVzY3Jp cHRpb25zIC0gSSBzdXNwZWN0IHRoYXQgbWlnaHQgaGVscCB5b3VyIHBhdGNo ZXMuDQoNCknigJltIGhhcHB5IHRvIHRha2UgYSBsb29rIGF0IHdoYXQgeW91 IGhhZC4gVG8gc2F2ZSB0aW1lIGFuZCB0byBtYWtlIHRoaW5ncyBlYXNpZXIs IGZvciB0aGUgcmVtYWluaW5nIHBhdGNoZXMgdGhhdCBhcmUgc3RpbGwgb3V0 c3RhbmRpbmcgY291bGQgeW91IHBsZWFzZSBlaXRoZXIgcmVwb3N0IHRoZW0g b3IgcHJvdmlkZSBzb21lIGxpbmtzIHRvIHNvdXJjZXdhcmUub3JnL21sL2dk Yi1wYXRjaGVzLyB3aGVyZSB0aGV5IHdlcmUgcG9zdGVkLiBBbHNvLCBzbyBh cyBub3QgdG8ganVzdCByZXBlYXQgdGhlIG9yaWdpbmFsIGRpc2N1c3Npb25z LCB3aGF0IHdlcmUgdGhlIG91dHN0YW5kaW5nIG9iamVjdGlvbnMgd2l0aCB0 aGVtPw0KDQpBbGFuLg0KDQo+IE9uIDEwIEp1biAyMDE5LCBhdCAyMjoyNCwg SmFtZXMtQWRhbSBSZW5xdWluaGEgSGVucmkgPGFyZW5xdWluaGFAY2ltZXEu cWMuY2E+IHdyb3RlOg0KPiANCj4gSGkgZXZlcnlvbmUgaW4gdGhpcyB0aHJl YWQsIChub3QgbWFueSBhcyBJIHNlZSkNCj4gDQo+IFdlIGNvdWxkIHRha2Ug YW5vdGhlciBzaG90IGF0IGludGVncmF0aW5nIHNvbWUgY2hhbmdlcyB0byBH REIgc28gaXQgd29ya3MgY29ycmVjdGx5LCBidXQgdGhhdCBtYXkgb25seSBo YXBwZW4gaWYgdGhlcmUgYXJlIHRoZSBsZWFzdCBhbW91bnQgb2YgdXNlbGVz cyBiaWtlLXNoZWRkaW5nIGFuZCB0aGF0IHRoZSByaWdodCBwZW9wbGUgaW4g dGhlIG1haWxpbmcgbGlzdCBjb250cmlidXRlLg0KPiANCj4gQmFzaWNhbGx5 LCB3ZSBtdXN0IDEpIG1ha2UgKnZlcnkqIGNsZWFyIHRoZSBmYWN0IHRoYXQg Q29ydGV4LU0gZGV2aWNlcyBhcmUgdXNlZCB0eXBpY2FsbHkgaW4gYSBiYXJl LW1ldGFsIHN5c3RlbSB3aXRoIG5vIE9TIChyZWFkOiBMaW51eCkgd2hhdHNv ZXZlciwgb25seSBwb3NzaWJseSBhIHRpbnkgc2NoZWR1bGVyIGFuZCB0aGF0 J3MgYWxsLiBUaGF0IG1lYW5zIHdlIGRvbid0IGhhdmUgdG8gYmUgY29uY2Vy bmVkIGFib3V0ICJ1c2VyIHZpc2libGUiIHJlZ2lzdGVycyBhbmQgd2hhdG5v dCwgdGhleSBhcmUgYWxsIHZpc2libGUgYW55d2F5LCBhbmQgaWYgdGhlIHNw ZWMgc2F5cyB0aGF0IGEgcmVnaXN0ZXIgZXhpc3RzLCAqaXQgaXMgdmlzaWJs ZSosIHBlcmlvZC4gT3RoZXIgdGhpbmcgdGhvdWdoLCAyKSBteSBwYXRjaCBh Y2hpZXZlZCBpdHMgZ29hbCBpbiBhIHJhdGhlciB3ZWFzZWxseSB3YXksIGFu ZCB0aGUgY29ycmVjdCB3YXkgaXMgaW5kZWVkIHRvIGhhdmUgaXQgaW50ZWdy YXRlZCBpbnRvIHRhcmdldCBmZWF0dXJlcy4gQnV0IEkgbmVlZCBtb3JlIGlu Zm8gb24gdGhlIG1hdHRlciwgYW5kIEknbSBhIGJpdCBjbHVlbGVzcyBhYm91 dCB3aGF0IHRvIGRvIHdpdGggdGhvc2UgInRhcmdldCBmZWF0dXJlcyIsIGhv dyB0aGV5IGFyZSBoYW5kbGVkIGJ5IEdEQiBhbmQgaG93IEkgY2FuIHRlc3Qg dGhlIG5ldyBjb25maWd1cmF0aW9uIGluIGlzb2xhdGlvbiwgd2l0aG91dCBi ZWluZyAiYWx0ZXJlZCIgYnkgZS5nLiBPcGVuT0NELCB3aGljaCBoYW5kaWx5 IHByb3ZpZGVzIGEgdGFyZ2V0IGRlc2NyaXB0aW9uIHRoYXQgSSBjYW4gdXNl IGFzIEkgZGlkIGJlZm9yZS4NCj4gDQo+IEkgc3VyZSBjYW4gZmlndXJlIGl0 IG91dCBhbGwgYnkgbXlzZWxmLCBidXQgdGhhdCBtaWdodCBiZSBvbmx5IGFm dGVyIHBvdXJpbmcgYW4gcmF0aGVyIGJpZyBhbW91bnQgb2YgdGltZSBpbnRv IHRoZSBtYXR0ZXIgdGhhdCBJIGNhbm5vdCBhZmZvcmQgdG8gZG8gbm93LiBJ IG5lZWQgYWN0aXZlIGNvbGxhYm9yYXRpb24gYW5kIGFuc3dlcnMuDQo+IA0K PiBIZXJlLCBsZXQgdGhhdCBtZXNzYWdlIGJlIGluIHRoZSBtYWlsaW5nIGxp c3QgZm9yIGV2ZXJ5b25lIHRvIHNlZS4NCj4gDQo+IEphbWVzLUFkYW0gUmVu cXVpbmhhIEhlbnJpLCBJbmcuIGpyDQo+IEluZ8OpbmlldXIgZCdhcHBsaWNh dGlvbg0KPiBDSU1FUSBJTkMuDQo+IA0KPiANCj4gT24gMTktMDYtMDIgMDMg aCAzMSwgRnJlZHJpayBIZWRlcnN0aWVybmEgd3JvdGU6DQo+PiBIaSBZYW8s IEFkYW0sDQo+PiBTb21lIHllYXJzIGJhY2sgdGhlcmUgd2FzIGRvbmUgc29t ZSB3b3JrIGRvbmUgb24gdW53aW5kaW5nIG9uIENvcnRleC1NLg0KPj4gT25s eSB0aGUgdmVyeSBmaXJzdCBzdGFydCBvZiB0aGUgY2hhaW4gb2YgcGF0Y2hl cyB3YXMgY29tcGxldGVkIChuZXcgZnVuY3Rpb24gYXJtX21fcGNfaXNfbWFn aWMoKSkuDQo+PiBUaGUgYWN0dWFsIHJlYWwgcGF0Y2ggd29yayB3aXRoIGNv ZGUgd29yayBieSBtZS9BZGFtIGZvciBjb3J0ZXgtTTRGIE1TUC9QU1AgYW5k IHVud2luZGluZyBkaWQgbmV2ZXIgcmVhY2hlZCB0aGUgcmVwby4NCj4+IFdo YXQgZG8geW91IHRoaW5rIG9mIG1ha2luZyBhbm90aGVyIGF0dGVtcHQgdG8g Zml4IHRoZSBzdHVmZiwgSSBndWVzcyBhbGwgcGFwZXItd29yayBldGMgaXMg aW4gcGxhY2UsIHNvIHdlIGNhbiB0cnkgZG8gYSByZXRha2Ugb24gdGhpcz8N Cj4+IFRoYW5rcywgQmVzdCBSZWdhcmRzLCBGcmVkcmlrDQo+PiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4+ICpGcm9tOiogWWFvIFFpIDxxaXlh b2x0Y0BnbWFpbC5jb20+DQo+PiAqU2VudDoqIFR1ZXNkYXksIFNlcHRlbWJl ciAyNywgMjAxNiAzOjM4IEFNDQo+PiAqVG86KiBBZGFtIFJlbnF1aW5oYQ0K Pj4gKkNjOiogRnJlZHJpayBIZWRlcnN0aWVybmE7IGdkYi1wYXRjaGVzQHNv dXJjZXdhcmUub3JnDQo+PiAqU3ViamVjdDoqIFJlOiBbUEFUQ0hdIEZpeCBl eGNlcHRpb24gdW53aW5kaW5nIGZvciBBUk0gQ29ydGV4LU0NCj4+IE9uIE1v biwgU2VwIDI2LCAyMDE2IGF0IDM6MjYgUE0sIEFkYW0gUmVucXVpbmhhIDxh cmVucXVpbmhhQGNpbWVxLnFjLmNhPiB3cm90ZToNCj4+PiBUaGF0IGxvb2tz IGNvcnJlY3QuDQo+Pj4gDQo+PiBQYXRjaCBpcyBwdXNoZWQgaW50byBtYXN0 ZXIgYW5kIDcuMTIuICBUaGUgcmVzdCBvZiB5b3VyIG9yaWdpbmFsDQo+PiBw YXRjaCBpcyBzdGlsbCB3ZWxjb21lIQ0KPj4gLS0gDQo+PiBZYW8gKOm9kOWw pykNCg0K >From gdb-patches-return-156750-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jun 12 09:59:20 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 59883 invoked by alias); 12 Jun 2019 09:59:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 59874 invoked by uid 89); 12 Jun 2019 09:59:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=INFO X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30062.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.62) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jun 2019 09:59:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DrpEMVUaq+WniQjKuHOT7C6rCAs00oU3Me/fBBGpkw=; b=G2DQ21uugrtQde/c3Ho695ZpbCRcqBEugK719K14kle7rr9cGHBg+jEcumQMV4WpqfnXtz9RIfU4t/pCs636s6PcP3p6RaDJ2ljWv7dv7VQKs/VCWzZ2oe1X/XW91QV7iyGkKXEgMit0s+1+xdv9KPXCXnyicANTFEKID1jUhr8= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2247.eurprd08.prod.outlook.com (10.172.226.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Wed, 12 Jun 2019 09:59:15 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1965.017; Wed, 12 Jun 2019 09:59:15 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PATCH] Arm: Allow version strings in the triplet regexp Date: Wed, 12 Jun 2019 09:59:00 -0000 Message-ID: <20190612095912.86640-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Alan.Hayward@arm.com X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00224.txt.bz2 Content-length: 2485 T24gQXJtLCB0aGUgT1MgbWF5IHVzZSB0aGUgZnVsbCB2ZXJzaW9uIHN0cmlu ZyBmb3IgdGhlIGFyY2ggbmFtZSB3aGVuDQppbnN0YWxsaW5nIHRoZSBjb21w aWxlciwgZm9yIGV4YW1wbGUgYXJtdjdobC1yZWRoYXQtbGludXgtZ251ZWFi aS1nY2MuDQoNCkltcGxlbWVudCBnZGJhcmNoX2dudV90cmlwbGV0X3JlZ2V4 cCBmb3IgQXJtIHRvIGFsbG93IHRoaXMgdG8gYmUgZGV0ZWN0ZWQuDQpFbnN1 cmUgdGhhdCBvdGhlciBBcm0gdGFyZ2V0cyAoZWcgaXdtbXh0KSBhcmUgbm90 IGFmZmVjdGVkLg0KDQpUaGlzIGZpeGVzIHRoZSBjb21waWxlLyBzZXQgb2Yg dGVzdHMgb24gdGhvc2Ugc3lzdGVtcy4NCg0KZ2RiL0NoYW5nZUxvZzoNCg0K MjAxOS0wNi0xMiAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5j b20+DQoNCgkqIGFybS10ZGVwLmMgKGFybV9nbnVfdHJpcGxldF9yZWdleHAp OiBOZXcgZnVuY3Rpb24uDQoJKGFybV9nZGJhcmNoX2luaXQpOiBBZGQgYXJt X2dudV90cmlwbGV0X3JlZ2V4cC4NCi0tLQ0KIGdkYi9hcm0tdGRlcC5jIHwg MTQgKysrKysrKysrKysrKy0NCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvZ2RiL2Fy bS10ZGVwLmMgYi9nZGIvYXJtLXRkZXAuYw0KaW5kZXggNzQyYmZhNTcwNi4u MDlhOGI1MTg0OSAxMDA2NDQNCi0tLSBhL2dkYi9hcm0tdGRlcC5jDQorKysg Yi9nZGIvYXJtLXRkZXAuYw0KQEAgLTg4MzgsNyArODgzOCwxNyBAQCBhcm1f Y29kZV9vZl9mcmFtZV93cml0YWJsZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFy Y2gsIHN0cnVjdCBmcmFtZV9pbmZvICpmcmFtZSkNCiAgICAgcmV0dXJuIDE7 DQogfQ0KIA0KLQwNCisvKiBJbXBsZW1lbnQgZ2RiYXJjaF9nbnVfdHJpcGxl dF9yZWdleHAuICBJZiB0aGUgYXJjaCBuYW1lIGlzIGFybSB0aGVuIGFsbG93 IGl0DQorICAgdG8gYmUgcG9zdGZpeGVkIGJ5IGEgdmVyc2lvbiAoZWcgYXJt djdobCkuICAqLw0KKw0KK3N0YXRpYyBjb25zdCBjaGFyICoNCithcm1fZ251 X3RyaXBsZXRfcmVnZXhwIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCkNCit7 DQorICBpZiAoc3RyY21wIChnZGJhcmNoX2JmZF9hcmNoX2luZm8gKGdkYmFy Y2gpLT5hcmNoX25hbWUsICJhcm0iKSA9PSAwKQ0KKyAgICByZXR1cm4gImFy bSh2W14tIF0qKT8iOw0KKyAgcmV0dXJuIGdkYmFyY2hfYmZkX2FyY2hfaW5m byAoZ2RiYXJjaCktPmFyY2hfbmFtZTsNCit9DQorDQogLyogSW5pdGlhbGl6 ZSB0aGUgY3VycmVudCBhcmNoaXRlY3R1cmUgYmFzZWQgb24gSU5GTy4gIElm IHBvc3NpYmxlLA0KICAgIHJlLXVzZSBhbiBhcmNoaXRlY3R1cmUgZnJvbSBB UkNIRVMsIHdoaWNoIGlzIGEgbGlzdCBvZg0KICAgIGFyY2hpdGVjdHVyZXMg YWxyZWFkeSBjcmVhdGVkIGR1cmluZyB0aGlzIGRlYnVnZ2luZyBzZXNzaW9u Lg0KQEAgLTk0NDAsNiArOTQ1MCw4IEBAIGFybV9nZGJhcmNoX2luaXQgKHN0 cnVjdCBnZGJhcmNoX2luZm8gaW5mbywgc3RydWN0IGdkYmFyY2hfbGlzdCAq YXJjaGVzKQ0KICAgc2V0X2dkYmFyY2hfZGlzYXNzZW1ibGVyX29wdGlvbnMg KGdkYmFyY2gsICZhcm1fZGlzYXNzZW1ibGVyX29wdGlvbnMpOw0KICAgc2V0 X2dkYmFyY2hfdmFsaWRfZGlzYXNzZW1ibGVyX29wdGlvbnMgKGdkYmFyY2gs IGRpc2Fzc2VtYmxlcl9vcHRpb25zX2FybSAoKSk7DQogDQorICBzZXRfZ2Ri YXJjaF9nbnVfdHJpcGxldF9yZWdleHAgKGdkYmFyY2gsIGFybV9nbnVfdHJp cGxldF9yZWdleHApOw0KKw0KICAgcmV0dXJuIGdkYmFyY2g7DQogfQ0KIA0K LS0gDQoyLjIwLjEgKEFwcGxlIEdpdC0xMTcpDQoNCg== >From gdb-patches-return-156751-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jun 12 10:04:27 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 78721 invoked by alias); 12 Jun 2019 10:04:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 78713 invoked by uid 89); 12 Jun 2019 10:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=download, 16727, continuing, Continuing X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40069.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jun 2019 10:04:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FrCCKcSFhqRz28vrgTB5Iea8Sb5PfT1HTK0nh8qSx6A=; b=4B712N3nGLkysXBnEfgfBYfKCn7fQlZGQABqu1scSAIY3vgSN8dYXI1gRrO44KtoY62u6Dm+shtVoPHm5+M1cWv8N0T3gWfVYMmX+BgDVGzhOr8hPrCjokxKfiiLkgudADs7pD2Fakt7hOj2U2sp8Y/QkN9ZA0lsf9QTBX9b2xM= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2405.eurprd08.prod.outlook.com (10.172.250.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.15; Wed, 12 Jun 2019 10:04:21 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1965.017; Wed, 12 Jun 2019 10:04:21 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PING][PATCH] Fix breakpoints on file reloads for PIE binaries Date: Wed, 12 Jun 2019 10:04:00 -0000 Message-ID: <251580B0-F65A-4849-8792-9AEB404F813D@arm.com> References: <20190603125344.40595-1-alan.hayward@arm.com> In-Reply-To: <20190603125344.40595-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:8882; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: <374B6DAA1102F446932A9A2250723E08@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Alan.Hayward@arm.com X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00225.txt.bz2 Content-length: 5187 Quick ping on this. Thanks, Alan. > On 3 Jun 2019, at 13:53, Alan Hayward wrote: >=20 > When a binary is built using PIE, reloading the file will cause GDB to er= ror > on restart. For example: > gdb ./a.out > (gdb) break main > (gdb) run > (gdb) file ./a.out > (gdb) continue >=20 > Will cause GDB to error with: > Continuing. > Warning: > Cannot insert breakpoint 1. > Cannot access memory at address 0x9e0 > Command aborted. >=20 > This is due to the symbol offsets not being relocated after reloading the= file. >=20 > Fix is to ensure solib_create_inferior_hook is called, in the same manner= as > infrun.c:follow_exec(). >=20 > Expand the idempotent test to cover PIE scenarios. >=20 > gdb/ChangeLog: >=20 > 2019-06-03 Alan Hayward >=20 > * symfile.c (symbol_file_command): Call solib_create_inferior_hook. >=20 > gdb/testsuite/ChangeLog: >=20 > 2019-06-03 Alan Hayward >=20 > * gdb.base/break-idempotent.exp: Test both PIE and non PIE. > --- > gdb/symfile.c | 12 ++++ > gdb/testsuite/gdb.base/break-idempotent.exp | 72 ++++++++++++--------- > 2 files changed, 52 insertions(+), 32 deletions(-) >=20 > diff --git a/gdb/symfile.c b/gdb/symfile.c > index af99da18f7..0baed96e06 100644 > --- a/gdb/symfile.c > +++ b/gdb/symfile.c > @@ -1672,7 +1672,19 @@ symbol_file_command (const char *args, int from_tt= y) >=20 > validate_readnow_readnever (flags); >=20 > + /* Set SYMFILE_DEFER_BP_RESET because the proper displacement for = a PIE > + (Position Independent Executable) main symbol file will only be > + computed by the solib_create_inferior_hook below. Without it, > + breakpoint_re_set would fail to insert the breakpoints with the zero > + displacement. */ > + add_flags |=3D SYMFILE_DEFER_BP_RESET; > + > symbol_file_add_main_1 (name, add_flags, flags, offset); > + > + solib_create_inferior_hook (0); > + > + /* Now it's safe to re-add the breakpoints. */ > + breakpoint_re_set (); > } > } >=20 > diff --git a/gdb/testsuite/gdb.base/break-idempotent.exp b/gdb/testsuite/= gdb.base/break-idempotent.exp > index 902a5f818b..38e7cf4710 100644 > --- a/gdb/testsuite/gdb.base/break-idempotent.exp > +++ b/gdb/testsuite/gdb.base/break-idempotent.exp > @@ -36,23 +36,6 @@ >=20 > standard_testfile >=20 > -if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { > - return -1 > -} > - > -if ![runto_main] then { > - fail "can't run to main" > - return 0 > -} > - > -if [is_remote host] { > - set arg [remote_download host $binfile] > - if { $arg =3D=3D "" } { > - perror "download failed" > - return -1 > - } > -} > - > # Force a breakpoint re-set in GDB. Currently this is done by > # reloading symbols with the "file" command. >=20 > @@ -62,11 +45,11 @@ proc force_breakpoint_re_set {} { > set test "file \$binfile" > gdb_test_multiple "file $binfile" $test { > -re "Are you sure you want to change the file. .*y or n. $" { > - send_gdb "y\n" > + send_gdb "y\n" optional > exp_continue > } > -re "Load new symbol table from \".*\".*y or n. $" { > - send_gdb "y\n" > + send_gdb "y\n" optional > exp_continue > } > -re "Reading symbols from.*$gdb_prompt $" { > @@ -123,7 +106,7 @@ proc set_breakpoint { break_command } { > proc test_break { always_inserted break_command } { > set cmd [lindex [split "$break_command"] 0] >=20 > - with_test_prefix "always-inserted $always_inserted: $cmd" { > + with_test_prefix "$cmd" { > delete_breakpoints >=20 > if ![runto_main] then { > @@ -163,20 +146,45 @@ proc test_break { always_inserted break_command } { > } > } >=20 > -foreach always_inserted { "off" "on" } { > - test_break $always_inserted "break" > +foreach_with_prefix pie { "nopie" "pie" } { > + foreach_with_prefix always_inserted { "off" "on" } { >=20 > - if {![skip_hw_breakpoint_tests]} { > - test_break $always_inserted "hbreak" > - } > + set opts {debug} > + lappend opts $pie >=20 > - if {![skip_hw_watchpoint_tests]} { > - test_break $always_inserted "watch" > - } > + if {[prepare_for_testing "failed to prepare" $testfile $srcfile $opts]}= { > + return -1 > + } > + > + clean_restart $testfile > + > + if ![runto_main] then { > + fail "can't run to main" > + return 0 > + } > + > + if [is_remote host] { > + set arg [remote_download host $binfile] > + if { $arg =3D=3D "" } { > + perror "download failed" > + return -1 > + } > + } >=20 > - if {![skip_hw_watchpoint_access_tests] > - && ![skip_hw_watchpoint_multi_tests]} { > - test_break $always_inserted "rwatch" > - test_break $always_inserted "awatch" > + test_break $always_inserted "break" > + > + if {![skip_hw_breakpoint_tests]} { > + test_break $always_inserted "hbreak" > + } > + > + if {![skip_hw_watchpoint_tests]} { > + test_break $always_inserted "watch" > + } > + > + if {![skip_hw_watchpoint_access_tests] > + && ![skip_hw_watchpoint_multi_tests]} { > + test_break $always_inserted "rwatch" > + test_break $always_inserted "awatch" > + } > } > } > --=20 > 2.20.1 (Apple Git-117) >=20