From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yN1ZDhw2pGRX0xUAWB0awg (envelope-from ) for ; Tue, 04 Jul 2023 11:09:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mzp50snv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2E8DF1E0BE; Tue, 4 Jul 2023 11:09:16 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 218781E00F for ; Tue, 4 Jul 2023 11:09:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A397B3858C36 for ; Tue, 4 Jul 2023 15:09:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A397B3858C36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688483353; bh=YG5bgG5xz7wPUty+JGHhUzL0TZ+jRtrepRY+HZJNLos=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mzp50snvGjdR7NREMZy9U1CTRMdLgXlGn9BwCpwwaAoysi9sZZWtFmxaADhuhrAfg m4Xj02pmhY5aZ3JiMyZW9NfWVIQjDXbt/LzeCcHIbcSWdGLVP4GZY5OJ/yKjEG/2uM LXccm9MIL0jmxlGdJQMZKLo6QqdH3xGmHNfe4hc8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 477093858C36 for ; Tue, 4 Jul 2023 15:08:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 477093858C36 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-nrRpf-t-NwKl6nEEWE9Yhw-1; Tue, 04 Jul 2023 11:08:51 -0400 X-MC-Unique: nrRpf-t-NwKl6nEEWE9Yhw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-635a3b9d24eso41549296d6.0 for ; Tue, 04 Jul 2023 08:08:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688483331; x=1691075331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YG5bgG5xz7wPUty+JGHhUzL0TZ+jRtrepRY+HZJNLos=; b=W2Gw7RCPRIqyoFVzyRlAx9QYAhJiB3I8vUni5Zv5q801X9DEfkTKaZajugonhT0iCU FlBOepCqinuiQ3/Y9etSJEyhDEWuq0w1r7B60O4Ee5zYMs3wJFQqaB9J02i0etC+7EgC cXfyPX3TQxdU8bPYq/6ypNrI7ShARlPdJvphhHyUCeVdgbfFH2pa5GCBn+VeiIgOkNsp ktK4jTEs4dUP30SXV1hWfWHZ4ICaDwWXHtISBP5JW7vN7fz0wIMFTvxQIOtU4tD1seG/ U5fhUnuzAoCZwT9w0C9UzvK/R06cDVo8AAGKahylNj7IJj1rf9wUINL209IiwZZkuLsU YDzA== X-Gm-Message-State: ABy/qLZ43JwSKNhFoQu27qnEgtBWgO5MQWAgmPJp+j19N0gtnl7cVTdM Rxj8smgvT931wPFeDJH1bUgC41ZJ0KDzt9zFtjTmh6C/mWXZJxFAICpLDnoOb1BgtMGeH14RJFn 61FXdXcKrYXl93ePMIPujlw== X-Received: by 2002:ad4:5ae8:0:b0:631:6eea:c4f0 with SMTP id c8-20020ad45ae8000000b006316eeac4f0mr12118368qvh.48.1688483331197; Tue, 04 Jul 2023 08:08:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlFjqeJE1Ke8zf7E6cx1kotaY1pN/OuRV2goZM5A6E6N0N6bJl9FBdpLYEpO2SwfE3q7E02uVA== X-Received: by 2002:ad4:5ae8:0:b0:631:6eea:c4f0 with SMTP id c8-20020ad45ae8000000b006316eeac4f0mr12118347qvh.48.1688483330920; Tue, 04 Jul 2023 08:08:50 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id ml9-20020a056214584900b0062def68f75csm12556255qvb.124.2023.07.04.08.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 08:08:50 -0700 (PDT) Message-ID: <78b12209-4837-bdd5-8ed0-6bab200b8555@redhat.com> Date: Tue, 4 Jul 2023 17:08:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS To: Andrew Burgess , gdb-patches@sourceware.org Cc: pedro@palves.net, kevinb@redhat.com, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org References: <20230628124205.1604307-2-blarsen@redhat.com> <20230628124205.1604307-3-blarsen@redhat.com> <878rbxm07o.fsf@redhat.com> In-Reply-To: <878rbxm07o.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 03/07/2023 18:25, Andrew Burgess wrote: >> + - Tested-by: >> + >> + Used when a contributor has tested the patch and finds that it >> + fixes the claimed problem. It may also be used to indicate that >> + the contributor has performed regression testing. By itself, this >> + tag says nothing about the quality of the fix implemented by the >> + patch. > Given the number of different ways that tests can be run, and that you > specifically say "It_may_ also be used to indicate ...", I wonder if > it's worth extending the last sentence to specifically say: > > By itself, this tag says nothing about the quality of the fix > implemented by the patch, nor the amount of testing that was actually > performed. > > Some people might give a (tb) tag just for running the tests added by > the commit in question, while others might run the full testsuite on a > unix board, while others might do a full regression test using multiple > different boards. The tag itself tells us very little really. > I'm not opposed to making this document somewhat prescriptive. If you think (and folks agree, of course) that as the tag is describe it tells us TOO little, we could instead require that people do some level of testing. My original idea would be that the person giving the tb tag would at least run a full run of the testsuite on the default board, but I changed it based on previous feedback. Or I can just add this change, whichever you prefer -- Cheers, Bruno