Re: [PATCH v2] [gdb/symtab] Simplify memory management in parse_macro_definition

[Tom de Vries <tdevries@suse.de>]

On 7/24/24 18:12, Tom de Vries wrote:
> On 7/24/24 18:07, Simon Marchi wrote:
>> On 6/26/24 2:32 AM, Tom de Vries wrote:
>>> I noticed that parse_macro_definition does malloc and free, both for the
>>> argv array and its elements.
>>>
>>> Make memory management simpler by introducing a new class
>>> vector_c_string (copied from temporary_macro_definition here [1]) 
>>> that uses an
>>> std::vector for the argv array.
>>
>> Is there a reason to keep using C strings here, instead of a let's say,
>> a vector of std::string?  I gave it a quick try, I have something that
>> builds, just need to test and polish it.
>>
> 
> Hi Simon,
> 
> thanks for the review.
> 
> No, not really, my main goal here is the ability to do a return in 
> parse_macro_definition without introducing a memory leak.
> 
> So that sounds fine to me.
> 

I've looked at the patch.

I've was thrown astray a bit about the macro_special_kind business, 
until I realized it was a pre-existing notion.

Anyway, patch LGTM.

Tested on x86_64-linux, no issues found.

Thanks,
- Tom


> Thanks,
> - Tom
> 
>> Here is it if you want to take a peek: 
>> https://review.lttng.org/c/binutils-gdb/+/13009
>>
>> Simon
>