From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102464 invoked by alias); 13 Oct 2016 23:01:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101463 invoked by uid 89); 13 Oct 2016 23:01:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 23:01:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A71C58E75B; Thu, 13 Oct 2016 23:01:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DN1GRO024894; Thu, 13 Oct 2016 19:01:17 -0400 Subject: Re: [RFA v2 15/17] Convert DWARF expr functions to methods To: Tom Tromey , gdb-patches@sourceware.org References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-16-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <77fe3ede-66ea-93a3-eb9f-50f9c22a06e4@redhat.com> Date: Thu, 13 Oct 2016 23:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476393012-29987-16-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00424.txt.bz2 On 10/13/2016 10:10 PM, Tom Tromey wrote: > This converts various DWARF expr functions to be members on > dwarf_expr_context, then fixes up the various users. This results in > somewhat less wordy code and sets the stage for the next patch. > LGTM. > @@ -122,28 +117,27 @@ dwarf_expr_context::~dwarf_expr_context () > /* Expand the memory allocated to CTX's stack to contain at least > NEED more elements than are currently used. */ I notice that several of the intro comments to functions that are now methods still talk about CTX. Should they be tweaked? Maybe to "to this context's stack". Or maybe they're clear as is anyway. > > -static void > -dwarf_expr_grow_stack (struct dwarf_expr_context *ctx, size_t need) > +void > +dwarf_expr_context::grow_stack (size_t need) > { Thanks, Pedro Alves