From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7633 invoked by alias); 28 Jun 2017 17:22:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7565 invoked by uid 89); 28 Jun 2017 17:22:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2631 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 17:22:42 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 820F6C0587D1; Wed, 28 Jun 2017 17:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 820F6C0587D1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 820F6C0587D1 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8F9317139; Wed, 28 Jun 2017 17:22:40 +0000 (UTC) Subject: Re: [PATCH 15/25] [RFC] GDBserver unit test to i386_tdesc To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-16-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <77cae620-c97f-1baa-a5bf-bf320cb93213@redhat.com> Date: Wed, 28 Jun 2017 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-16-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00768.txt.bz2 On 06/12/2017 09:41 AM, Yao Qi wrote: > This patch adds a unit test in GDBserver to test dynamically created > target descriptions equal to these pre-generated ones. > > gdb/gdbserver: Are these temporary tests? What's the plan for the pre-generated ones? > +#if defined GDB_SELF_TEST && !defined IN_PROCESS_AGENT > +#include "selftest.h" > + > +namespace selftests { > +namespace gdbserver { Considering that at some point we may want to wrap all of gdbserver under "namespace gdbserver", this namespace choice here seems like a poor choice. s/gdbserver/tdesc_tests/ or some such? > +static void > +i386_tdesc_test () > +{ > + const struct target_desc *tdesc = i386_get_ipa_tdesc (X86_TDESC_MMX); > + > + SELF_CHECK (*tdesc == *tdesc_i386_mmx_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_SSE); > + SELF_CHECK (*tdesc == *tdesc_i386_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_AVX); > + SELF_CHECK (*tdesc == *tdesc_i386_avx_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_MPX); > + SELF_CHECK (*tdesc == *tdesc_i386_mpx_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_AVX_MPX); > + SELF_CHECK (*tdesc == *tdesc_i386_avx_mpx_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_AVX_AVX512); > + SELF_CHECK (*tdesc == *tdesc_i386_avx_avx512_linux); > + delete tdesc; > + > + tdesc = i386_get_ipa_tdesc (X86_TDESC_AVX_MPX_AVX512_PKU); > + SELF_CHECK (*tdesc == *tdesc_i386_avx_mpx_avx512_pku_linux); > + delete tdesc; Would something like this, based on an array, work? : struct { int idx; const target_desc *tdesc; } tdesc_tests[] = { { X86_TDESC_MMX, tdesc_i386_mmx_linux }, { X86_TDESC_SSE, tdesc_i386_linux }, ... }; for (auto &elem : tdesc_tests) { std::unique_ptr tdesc (i386_get_ipa_tdesc (elem.idx)); SELF_CHECK (*elem.tdesc == *tdesc); } > diff --git a/gdb/gdbserver/tdesc.h b/gdb/gdbserver/tdesc.h > index 2d4cbfa..e64f0b3 100644 > --- a/gdb/gdbserver/tdesc.h > +++ b/gdb/gdbserver/tdesc.h > @@ -19,7 +19,8 @@ > #ifndef TDESC_H > #define TDESC_H > > -struct reg; > +#include "regdef.h" > +#include Odd that you needed cstring? string.h is one of the system headers always pulled in by common/common-defs.h. > > typedef struct reg *tdesc_reg_p; > DEF_VEC_P(tdesc_reg_p); > @@ -60,6 +61,45 @@ public: > xfree (reg); > VEC_free (tdesc_reg_p, reg_defs); > } > + bool operator!= (const target_desc &other) const Same comment about "operator!=" vs "operator==" as in a previous patch. Thanks, Pedro Alves