From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41225 invoked by alias); 31 Aug 2018 13:04:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41216 invoked by uid 89); 31 Aug 2018 13:04:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_50,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=assure, getcwd, stood, 1038 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 13:04:27 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6231F738E9 for ; Fri, 31 Aug 2018 12:56:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1225510CD78A; Fri, 31 Aug 2018 12:56:23 +0000 (UTC) Subject: Re: [PATCH] Update gnulib to current upstream master To: Sergio Durigan Junior References: <87bm9mnty0.fsf@redhat.com> <87h8jdm0f7.fsf@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: <77a6caaa-1aa5-6007-bb2e-18e563fafa75@redhat.com> Date: Fri, 31 Aug 2018 13:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87h8jdm0f7.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00851.txt.bz2 On 08/29/2018 08:34 PM, Sergio Durigan Junior wrote: > --- /tmp/gnulib1.txt 2018-08-29 15:20:56.394418711 -0400 > +++ /tmp/gnulib2.txt 2018-08-29 15:22:57.846895510 -0400 > @@ -4,13 +4,14 @@ > alloca-opt > assure > at-internal > + builtin-expect > + c99 > canonicalize-lgpl > chdir > chdir-long > cloexec > close > closedir > - configmake > d-ino > d-type > dirent > @@ -30,6 +31,7 @@ > fcntl > fcntl-h > fd-hook > + fd-safer-flag > fdopendir > filename > filenamecat-lgpl > @@ -37,6 +39,7 @@ > float > fnmatch > fnmatch-gnu > + fnmatch-h We have a fnmatch.h replacement file in src/include/, and we include fnmatch.h using quotes ("fnmatch.h"). Hopefully this won't cause weird definition mismatches on hosts where gnulib provides a replacement. Let's keep an eye out on that. > fpieee > fpucw > frexp > @@ -51,6 +54,7 @@ > gettext-h > gettimeofday > glob > + glob-h > hard-locale > include_next > intprops > @@ -59,8 +63,10 @@ > isnand-nolibm > isnanl-nolibm > largefile > + libc-config > limits-h > localcharset > + localtime-buffer > lstat > malloc-posix > malloca > @@ -94,7 +100,7 @@ > rmdir > same-inode > save-cwd > - secure_getenv > + scratch_buffer > setenv > signal-h > snippet/_Noreturn > @@ -103,8 +109,10 @@ > snippet/warn-on-use > ssize_t > stat > + stat-time > + std-gnu11 I wonder whether we should be using std-gnu11 explicitly. > stdbool > stddef > stdint > stdio > stdlib > @@ -130,40 +138,36 @@ > verify > wchar > wctype-h > + xalloc-oversized > > > It doesn't seem like we're importing any important module implicity, nor > that we stopped important anything important, but I may be wrong. > Agreed, I crosschecked the list diff above against , following the links in the leftmost column to check relevant module descriptions, and in some cases looked at the sources of the modules. Nothing big stood out to me. >> Should we cherry pick the getcwd fix to the 8.2 branch? > If you're proposing cherry-picking only the patch to the .m4 file under > the gnulib/ dir, then perhaps we could. This, cherry-pick the getcwd fix that was applied on the gnulib tree. > Backporting the whole gnulib > update is not a good idea, IMHO. But I'm sure that's not what you > meant. That's not what I meant. Thanks, Pedro Alves