From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67049 invoked by alias); 20 Jul 2017 17:15:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57009 invoked by uid 89); 20 Jul 2017 17:15:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:775, indication X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jul 2017 17:15:04 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0489C8B962 for ; Thu, 20 Jul 2017 17:15:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0489C8B962 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0489C8B962 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEF6917B73; Thu, 20 Jul 2017 17:15:01 +0000 (UTC) Subject: Re: [PATCH 22/40] get_int_var_value To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-23-git-send-email-palves@redhat.com> <596D35F6.3010801@redhat.com> From: Pedro Alves Message-ID: <77a52bdf-e276-5b3f-f5e1-57b347f562ca@redhat.com> Date: Thu, 20 Jul 2017 17:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <596D35F6.3010801@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00303.txt.bz2 On 07/17/2017 11:11 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: >> I noticed that get_int_var_value's parameters could use some >> constification. And then realized that client code would become >> simpler by changing the interface to return the success/failure >> indication as actual return value, as allows getting rid of the the >> local "boolean" variable. > > It is certainly more appropriate for Joel to comment, but I did look through the patch, and it is a pretty straightforward change. I didn't notice any issues. Thanks! I want ahead and push it in to get it out of the way of the following, more interesting patches. I'll of course gladly address any concern that Joel may have. Thanks, Pedro Alves