From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id w23OH3dVW2AJYQAAWB0awg (envelope-from ) for ; Wed, 24 Mar 2021 11:06:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 6E25A1EF78; Wed, 24 Mar 2021 11:06:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5D2A1E789 for ; Wed, 24 Mar 2021 11:06:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 53D8F3857C5F; Wed, 24 Mar 2021 15:06:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53D8F3857C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616598390; bh=fQYPy4zxE3B4jKzebeVtSCwXQSUA6x5AuSgdD1/2w3c=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=O8O44oB13KkZ9zpCn9axqNcbD+rLxQYVq/YOzYUK/n4ef902OmiGvWqX2BcO4/paH OX//PLeGL2KSMu3/S6dyiu4RdUvzM7exSOd5wE1N+tfLoGVB92j5KzXAxw0DVYsSzD s2KbeLkfXqazAG+krcrkDI0qLqm3SIOXzFX5CPTQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1E25A3857C5F for ; Wed, 24 Mar 2021 15:06:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1E25A3857C5F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12OF6Lah007730 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 11:06:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12OF6Lah007730 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 06A3D1E789; Wed, 24 Mar 2021 11:06:20 -0400 (EDT) Subject: Re: [PATCH 9/9] C++ compile support To: Keith Seitz , gdb-patches@sourceware.org References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <226bae37-cd78-69e6-17d8-8450690b7b73@redhat.com> Message-ID: <77816529-5985-46c2-a0a7-4d06341ec90e@polymtl.ca> Date: Wed, 24 Mar 2021 11:06:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <226bae37-cd78-69e6-17d8-8450690b7b73@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 24 Mar 2021 15:06:21 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-24 10:51 a.m., Keith Seitz wrote: > On 3/23/21 6:04 PM, Simon Marchi wrote: >> Hi Keith, >> >> I am from the past... > > Hahaha... That's okay; I feel like I am living in the past! > >> On 2018-08-10 7:25 p.m., Keith Seitz wrote: >>> + gcc_decl resuld; >>> + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) >>> + { >>> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; >> >> I don't know if this matters, but the condition above looks reversed, >> can you confirm? > > Wowser. Good catch! > > While it should *of course* be corrected, the first parameter there is > essentially for debugging, so it is not critical that this be propagated > everywhere: Ok, that's what I thought. > > gcc_expr build_decl (const char *debug_decltype, const char *name, > enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, > const char *substitution_name, gcc_address address, > const char *filename, unsigned int line_number); > > Let me know if you want me to clean up my boo-boo or whether you've > patch-in-hand to push already. > > Keith I'd be fine if you pushed a trivial patch. Thanks! Simon