From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KabTMNDhS2r6BioAWB0awg (envelope-from ) for ; Mon, 06 Jul 2026 13:11:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nOeNeTML; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C364E1E098; Mon, 06 Jul 2026 13:11:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 47C3F1E024 for ; Mon, 06 Jul 2026 13:11:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 163464BA2E08 for ; Mon, 6 Jul 2026 17:11:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 163464BA2E08 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nOeNeTML Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012056.outbound.protection.outlook.com [52.101.48.56]) by sourceware.org (Postfix) with ESMTPS id A16934BA2E08 for ; Mon, 6 Jul 2026 17:11:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A16934BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A16934BA2E08 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.48.56 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783357878; cv=pass; b=c6XHO3q+dviYVf3K3K+67/BKCslVItd8Fryj0AD3dwlujEtkgFBKzBDDpn8/ZBLzFvdfhZyKzcm5Gf9R2v0w3253b2y9s66H1Kog/ZE2sA27yT5w6wuc7bbbfn5ruxnQvFyrEb9fqRlNfZmFV6WBLGZbXXqqh8F0kDGKnrcMJck= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783357878; c=relaxed/simple; bh=04suUa5mTnkkVuh4HJbLoHiCxg5Q8C65Xcfcm537/HA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=FmzBqiN3hJFSk7LGnU2GRBJ8XsLfpxmBPiY9gLyoxdJSD1KarhkLxuaZ2rcGP7FEWrX/gNy00Lu4AqgrbWjWpOL85OcupmP3tKo2+OrwQRM86/fWnGZKS0AC5Z7uydrl6XPUbGoGbvFRqEUtSm6rcSyyWQxg1IArL4/K9hpfiaM= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nOeNeTML DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A16934BA2E08 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gUEB7eyguYFgmJ59J9GkNpYVd75UM9mg8FYG6HMhIphWzzMBh7O4b0+f8yh9EnWeeRk996junnsgA5oMDX5EnsqCMQd7o5u18pIbtMp4DDShhn141irtQStPWIoopliH6HJslJo+d5Fg+U30NcTHmlFFqcd6T1nWA/mLOy6YlqvFCn9remxcl+n3r8dir8A7uB+ZzYknsTngjITIcQ3HyTWhFLcAg/bNMjdpy9C6pugOxkoyhs6NnI26JjVJ5q230Z3y3LYOPN/VerJjGPUsCcfggaltOrFU/6aDpZRyO3kca/f1f+d5lNGnNgqOhCNu48enXsSnEUyoXJe5tL2jtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzYrZNukRExauDq0Du5nsIrh6SXKuXy/522O0tymehM=; b=Fly9sypnB0TOKKDLnQLZudgh1zUz/d5E5wtZ7FJn2kYcsQnoglBT3hbR9LPtvmMGiMPt6PNMhPek0jwgBVTtw5cLrYf089miL/BuDaa5QU8KmUuBu+8+plMLh/EaqvJygrOLJr7otTDbMZnMkOJkE5MB81MV982vhBsChRY+KOec2J3BJP4qn9icauFegyFsyDhZeukGI/FYuzo+PpN7/z9PJ1kxea5wVs4SkWKDNgNOFEyAn7bE6rC5jOzoqN7NWQlOBX92zQZllFDevlEH9owhBrXxqtM6ZIPDZWdKUAA6EzjmZnzBtm28jY/e8RXCKintvm3bcg70qgAaNhlxgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=polymtl.ca smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzYrZNukRExauDq0Du5nsIrh6SXKuXy/522O0tymehM=; b=nOeNeTMLWouR+XU3O0Cu5ftzqcmknyyeqJGJmonrKsPMpis4EpVuONHAKEPMkcZYxVTyjzE53xM/aYpBU+1XAAKM4BlM4GbDosnf3bCGwAvnUf06p8B5sPRqe0+fOqcnT2jAA00P+tUXJIrpC2iiTgdur7GydAMKKlg26p2Chw4= Received: from MW4PR03CA0289.namprd03.prod.outlook.com (2603:10b6:303:b5::24) by PH7PR12MB5927.namprd12.prod.outlook.com (2603:10b6:510:1da::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Mon, 6 Jul 2026 17:11:08 +0000 Received: from SJ5PEPF000001C9.namprd05.prod.outlook.com (2603:10b6:303:b5:cafe::2d) by MW4PR03CA0289.outlook.office365.com (2603:10b6:303:b5::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.8 via Frontend Transport; Mon, 6 Jul 2026 17:11:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ5PEPF000001C9.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Mon, 6 Jul 2026 17:11:07 +0000 Received: from khazad-dum (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 6 Jul 2026 12:11:06 -0500 Date: Mon, 6 Jul 2026 18:10:54 +0100 From: Lancelot SIX To: Simon Marchi , Subject: Re: [PATCH v2 6/10] gdb/solib-rocm: save inferior in rocm_solib_ops Message-ID: <77767e8e-8de6-4048-afd3-64fcc463fb5a@satlexmb08.amd.com> References: <20260608200100.666134-7-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260608200100.666134-7-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb08.amd.com (10.181.42.217) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C9:EE_|PH7PR12MB5927:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a6e8922-9905-4dbe-c302-08dedb8191d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|82310400026|1800799024|36860700016|56012099006|11063799006|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: sDyJTY+MrPq/vd3gQDORYW8BOMQ0PbX2V9Dw0NXVmyzZQxwNbnlpApYX85HKQ4tKfP+uwQLaMMOZEzKPcxCln7sgkMPCgjpDh1lbyLUEWhTmHTF9ynMMejRH87DGHY8Kze5UYTb2taKLJ9mH//OAE6qbNNXk+eAiMXzqFw4MvVfBqUGjPuEgmb/KXHJkQHIanyuEw5C9E/jx9OjQnZKT0KvoxtHkiS+Jy3my0vmgq1AjvHdDGUiom+qHDnacHmYXuYMWKnp268HmW3MkyeqVDaMUe4IeRVyNVkIM+13mj8rMPpwIX+K/Gexw60YhelCWWOhz8zqHA3k9X11A27pkZv7xfQ1RjxzC5LRq16TLerqLXrC0Ky+wjNv6BoEm2JJTh7Mf9blDdZM7pgk2Nxg0L4xKoBGsHz+CIHMMxGvT2hIn9vXNzbZZe/dwPkeTJTfunjAcsGHhP7Tmskh0yGgZ/53GE7qgnjz/jZnF8Z6SfT8Dlwgs/5mwYyvzzZeUNHF56u8FqUFoYosf/yFKh2KPNfwMwsjv1opBSkghGwDVCdwWn8Wm4lEaWU0oUYnsoBPqC+T6GRBJWflds+sreAbjt3cZ2NkpxoG2lix8u4PmySlfb1a4AVCOiFT2gHJBkeqyRN8xMQ2N1/CDl6YYBwOlS0yoJlZCcQYzUXNqrnQQc8yJ2XKYtzu2Y6C9EWgAU4L0js/ZRtl2sGCqOAWuQow2Lg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(23010399003)(82310400026)(1800799024)(36860700016)(56012099006)(11063799006)(22082099003)(18002099003)(3023799007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7SaS+IWfNvqYNWhbvpZaIVOETAga/HYTK2fZ1KKzNcRsS262+bEFtgojzqE+LQ7nxxFJHbtj/lvwPYSHvavc72djBrFVUbFAzjEdYkt+aeHqYBSiMsLD50R0+tRFGhxKGJbMLI9WJUL8thxUwlpklvjhN+/Z9vXltZ9e1ZegZJ0UhPSJEVTSVstfvHgBWZLKBN6l1sbdJN4gWzAdcNmrZq6iDegHCNH7+aTj+cI7WKFI6qS0uaufoCl58I2bZR1UlA9HYUldGNX2FvjPeJ6PaCiI+Hc/pdE9N9Bd7omeLBcJWOqoDV3RN51hmIBKRa8Wj+vr/je3vWdkDofyA+zPxXCoEFCKVrbAnLEjftaWH+YrTdg7P/bE8xjTjHnZ0pFstGgSpzpANNF8vzZC4QtGu81w8QA7GBmNIEXiC7lFldtDKd+AuJchNw4AvNXDOLK9 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2026 17:11:07.6351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a6e8922-9905-4dbe-c302-08dedb8191d8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5927 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Jun 08, 2026 at 04:00:30PM -0400, Simon Marchi wrote: > Storing the inferior in rocm_solib_ops lets us avoid some calls to > current_inferior(). > Hi Simon, This looks good to me. Thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > Change-Id: Icf36bbef031eda7b776cd735a91a2ff918697dd3 > --- > gdb/solib-rocm.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c > index 618f4f5e7905..0a284dfb0a56 100644 > --- a/gdb/solib-rocm.c > +++ b/gdb/solib-rocm.c > @@ -189,7 +189,7 @@ struct rocm_solib_ops : public solib_ops > in order to provide support for ROCm code objects. */ > explicit rocm_solib_ops (inferior *inf, solib_ops_up host_ops) > : solib_ops (inf->pspace), m_host_ops (std::move (host_ops)), > - m_fd_cache (inf) > + m_inf (inf), m_fd_cache (inf) > { > gdb_assert (m_host_ops != nullptr); > gdb_assert (dynamic_cast (m_host_ops.get ()) == nullptr); > @@ -260,10 +260,13 @@ struct rocm_solib_ops : public solib_ops > private: > owning_intrusive_list > solibs_from_rocm_sos (const std::vector &sos); > - gdb_bfd_iovec_base *bfd_iovec_open (bfd *abfd, inferior *inferior); > + gdb_bfd_iovec_base *bfd_iovec_open (bfd *abfd); > > solib_ops_up m_host_ops; > > + /* Inferior this rocm_solib_ops is for. */ > + inferior *m_inf; > + > /* List of code objects loaded into the inferior. */ > std::vector m_solib_list; > > @@ -510,7 +513,7 @@ rocm_code_object_stream_memory::read (bfd *, void *buf, file_ptr size, > } /* anonymous namespace */ > > gdb_bfd_iovec_base * > -rocm_solib_ops::bfd_iovec_open (bfd *abfd, inferior *inferior) > +rocm_solib_ops::bfd_iovec_open (bfd *abfd) > { > std::string_view uri (bfd_get_filename (abfd)); > std::string_view protocol_delim = "://"; > @@ -637,7 +640,7 @@ rocm_solib_ops::bfd_iovec_open (bfd *abfd, inferior *inferior) > if (protocol == "memory") > { > ULONGEST pid = try_strtoulst (path); > - if (pid != inferior->pid) > + if (pid != m_inf->pid) > { > warning (_("`%s': code object is from another inferior"), > std::string (uri).c_str ()); > @@ -683,7 +686,7 @@ rocm_solib_ops::bfd_open (const char *pathname) > > auto open = [this] (bfd *nbfd) > { > - return this->bfd_iovec_open (nbfd, current_inferior ()); > + return this->bfd_iovec_open (nbfd); > }; > > gdb_bfd_ref_ptr abfd = gdb_bfd_openr_iovec (pathname, "elf64-amdgcn", open); > @@ -772,9 +775,7 @@ rocm_solib_ops::create_inferior_hook (int from_tty) > void > rocm_solib_ops::update_solib_list () > { > - inferior *inf = current_inferior (); > - > - amd_dbgapi_process_id_t process_id = get_amd_dbgapi_process_id (inf); > + amd_dbgapi_process_id_t process_id = get_amd_dbgapi_process_id (m_inf); > if (process_id.handle == AMD_DBGAPI_PROCESS_NONE.handle) > return; > > -- > 2.54.0