From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81663 invoked by alias); 29 May 2019 12:38:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81654 invoked by uid 89); 29 May 2019 12:38:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:U*palves X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 12:38:00 +0000 Received: by mail-wr1-f68.google.com with SMTP id c2so1652023wrm.8 for ; Wed, 29 May 2019 05:38:00 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id p10sm14737188wrw.6.2019.05.29.05.37.57 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 05:37:57 -0700 (PDT) Subject: Re: [RFAv3 2/6] Improve process exit status macros on MinGW To: Eli Zaretskii References: <20190504161753.15530-1-philippe.waroquiers@skynet.be> <20190504161753.15530-3-philippe.waroquiers@skynet.be> <83muj7216g.fsf@gnu.org> Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <77691670-d0ed-6094-c48d-3a3ced99a5b8@redhat.com> Date: Wed, 29 May 2019 12:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83muj7216g.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00622.txt.bz2 On 5/27/19 7:37 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Mon, 27 May 2019 18:33:11 +0100 >> >> I admit to being a bit confused about why we want to do this >> translation for this feature while we don't do it for the exit code >> of inferiors running under gdb, for example. I mean, exit status >> with 0xc0000000 set don't cause $_exitsignal to be set instead of >> $_exitcode. > > We should probably do this everywhere where it matters whether the > inferior exited due to a fatal signal. Wouldn't it better to leave that translation out of this patch series, and do it everywhere it matters as a separate change, to avoid creating inconsistencies? Might be simpler for Philippe too, since the current patch isn't OK as is. Thanks, Pedro Alves