From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 9A1CC386F434
 for <gdb-patches@sourceware.org>; Sun, 24 May 2020 14:24:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9A1CC386F434
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 04OEONDq013901
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Sun, 24 May 2020 10:24:28 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 04OEONDq013901
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 63B341E5F9;
 Sun, 24 May 2020 10:24:23 -0400 (EDT)
Subject: Re: [committed][gdb/testsuite] Fix tcl error in jit-elf-helpers.exp
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
References: <20200512124337.GA27812@delia>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <77635b98-dd74-41d7-42d3-ae3b88f896cf@polymtl.ca>
Date: Sun, 24 May 2020 10:24:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200512124337.GA27812@delia>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 24 May 2020 14:24:23 +0000
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 24 May 2020 14:24:38 -0000

On 2020-05-12 8:43 a.m., Tom de Vries wrote:
> @@ -94,8 +96,10 @@ proc compile_and_download_n_jit_so {jit_solib_basename jit_solib_srcfile count}
>  	    additional_flags=-DFUNCTION_NAME=[format "jit_function_%04d" $i] \
>  	    additional_flags=-Xlinker \
>  	    additional_flags=-Ttext-segment=$addr]
> -	if { [gdb_compile_shlib ${jit_solib_srcfile} ${binfile} $options] != "" } {
> -	    untested "failed to compile ${jit_solib_basename}.c as a shared library"
> +	if { [gdb_compile_shlib ${jit_solib_srcfile} ${binfile} \
> +		  $options] != "" } {
> +	    set f [file tail $binfile]
> +	    untested "failed to compile shared library $binfile"
>  	    return -1

I just noticed, should it be `$f` instead of `$binfile` here?

Simon