Re: [PING][PATCH] gdb/docs: add parentheses in Python examples using print

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

I think we were just missing for someone to push the patch, so I did it.

Simon

On 2021-01-25 9:07 a.m., Marco Barisione via Gdb-patches wrote:
> Ping.
> 
> On Fri, 8 Jan 2021 at 09:29, Marco Barisione <mbarisione@undo.io> wrote:
>>
>> This makes the examples work both in Python 2 and 3.
>>
>> gdb/doc/ChangeLog:
>>
>>         * python.texi: Add parentheses to print statements/functions.
>> ---
>>  gdb/doc/python.texi | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
>> index 0f776f54768..da81906d03d 100644
>> --- a/gdb/doc/python.texi
>> +++ b/gdb/doc/python.texi
>> @@ -559,7 +559,7 @@ rather recognizes it when thrown from user Python code.  Example:
>>  >    argv = gdb.string_to_argv (args)
>>  >    if len (argv) != 0:
>>  >      raise gdb.GdbError ("hello-world takes no arguments")
>> ->    print "Hello, World!"
>> +>    print ("Hello, World!")
>>  >HelloWorld ()
>>  >end
>>  (gdb) hello-world 42
>> @@ -3100,8 +3100,8 @@ Here is an example:
>>
>>  @smallexample
>>  def exit_handler (event):
>> -    print "event type: exit"
>> -    print "exit code: %d" % (event.exit_code)
>> +    print ("event type: exit")
>> +    print ("exit code: %d" % (event.exit_code))
>>
>>  gdb.events.exited.connect (exit_handler)
>>  @end smallexample
>> @@ -3921,7 +3921,7 @@ class HelloWorld (gdb.Command):
>>      super (HelloWorld, self).__init__ ("hello-world", gdb.COMMAND_USER)
>>
>>    def invoke (self, arg, from_tty):
>> -    print "Hello, World!"
>> +    print ("Hello, World!")
>>
>>  HelloWorld ()
>>  @end smallexample
>> @@ -4309,7 +4309,7 @@ def clear_objfiles_handler(event):
>>      event.progspace.expensive_computation = None
>>  def expensive(symbol):
>>      """A mock routine to perform an "expensive" computation on symbol."""
>> -    print "Computing the answer to the ultimate question ..."
>> +    print ("Computing the answer to the ultimate question ...")
>>      return 42
>>  def new_objfile_handler(event):
>>      objfile = event.new_objfile
>> @@ -4654,7 +4654,7 @@ versions.  Using it, you could write:
>>  reason = gdb.selected_frame().unwind_stop_reason ()
>>  reason_str =  gdb.frame_stop_reason_string (reason)
>>  if reason >=  gdb.FRAME_UNWIND_FIRST_ERROR:
>> -    print "An error occured: %s" % reason_str
>> +    print ("An error occured: %s" % reason_str)
>>  @end smallexample
>>  @end table
>>
>> @@ -5295,7 +5295,7 @@ example illustrating iterating over a line table.
>>  symtab = gdb.selected_frame().find_sal().symtab
>>  linetable = symtab.linetable()
>>  for line in linetable:
>> -   print "Line: "+str(line.line)+" Address: "+hex(line.pc)
>> +   print ("Line: "+str(line.line)+" Address: "+hex(line.pc))
>>  @end smallexample
>>
>>  This will have the following output:
>> @@ -5618,11 +5618,11 @@ method:
>>  @smallexample
>>  class MyFinishBreakpoint (gdb.FinishBreakpoint)
>>      def stop (self):
>> -        print "normal finish"
>> +        print ("normal finish")
>>          return True
>>
>>      def out_of_scope ():
>> -        print "abnormal finish"
>> +        print ("abnormal finish")
>>  @end smallexample
>>  @end defun
>>
>> --
>> 2.28.0
>>