From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59586 invoked by alias); 27 Jun 2017 13:17:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59569 invoked by uid 89); 27 Jun 2017 13:17:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 13:17:10 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C712BC04B946; Tue, 27 Jun 2017 13:17:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C712BC04B946 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C712BC04B946 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D26F08A77F; Tue, 27 Jun 2017 13:17:07 +0000 (UTC) Subject: Re: File name convention ARCH-OSABI-tdep.c To: Yao Qi , gdb-patches@sourceware.org References: <868tklhct8.fsf@gmail.com> Cc: weimin.pan@oracle.com From: Pedro Alves Message-ID: <774b16af-c8d7-baa7-5b67-bf4c98378da6@redhat.com> Date: Tue, 27 Jun 2017 13:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <868tklhct8.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00728.txt.bz2 On 06/21/2017 11:09 AM, Yao Qi wrote: > > Hi, > I want to extend the *-tdep.c file name convention. The current > convention is ARCH-OSABI-tdep.c, and I want to extend it to > ARCH-OSABI-tdep-FUNC.c, in which FUNC is about a certain functionality > or feature about this target. > > The sparc64 adi patch > (https://sourceware.org/ml/gdb-patches/2017-06/msg00472.html) adds a new > file sparc64-adi-tdep.c which should be merged to sparc64-tdep.c > according to the current naming convention. However, I think it is good > to put different things in different files. So with the new convention > proposed here, the new file can be sparc64-tdep-adi.c. > > Secondly, some *-tdep.c files are already quite large, arm-tdep.c is of > 399434 bytes, 13318 lines. It is the 5th largest file. arm-tdep.c > includes many things which are not related to each, like displaced > stepping and process record. I am thinking that we should allow people > moving them out of *-tdep.c to *-tdep-displaced.c and *-tdep-precord.c. > This is fine with me. I definitely agree with splitting big files in smaller pieces. Thanks, Pedro Alves