From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99304 invoked by alias); 16 Nov 2016 19:11:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99290 invoked by uid 89); 16 Nov 2016 19:11:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 19:10:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EA0A769FA; Wed, 16 Nov 2016 19:10:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAGJAnCr004812; Wed, 16 Nov 2016 14:10:50 -0500 Subject: Re: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules To: Simon Marchi , gdb-patches@sourceware.org References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-4-simon.marchi@ericsson.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <773f613d-7157-258e-bb1c-daf86a7ec0d3@redhat.com> Date: Wed, 16 Nov 2016 19:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116160808.12830-4-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00446.txt.bz2 On 11/16/2016 04:08 PM, Simon Marchi wrote: > From: Simon Marchi > > As mentioned here [1], suffix rules are obsolete and have been > superseeded with pattern rules. People (myself included, before writing > this patch) are more likely to know what pattern rules are than suffix > rules. > > AFAIK, .SUFFIXES targets are only used for those rules, and can be > removed as well. > > New in v2: > > - Replace rule in gdbserver/Makefile.in as well. > > [1] https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html > > gdb/ChangeLog: > > * Makefile.in (.c.o): Replace rule with ... > (%.o: %.c): ... this one. > (.po.gmo): Replace rule with ... > (%.gmo: %.po): ... this one. > (.po.pox): Replace rule with ... > (%.pox: %.po): ... this one. > (.y.c): Replace rule with ... > (%.c: %.y): ... this one. > (.l.c): Replace rule with ... > (%.c: %.l): ... this one. > (.SUFFIXES): Remove all instances. > > gdb/gdbserver/ChangeLog: > > * Makefile.in (.c.o): Replace rule with ... > (%.o: %.c): ... this one. IMO, whether to explicitly remove default suffixes from the the implicit rule suffixes list for efficiency is a separate subject, since we're not currently doing it either. Just to be sure none of the default suffix rules is necessary, can you confirm: 1. that "make -r" (from scratch) still works. 2. that "make -r diststuff" in the gdb build dir still works. If the above work, then this is OK with me to push in. Thanks, Pedro Alves